From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513472D7398 for ; Mon, 11 May 2026 10:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778493724; cv=none; b=PqqPYvogxJ4D9nTuoVoLy3DnX4sz9U4Uw+Iwr2zq23FadIcgd3lphE/2hY+yS7VxqnlFY/etkGsk4Nf2Ixm1c8aeXRpbZIZgvTUhIX7f7ZsiPjEkzRJJXrOk73i/bblZb6EsAmealS8ClQLOLHnKnAo7TQtRD+BW29gX8pw/vQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778493724; c=relaxed/simple; bh=JNiYQmsYCBUUZDsrDAH1HR51mOfkmhfC5EqZAOv91Qg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G05YNCFkGMPa0/F7qlFdtp6qLJlMC+VfMr01cRXdflCYhD23Az3l+7n7spUBH7B3LoFHhf16CSST6mnrQ2w9SVEsNn0bdmBsJ79pXsbF7rcMmNE1ZM1q0dVoAeVbW8DFwnQbitH86oocyiawQYYv++MjRm5sYtHD+7rZ1vabwu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NqkfG0s8; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NqkfG0s8" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3665a90bcd3so2456211a91.1 for ; Mon, 11 May 2026 03:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778493723; x=1779098523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BzYQbTh4CweYWONe7kp2YWa8+xOQ2qVZjBV6+S9phz8=; b=NqkfG0s863VDm+vztYGkONoyO3fk/3EdHW3zTeLra6n5RxQo1+LnSZR2VqFG1c+iCb IL4t0tLbR0dX+jjlXefeB+bYpKG156jJKiq3Fvhwd8xKLPVbWDfT/EH8zJ7M6nR7nXKZ YMZ/MhsxRsMPgDWg+y4tE2FDjTd7tzwW1fsJJc8sdbtOaeULfjegT7pPa+7/eRzKA5LC lsHkmPOn0ftVEGmIvw3ZUauIhCT2I3+3ZxsPpjWj3RxJRH124sbpEpUwfcpD33SBWcuA a8z5ialjj47+mDxgkFkLyGtCCISVI2Mv8p93EIqmsernwbc9prTjWwi+OJf6PnBEDjus 1qcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778493723; x=1779098523; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BzYQbTh4CweYWONe7kp2YWa8+xOQ2qVZjBV6+S9phz8=; b=aBFEQ8Hx4QEo1SeyVMI9Rr541S1SzqSncY3BwRmlEHuyOlxJsWVc5tqUaaJ/9GgF86 HsaDt42DyNuWh53piXx1DX3ch309iI2VpUz/yAaxJobRsBrOjJeDNXAV8nY8ZeMIgOkD gThe4X+3IUGvK1nf70SZbOEp615Luzq5PS5qPXyFCZ4JW/IIbA8bt5qlIMfqN3nn7APn rlhgsh7mrZDEp+3fDYTlzV3/7a9GY4/bCJm50LfYd5mS7Kp31KfeVL+5q64gTQrjm0Ai ZyaZgAM9DebcpU9giDmifj1RclLJ+o3qb8Kyo4o+kXQekF3BDoaPwD4W7rR84J91FEJY gJpw== X-Forwarded-Encrypted: i=1; AFNElJ+sGZpWDpX0WqlU8XlpKC/eFp1JA0DbYYGCwu7Yjqcx05ZjYc/eFKEWRS7TGSjt++O9sqamC1v10UYGzJk=@vger.kernel.org X-Gm-Message-State: AOJu0YyLSAXbhk6jZTeASc905jXmTk2jGED5G0zMsEdNulJTClDepOzZ 4ApRDmlkRuIgcP7J2hsd9bDsDBhewLifQw8iU2ebzP58WJL0RzCPz0Cd X-Gm-Gg: Acq92OGDuh7CoGHGw2uzgvz7Rk08hRGz/TrhzFhJhozYQkT271cI/IZ7f7p9hWYCH1M 5FwwLyuBgdxQKp2C+AfwtlmLpXBqiHuoDqXeWWEDDkBoK8+aycea0p1y1Cwim+yXudWkXUkg3GG NPfppeWDxWRWHBpOVrUvFnMv3m6GTwmQMXWac6VkaOOCGWBWhycg7jDtokocg9XZY/dB+ABQBhc NygXOlpBoVpGF/qZhL+/+Pn2p9fUR7mAuyNIhb58ylsGPfESWLWIrlp2zoM4ADFMJg3WNxRHTKZ H8dave9DmEwGJe9v6TQJ3CTz5tz9hpxn76VXRxPsmvkQJvIny7pgXNQCcMhrbZxr/runwBg2DXX V9Z71Kn0doNg8P69e6ZIGL7AuZvgeybX151Nt3CxpLgwYjX+7t6KxAsZlSSCcvQ5xZ1cATzESqL +aoMIX16IrxnIal4/pTMgmRsP097fjB72eCIn5YIdU X-Received: by 2002:a17:90b:3ecd:b0:366:1172:597e with SMTP id 98e67ed59e1d1-367d46b8236mr8511990a91.9.1778493722662; Mon, 11 May 2026 03:02:02 -0700 (PDT) Received: from MAHADEV.localdomain ([103.211.132.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d65ed459sm9243825a91.14.2026.05.11.03.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 03:02:02 -0700 (PDT) From: Harshit Shaw To: deller@gmx.de Cc: tzimmermann@suse.de, chintanlike@gmail.com, andriy.shevchenko@intel.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Harshit Shaw Subject: [PATCH] staging: fbtft: check return value of device_create_file() Date: Mon, 11 May 2026 10:01:40 +0000 Message-ID: <20260511100140.4794-1-shawharshit116@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit device_create_file() can fail but its return value was being ignored in fbtft_sysfs_init(). Check the return value and emit a warning if sysfs file creation fails. Signed-off-by: Harshit Shaw --- drivers/staging/fbtft/fbtft-sysfs.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index d05599d80011..cc6dbaeb6043 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -204,14 +204,21 @@ static struct device_attribute debug_device_attr = void fbtft_sysfs_init(struct fbtft_par *par) { struct device *dev; + int ret; dev = dev_of_fbinfo(par->info); if (!dev) return; - device_create_file(dev, &debug_device_attr); - if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(dev, &gamma_device_attrs[0]); + ret = device_create_file(dev, &debug_device_attr); + if (ret) + dev_warn(dev, "failed to create debug sysfs entry\n"); + + if (par->gamma.curves && par->fbtftops.set_gamma) { + ret = device_create_file(dev, &gamma_device_attrs[0]); + if (ret) + dev_warn(dev, "failed to create gamma sysfs entry\n"); + } } void fbtft_sysfs_exit(struct fbtft_par *par) -- 2.53.0