From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9142B3A3E9C; Mon, 11 May 2026 12:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778503597; cv=none; b=BHJXS8IIR4+qzcILx7UURg8st/nvzHpC7MuTeBZ7l9lbIQR8ndmIzA9jgauiKH3CjryvE4B7kAP/AZ6dXt3Lym2EL4uBcCOV5XBQ+ALuPZmtA9lbgljPKyrs1ulsepYxL3lgIKE5GQQct9hDtf1sAsjnAkZIVGxKby7sD0CHGJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778503597; c=relaxed/simple; bh=oiytH4jcOOQ4aVAeWSl58QOPMIeSZGNgc/9D75Azq10=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MHhjQ/QzGQZErovYR5vyz78uSAax4bZEBNsl7lUB8U72RCnWm0sOqAE77pWhHg2J/YtecLFXATHs/4+plQ3i1Sn0Cgjik88TZtFy209Qn6Mb7OacLejq4r19BKhuldhSdCiry/i1hRrglvbSJU602PtlIwYRgsI4Lqo1yC/2JD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=q5riTVlg; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="q5riTVlg" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1778503591; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=jj4XmQSi4do2CwZ55558GXwNtUuL4SsD8XOJuifWJt4=; b=q5riTVlgxdkQL1EsIV16UqEu2A7jASvgnLay5EOcKQKdRRRRJMQlTqv74jSq3PA9a7BOlyDP+pEqYw7WtblHHUfRNQTl9CyLVqmml7vXopp2O55SS0TJnZyQQqUTzz6fDM0tLYhDYr8QuQndxnHz7p4F9rtnqWVqaKKK/Fr3hig= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032089153;MF=mengferry@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0X2jWrKK_1778503586; Received: from localhost(mailfrom:mengferry@linux.alibaba.com fp:SMTPD_---0X2jWrKK_1778503586 cluster:ay36) by smtp.aliyun-inc.com; Mon, 11 May 2026 20:46:30 +0800 From: Ferry Meng To: stable@vger.kernel.org Cc: Namjae Jeon , Steve French , Sergey Senozhatsky , Tom Talpey , Henrique Carvalho , Greg Kroah-Hartman , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Ferry Meng Subject: [PATCH 6.6.y] ksmbd: make ksmbd thread names distinct by client IP Date: Mon, 11 May 2026 20:46:25 +0800 Message-Id: <20260511124625.52768-1-mengferry@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Namjae Jeon commit 5da92a251e41f824d7e6b4d54d65dcdcfd69fda3 upstream. [backport needed for 6.6-stable to close a residual active_num_conn leak. Commits 787769c8cc50 (upstream 77ffbcac4e56, "smb: server: fix leak of active_num_conn in ksmbd_tcp_new_connection()") and 97f8d2648ef4 (upstream 6551300dc452, "smb: server: fix active_num_conn leak on transport allocation failure") were backported to 6.6.y, but upstream 77ffbcac4e56 was built on top of this commit, which removes kernel_getpeername() and the out_error: label in ksmbd_tcp_new_connection(). Without this commit, the kernel_getpeername() failure path still calls free_transport(t) and leaks active_num_conn, eventually exhausting max_connections until the module is reloaded.] This patch makes ksmbd thread names distinct by client IP address. 100943 ? S 0:00 [ksmbd:::ffff:10.177.110.57] or 101752 ? S 0:00 [ksmbd:10.177.110.57] Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Ferry Meng --- fs/smb/server/transport_tcp.c | 39 ++++++++++++----------------------- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c index e55afd0c9bf4..f04aa8c504ff 100644 --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -173,17 +173,6 @@ static struct kvec *get_conn_iovec(struct tcp_transport *t, unsigned int nr_segs return new_iov; } -static unsigned short ksmbd_tcp_get_port(const struct sockaddr *sa) -{ - switch (sa->sa_family) { - case AF_INET: - return ntohs(((struct sockaddr_in *)sa)->sin_port); - case AF_INET6: - return ntohs(((struct sockaddr_in6 *)sa)->sin6_port); - } - return 0; -} - /** * ksmbd_tcp_new_connection() - create a new tcp session on mount * @client_sk: socket associated with new connection @@ -195,7 +184,6 @@ static unsigned short ksmbd_tcp_get_port(const struct sockaddr *sa) */ static int ksmbd_tcp_new_connection(struct socket *client_sk) { - struct sockaddr *csin; int rc = 0; struct tcp_transport *t; struct task_struct *handler; @@ -208,27 +196,26 @@ static int ksmbd_tcp_new_connection(struct socket *client_sk) return -ENOMEM; } - csin = KSMBD_TCP_PEER_SOCKADDR(KSMBD_TRANS(t)->conn); - if (kernel_getpeername(client_sk, csin) < 0) { - pr_err("client ip resolution failed\n"); - rc = -EINVAL; - goto out_error; - } - +#if IS_ENABLED(CONFIG_IPV6) + if (client_sk->sk->sk_family == AF_INET6) + handler = kthread_run(ksmbd_conn_handler_loop, + KSMBD_TRANS(t)->conn, "ksmbd:%pI6c", + &KSMBD_TRANS(t)->conn->inet6_addr); + else + handler = kthread_run(ksmbd_conn_handler_loop, + KSMBD_TRANS(t)->conn, "ksmbd:%pI4", + &KSMBD_TRANS(t)->conn->inet_addr); +#else handler = kthread_run(ksmbd_conn_handler_loop, - KSMBD_TRANS(t)->conn, - "ksmbd:%u", - ksmbd_tcp_get_port(csin)); + KSMBD_TRANS(t)->conn, "ksmbd:%pI4", + &KSMBD_TRANS(t)->conn->inet_addr); +#endif if (IS_ERR(handler)) { pr_err("cannot start conn thread\n"); rc = PTR_ERR(handler); ksmbd_tcp_disconnect(KSMBD_TRANS(t)); } return rc; - -out_error: - free_transport(t); - return rc; } /** -- 2.43.5