From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852E93B19AA for ; Mon, 11 May 2026 13:01:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504495; cv=none; b=UPrKqXq0JdF+yCpagBacnqRWyFqYiLK8WBDVFwq32CVDsP6ydmcOBRjTjYJGgjuKIvDhlQGIhzAzWQin1uUHeKrRE518P0XmkwCkMXbJoaMReuAdsmBHb9kO1R03bEidFvyTGsPtT7NqanolUj/7GJkKO69wxEBkoy/iviXfUQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504495; c=relaxed/simple; bh=CjOeIMd7KHhgBlYgalqgDMr3CrElSHV/LHeYqaaaD9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B5DNUVRcfBBOcrsRwr9sYRaobEsl/2jD+t6KgCjNRDLksoCVpJHE5WMeZItfs4XU1skxkOZ5TS6hN28XtF268esGpvJ/vpfXa0H4sDFx1z8OrO3Vk05KXuaOSOrAI4p5bdhT9DU4EGJx65KP5EmHhjS9/fuN3cVVXMR2Thkre0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eeqTjDuR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=coQeKZUX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eeqTjDuR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="coQeKZUX" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64BBIec91345083 for ; Mon, 11 May 2026 13:01:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=zVhhihIWGcW DVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=eeqTjDuRBlJtvff1iwj74lli22x ZOr8cSr7/ZfiKBHclS65TbGdaQBfogF0nV9RhjoRhaZJXpHOjtSgB87ennT9kOuZ f9to+xxw/DLbHlU957C+Q0eFTXDxSywGWs4ouAwYAxxtnG1mMaOOvH9HhjikIJfm JHMidatSp+YwRnSI9OTwpb/p+5ba6cUZU8xLyy/bUSXaCgqcQZpt5ePPEUxM0wII 5btuZVzMwcaLcf873D1sgkNsG8Jd7R9p2bLVx4gojf56Dmz3xUhnluL5/FgtVNSG wCR976KHtpXMkn3oPErzqqSQW+Ssk2ve0qVlWOtwcDerU4TUbxxq2HCrN0g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3e498afh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 13:01:30 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b99eb06178so88526235ad.2 for ; Mon, 11 May 2026 06:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778504490; x=1779109290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zVhhihIWGcWDVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=coQeKZUXbsvEC1cli8tGQupNoPKgImPdvbugjqBFf5rRh7eb8m9P8o4YelymAReUQr zmgGhFbJuMM0oZ2HXysB6HY4SH0SC1aBxQSvBpyYP0DvKvTj6aslRBITOubRUwSG7eEa Bb/tydFw4Ruiq4L3kMh4lXbAFbrxEKW+qeiTLruqMmwg8s9040UdiWoA+ti7oj8Ripoa z1V/MZwStg4WBYBXK2jjrsBTgkzj7iIIf/WTP1feGV5bLkqtZf+u/PuPP1PiffjltBv9 iV3YYba6gNPdCNsuvbe1cx7NBMSL6qjlQpeCRvp6vPKo3lY/UZ5LuIoc2aUWvdkpzQNJ 49LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778504490; x=1779109290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zVhhihIWGcWDVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=q6ex326nwMmVj3z/Rryl0oVOua69vD+e1csgIKYCQy/D30bX0Ycc19bq4NT7nhqvsE mAdgjIjnYYKqHcDLYUenilLWc7xy513RnZY99YHS7KPj/yJF8mT18McW0E1C/kgyUWmv KivQiGSVkeES63qkhg7i7MvTybX+0czmIGLDVCwp6ywscMLvKYWcsuJUNMDoCDeINkTx LSuTRwewMUUIhTlghZx7cXNVrsNpNz1tWiu7gasLbGxj9dInUju4+7kB6LLvdv14RKAO 5Tq8JphXk1ElP3PDggoX5ejG+HyqaTcMPMuqIH8FWYyk3gYsSlxwe+pxPPbgeOqXVOj4 tXvQ== X-Forwarded-Encrypted: i=1; AFNElJ9wZFFzsco9YcNeGs/pKdRtBXgwmIBBrgWSHuRlop2JP2P7scnODTPAkU2CSsvmcySilKv9ySTVDfa+g+g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy8r4XLXYPBofyWR4hXoeDjqZTUkalRIJcTbFEksxNkQq9rkgl IPy49k35rxRvf5le3uS2sWaaxgQd7Jc9sjTLLysuRuYOv99RkgX1d2wqMEqGBHYHG5BaqaHfGWK TUFKF02IzrjAo9SCAf9sCiK+O8w/i/BpeLU3CjqVLbu68UQqsgfTTMBZ/Zr/QuVXoObE= X-Gm-Gg: Acq92OHP0N8zfqscS3ZJVZumXmFgJDLdJo/cV2jX7c4Ye8bl8N9N47HfO08jz7J1pq9 DAcqAAn59ODmr8AqnfsxVZaysYFlaWKLXildzEMjC/6BOVscawM0qNpq8Bm801U04Z6NIDcK4H0 vV740YuxbcYzsof/Q18ro5L7u47EoKjzr+0Qhc5f1JgYqhwnhAjYPys1VrhX+YBHWgQui8qAUR4 TTDPsZjZmug0qbZkSQwQeTKCgYaoMgAKq6j7Xe7sjWcj97uzn+esvaADx6lv2qK/CAB2kOjtI0l K5zPH0nRam9y4kLICOMRWAiIR4PGyzzY4faX6BvL96/xQKPxavsD96aZcG1BdVRTeQfhq7ozLX7 f X-Received: by 2002:a17:903:280e:b0:2b2:50e1:f104 with SMTP id d9443c01a7336-2ba78f63defmr184146525ad.3.1778504489570; Mon, 11 May 2026 06:01:29 -0700 (PDT) X-Received: by 2002:a17:903:280e:b0:2b2:50e1:f104 with SMTP id d9443c01a7336-2ba78f63defmr184145755ad.3.1778504488598; Mon, 11 May 2026 06:01:28 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d2700dsm107146375ad.2.2026.05.11.06.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 06:01:27 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 12/16] drm/msm/a8xx: Add perfcntr flush sequence Date: Mon, 11 May 2026 05:59:25 -0700 Message-ID: <20260511130017.96867-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> References: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: rZMxFtuZYqY4b89D8xWJW4kaRW8bLg_J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDE0NCBTYWx0ZWRfX0z6BPksqybj0 dF64rbRI3cuS+wCtvdVwH2k7yzMGbe2uCwmDcY1eR+6i+RLeMtU2RNI8QOe5sNP8YxU6qVy0bYJ CWYmdIi3xSWb77LuPH4RWYQnpyc6dFo2w4ScegjxEq4gxp/fH60z/JgDVArGKpS2fB6dDgPKNzT xo29RkwLI6mcG3SMj9oDiGRDHUCyO2rYEKHFLDkNOW47s6HO0NH7i2rd0vKVYJqQsAL/McG+tWd GGVu2tZRVamM16vcfQlu5+ORlRcL21XPEBBiSBQY8PdkDm7rNSpGdnnQHRhO5wwkaeJxME5alYk PH1ZJ/Gok7NwyXDjd2NkJ6lGinGsglhDthTh0aSWSHf7bXHKBp0OJDUaoTXjj2xm57MVaIpxElk uwdQeCZQ6jksXcSe6mpWPbJ5nuu7ASAAxE4Lb9gn5jutiYGVl+Nxde/U7aaEUlGHQyKrIYblGLZ ThfvyOrQf1CrR0YYFzQ== X-Proofpoint-ORIG-GUID: rZMxFtuZYqY4b89D8xWJW4kaRW8bLg_J X-Authority-Analysis: v=2.4 cv=Yr0/gYYX c=1 sm=1 tr=0 ts=6a01d32a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=W-43u8CF5Pkpiqpb4b0A:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_03,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110144 With the slice architecture, we need to flush the slice and unslice counters to perf RAM before reading counters. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 30df9bfa9ef8..a329d20033d7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2921,6 +2921,7 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs = { .progress = a8xx_progress, .sysprof_setup = a6xx_gmu_sysprof_setup, .perfcntr_configure = a6xx_perfcntr_configure, + .perfcntr_flush = a8xx_perfcntr_flush, }, .init = a6xx_gpu_init, .get_timestamp = a8xx_gmu_get_timestamp, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 99c3e55f5ca8..3491a24a9320 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -334,5 +334,6 @@ void a8xx_preempt_hw_init(struct msm_gpu *gpu); void a8xx_preempt_trigger(struct msm_gpu *gpu); void a8xx_preempt_irq(struct msm_gpu *gpu); bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring); +void a8xx_perfcntr_flush(struct msm_gpu *gpu); void a8xx_recover(struct msm_gpu *gpu); #endif /* __A6XX_GPU_H__ */ diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index 124d315b2469..6c040f718176 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -1345,3 +1345,23 @@ bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { return true; } + +void a8xx_perfcntr_flush(struct msm_gpu *gpu) +{ + u32 val; + + /* + * Flush delta counters (both perf counters and pipe stats) present in + * RBBM_S and RBBM_US to perf RAM logic to get the latest data. + */ + gpu_write(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + gpu_write(gpu, REG_A8XX_RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + + /* Ensure all writes are posted before polling status register */ + wmb(); + + if (gpu_poll_timeout(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_STATUS, val, + val & BIT(0), 100, 100 * 1000)) { + dev_err(&gpu->pdev->dev, "Perfcounter flush timed out: status=0x%08x\n", val); + } +} -- 2.54.0