From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6776F3D88F5 for ; Mon, 11 May 2026 13:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504464; cv=none; b=cQphjZnPUsAl7CUG4LvpFDr5Sg0S1w0AQZyizVmNQAujTCo4CgR1G0CrOqrwMoZLh/W8qnq3eeGeHmopJbqj0EKzFBxBHFBFVvvT5FDG84beabD02bfgSMN0Uh28d9PLY6eL4Z1SaI3osG+1txNNhM6rBpEG2RX84SdhX1rGvhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504464; c=relaxed/simple; bh=/NsgYCf/YJOjQfBrxIduQkHUSM4dKNrQiRj00JRK8V0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lT8lsvWf7X/vE4GMdxnio18qkoKQsRI5bmE/bAh54Zw6ZLXEGUPx9mK5VM29wzYC0IzmO3LEjti3ahbXu6AimAKUAEMR4TzcqMMm0t8qT3Lh48dMM5xu78eFNTIT+l2YpNkBCiM8lZJ942afu4TIN7NxxgNR1HK7YeYaeM0lePw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cruGJbn7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L+q4kjdt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cruGJbn7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L+q4kjdt" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B8Hx691850375 for ; Mon, 11 May 2026 13:01:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QpEOCCW2frO 5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=cruGJbn7sIUATh10M5jsgXz85VI ZFQeS/jgS81EAtMJOouCdBmq/AZU/j7r+Dc8Th34AE5K80trOIi02nno8L5DzvPZ iTE+e9u4KyiJHkeVQzIFY7bPVu5f07PwUJHUWwU2ruEiW/w/rNcGOFMqenoEvhDy /Bvr933ptoBRGor7izAH1WWWpxFsjltZ+jm8Q5g9N6p4ViG8ysCHw419acbnK39n xvHm8Bo8GjIDoyOrbgAa+cWXCb/NlZOR6Jvc0Tt/Jtf5ilBFTQ0qHlAu+A5LoF3+ v+x8IWKwAVNFvDXctuRJdtNi6EfTTeZDX/CFWfwKUVqZM1BkWH8PMFqordA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3bfvgyjt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 13:01:00 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3688be1cbcdso269413a91.3 for ; Mon, 11 May 2026 06:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778504460; x=1779109260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=L+q4kjdtLYq3JhsJMjWlC5NzM7w3dmIo5CBT3OTcGFF4tbGFszc4dj3whZYegEFNgR vy8q2lYIEUHa8W7W9ysPBMIIZvUOE2fHMz5LIion++a8N5aK/TeR9CgFfMkgmEvwwDt6 7GT/6YrSavEWfa0Ud1Zp+F9MIT7bt/k87Etl7qCbH+tX5cGHBdlaA2x1qSMf4WEQ5+SR KojYw16QGTp/xsIsrSNspGfVwxRRHsnyJlfwUUB/q5WHWXEp+AAFp+WmNI2bLmWo1/RI vOfc1aoUoXai1Qn+jUmqu0biU43qLJ6IgC74SxOASrqnA5eHhsjQkQDND3dstWw4eRQa vCrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778504460; x=1779109260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=fNJReG9JzhgC1aZzg1r+84iHhiOniDd3BI98eLjp568Qy/MRqg23T6cMk7IJsg0I8W dT1Y+rSbsA+DxxuN7tiWnEwLW3yrXf4YxqEbwNazj3tUgEbyD866w9k9GPVhWC0DCdwy ssxWq9m+Zkqv9GTdm45lvabF3NhBFbF8Ykv59eGOiKklZLSnF9WrrK3QTKz1jZ9g65yC 24iEjyRwTE51gHqbAuIBOdyTzPQv1VCY5eb6exnEOjxfmc7MugflseCHtLFfOMrCry2l 1U1/zUZiYa/shDJgOdzh/DC9DzsaFEAwo91kuYZz/Vu3SmmQ3Y5yx/f8VLE03S9Mt0hO dGKA== X-Forwarded-Encrypted: i=1; AFNElJ8aQrudcxanBLy3/ZOJg2GLDZSKY4hfBLHL+xSVYR+xOYRdIuQd03EnOvktWKJ2ixVbJ7wGLYRzpR9fw9M=@vger.kernel.org X-Gm-Message-State: AOJu0YwkUMiU2excC+BMGGCyxPRbz5zQo3F8Z16nj0afVQJPJalEVVng XTynC/qcgAlO98IDneDw8FByM/vbmnXcDp0o/kwsS6FxbyjkbKmvVFGM/Cl/GZT6zZVDE8X1zLS k3YfmGXAJterq6PA4ittO9ulOpAO9ZGL8mrdYz72hHdbwmpruZHWgm7FVbXCA7VMfukU= X-Gm-Gg: Acq92OH87QMRx5pJnOwUDkfs065jl+0RypUCVxg0FIZluRSUc8VJfR2Bd7OYCXOMUnx f+9dIIcEdNQFIJUO0sC1l0ytbFJzNlTTfPjRNvk74rSU0FE5zBVd7LFdcW6YQFM1VCNOfVuETBw 3KKabRQK8ZfWviFTzygT9/XalkVK110wvh3GxHQom+/mFW561dD1JDgo9TjLxLupSQLwM7dNwNP g0zbitM8kEbkV4HFRO9cndK98JbTD+dQaYheOa3JmebK3N0dbyifQnhHledaJlAXGf9CfyvguWL dVzFW5/fR8Z+X/qDTxGHkUbOdT9aPSqX4daP84MqwVm6uoWtwD8bxDMn80YPzn23nc6EzssVpEa hxnu8FJpGQKvknwJgJxVnJ+EfAuloq7EV X-Received: by 2002:a17:90b:6c6:b0:35f:c729:de9f with SMTP id 98e67ed59e1d1-3664cd49ad7mr13656728a91.27.1778504459898; Mon, 11 May 2026 06:00:59 -0700 (PDT) X-Received: by 2002:a17:90b:6c6:b0:35f:c729:de9f with SMTP id 98e67ed59e1d1-3664cd49ad7mr13656661a91.27.1778504459326; Mon, 11 May 2026 06:00:59 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d629f40bsm7782246a91.7.2026.05.11.06.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 06:00:58 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Mon, 11 May 2026 05:59:15 -0700 Message-ID: <20260511130017.96867-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> References: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Fa4HAp+6 c=1 sm=1 tr=0 ts=6a01d30c cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: tQtq2lRSC1JTRqGGz74_YY2DwZAc6RqW X-Proofpoint-ORIG-GUID: tQtq2lRSC1JTRqGGz74_YY2DwZAc6RqW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDE0NCBTYWx0ZWRfX5mwy9W55Aazd 98K3FO5kal4SdXlymttiA9k8lco+R8H4+XQYsGnablm2o1EtYRb5wKa4x2rYWDEsnpPyhR1vtB1 XaaUjtnYfsQB9AlVhVTy66/YxubOcua8N2B6p2Tnw/lvcv+dPIiuLOQty9FBlYdnrmXeAlw6D4d W04vm02WBNJUiQmZEnqzyVhUcztFbJFLoDLO3DW+/r2a0jSscA+f15KJukRw1S6ai7HqW6a03/x qtsDduZ5YcVQELrQQDzalu0S7rMVxuI7YHe3gLKXjhItNaTdVWyETgfRHay01pcmmteyeehUXZH ygckcBG78ma+4JRG8J6VC+lRLpiy/VIeYSortHoAouEh1xJpP4jJwE3Um5H512rZbYxdvQux5fx DoT0jpFJqRPhx9y9Fi12X+TOfkaO8X7swYDVIZjHz/WNQI1vJ/i8h4CzIdNkQIonug6uo84HepE yHcEttaiT9AFMVzSH5w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_03,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110144 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0