From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA0D3FCB33 for ; Mon, 11 May 2026 14:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778509132; cv=none; b=NgYO+wb511D/ux4g2dq3QAYn3gp9R9+WkLsyLeLZZW298F9+fN/DPFB94cnvBe/phngXwX0hVhHdQRmy1ymc9P9MelUsbPBO2/SbT+Wnr+HY+lktqmVZggc6uDG6N27jvpBEgBnlblZfMjXG5uVwG5/SwfAg1iwdSqSOFMVZZlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778509132; c=relaxed/simple; bh=35fAx2DRHYaIyZAtRTiPzerFcANm+T3Dutf9bONwTyY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qs3JeICN7x3o4WmpHurLm4RxT+fZTz9rrFHKGSg7FPxn0oTwVYUZoLTuCQfbNJ2Hw+qWsJo/OVm4ZH5J8ce8qyDqsszS4rbSatn6urxN6q7X5yQGJovwocScRJagRBl3a0Y/yIOjEnp4GxpqeRAIH6Zyz7SyfEvjbFIujc3hjXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=LsguMg4J; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LsguMg4J" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-8b4298d271fso76269806d6.3 for ; Mon, 11 May 2026 07:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1778509130; x=1779113930; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nhPDshriKOHBVRsVBlLjs1r/ABM7AzaFK2EEc21Hio4=; b=LsguMg4JKtYiSbMZXxn8mIYVjA8cGL1sNXT28ou+6Y0UR5jRxrUJdWy9VquVSKeY/3 kFoEnxPgc3X20Ew2+DKMPE/sX+ksNThVm4W2oawwiluul2tvmesgwhWEe+jwKMou0kVk LjW385RhwcxtWI1v9Wx0wqfkQ4irSCkoXiznN9o0YRVgbuOj85e58TgJrrjaBIGy3Fu9 6dV92cKNbfFQm0YiqNSFvSVb37PfmXzpFr6laVn3zba11olnTgX1tSRonPoNUK/R5log C+fGnO7kQsiTLBzt6c7lLpJvG1+jBSFU3nQtgv1YGbxwXMTAAO4SiNJFVg8FabQFoNJ5 npDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778509130; x=1779113930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhPDshriKOHBVRsVBlLjs1r/ABM7AzaFK2EEc21Hio4=; b=Drma9DjlqLNN0qcpEtAzgRngMPYq7XnHGAZfM3avgCRLVtzqfVBtxS9gsY2fFD7JBC 59CytXTUVGP1El1gQzIv3GNVwkIXsXh0L7tDM16ntFD/7+81s+esPHKuwkvD3yy7+ejw Al4GcvKTvNAQD/nV85TlbawvCTd0I1soxmPbdekwMxpwbBAiLS/6kZ5wlbpBPxW2QDMB +xwZzp10pU5jXZJ+BmrlfcENu5uYEBXvvU3qmI7KeML6SgdxCnKdClw7fGmjYIgNe2gQ e1wVpeRTiNeVcDpMI9UxZiv7xTIe/KsS5IWBBC7k6nr3inuEKSluFz1cQjr5S+H9JAV/ sYCg== X-Forwarded-Encrypted: i=1; AFNElJ8q1Oi92FHhust6pEJzUKLnSvH0yJIMseOmS3eUuRhga81uONbUIsqFgcfwWhWHYM1XswWx1ebW5N+spic=@vger.kernel.org X-Gm-Message-State: AOJu0YwPRqG55Ehr1zWeCcsaf9tN1pKoDtb3HGvdR72q1b6r1wFqmcVs /7BfFNsNXoZHHOtgUG2yfftj6KQRBPk896gdOYXQM1GdsRCEVUnVkRg3UoBwPESW7Kc= X-Gm-Gg: Acq92OEJv0BBZCDNYMim/d1aHOEWsAZ25JO+IwbKytRCLGEZbZFJElnuFgjvrbOCnsT CZpWqGmILu9pT0lAC8sdqq9QlQwDp5REWXpHUq7/AHIwKoCJq48kKMh3O/kv43ywEjg/wFYMxQi GSehFktWEk848y4pCuTRK5BnNzkxYX3fOisJlSgXHCvMEaFvDKiKwj/SCkqDBvc+wFkzVecaanb VyVevl8ctYOy96cED5J+c/lJmWirZfrnQVzPBlIxMJZTLRC8awCEMBqwMs4i1MoCVu7D2Xfz0dK 2HrFd1G2wegjztVeeA1FOM+BsRJzjfNk9lQjNXJUg+FXOOZJFQGUrLlZjurMAfbsxWkiu+mv7pS aXvkGPYiFJD2KvlQKVRrqTjpWEt/LyHLUL6NrDc3DyIB2mWMgmeUb4tmXsXQ8u6q/AiPbhkVisK slHtbuOuyxgHCgFuPI+gv4Lq2QwVRIQJtJeNQHWaa40Gi2bcpEEUAIvFQ6gUqujYQ26g/d+GKv3 Wy3BlcjV6s4sMH/mvvH9X4LTaM= X-Received: by 2002:a05:6214:4982:b0:8c0:1d4:4171 with SMTP id 6a1803df08f44-8c001d4430cmr177173846d6.19.1778509130231; Mon, 11 May 2026 07:18:50 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8bf3a71be9csm97495666d6.17.2026.05.11.07.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 07:18:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wMRT7-00000004oCe-06zM; Mon, 11 May 2026 11:18:49 -0300 Date: Mon, 11 May 2026 11:18:49 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 06/25] iommu/io-pgtable-arm: Rework to use the iommu-pages API Message-ID: <20260511141849.GO9285@ziepe.ca> References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-7-smostafa@google.com> <20260501122424.GA6912@ziepe.ca> <20260509232155.GH9285@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 11, 2026 at 11:16:47AM +0000, Mostafa Saleh wrote: > > IDK, why? virt_to_phys() is part of the iommu-pages API, I'd just > > leave it.. If you want to narrow it then #define it for pkvm when > > compiling this file.. > > It is not going to be part of the iommu-pages API, I meant in > io-pgtable-arm, we will use something arm_lpae_virt_to_phys()... > which is then implemented differently for pkvm. Again why? I think the main goal should be to not mess up the normal code. #define virt_to_phys pkvm_virt_to_phys Does that, we should be leaning into this pattern I think, not adding unnecessary churn... If anything is needed then it should be an iommu_pages function to wrapper virt_to_phys() for use by iommu_pages uses but I'd rather not.. Jason