From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50AA93FE354 for ; Mon, 11 May 2026 14:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778509554; cv=none; b=Kn2XDBbV5/8sfcR/EZUu7ntwDsGCgMQu9a7X3DF4MQ3srnIVeUuyIv9UD+dv0wvMRTEf62Kf0xsngW5QPoNQvoS5MRrCmzIQ9XgH8s8iKAxPxygOhIWk9YOakG+S1pYaXbPuaM2+VkLXHKJ36qnx/iGnUA6GPLTUUZIVjdN9rCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778509554; c=relaxed/simple; bh=QaRL90yyKRYJf2/QGkjbRLAMcFvanLvA5zXjYzi0ksk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WA0oTSiHWUfWcfTNIm4rBrkfVX/aGGhij8xMNvv9XLZn6PhiiK3W5M9BcVCRwjxY/3sErXCyRbg54VgdUK+T8G7XBRrxiBEMmFz6afUdVq5Rt8mjixBqfl5RYkOqcWybkSH8sBTMBo2OzeMltokwotlFyU1gcGkZ9hLchsAvw3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=X1rrK4TY; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="X1rrK4TY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778509553; x=1810045553; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QaRL90yyKRYJf2/QGkjbRLAMcFvanLvA5zXjYzi0ksk=; b=X1rrK4TYOXpevjCCMOm/Vizv1HVkr7vbJCnzgjNzpwCumytnTTkpNlFv WgE1+3FRc0ZMhcZlXVixg5hG63nz85Cdtu0DtAbRnIRwdjmlXc+GsVI4b 9TduXeVzGh3AjPP6wID+0NGOB1P9Wn2z+P6kW7vsznqRlQwI1FP0sagne Z9oEKUrbNyb5G6AQpl34+3pFCwnMFwSkSZo2F4IPXglqdA/l1aKMWglWK jChxTXbWMdMNWnacjbD7bJsxfwiRa90SYw9XRMf5vSZ6l7oFnAAmfFJq1 9PKIcJyrvIxX2nWTmf0/jr2j+S+NhdQMXvc6lblSeEtTNSD3tXMSfPPlU Q==; X-CSE-ConnectionGUID: 6YURYL1wTEWaonnX+aahRg== X-CSE-MsgGUID: 2R3UpPHPRLS0x31D84MHNA== X-IronPort-AV: E=McAfee;i="6800,10657,11783"; a="96961225" X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="96961225" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 07:25:53 -0700 X-CSE-ConnectionGUID: g+NyUk49SsiDTBzzCo+GYA== X-CSE-MsgGUID: 7XtGAQvRT7ah+wP4EQ9HUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="234807071" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 07:25:50 -0700 From: Jonathan Cavitt To: dri-devel@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, linux-kernel@vger.kernel.org Subject: [PATCH] drm/gem: Remove unneeded ret check in change handle ioctl Date: Mon, 11 May 2026 22:25:40 +0800 Message-ID: <20260511142540.2989187-1-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the "if (ret < 0)" branch after idr_replace in drm_gem_change_handle_ioctl. It is unused, as in the only place we modify the return value between there and the previous return value check, we also immediately jump to out_unlock, bypassing the check entirely. Issue caught by static analysis. Signed-off-by: Jonathan Cavitt Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter --- drivers/gpu/drm/drm_gem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index abc8e41d6652..110bc5a58862 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -1067,9 +1067,6 @@ int drm_gem_change_handle_ioctl(struct drm_device *dev, void *data, spin_unlock(&file_priv->table_lock); - if (ret < 0) - goto out_unlock; - if (obj->dma_buf) { ret = drm_prime_add_buf_handle(&file_priv->prime, obj->dma_buf, handle); -- 2.53.0