From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C003FF88A for ; Mon, 11 May 2026 15:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778512353; cv=none; b=scLcYZiESOrx95Zg7AYlJMdOG9vNnckGqJJcyWLUYNpLd6lkC1989OLUqoRWw7H9ndclwuy4gv+bMRqq5bNpnzxEdLFEPjurRpgPgzlvm0pIWCaiTRFFbwNNHvUysVPcMEQEOjytmkFrUC3gksv3/1kjkp6WuWpAtrSaY1BH1DU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778512353; c=relaxed/simple; bh=iQC233ObFQR/90YxKD9y724eQmyLFjIZfp3RWHo/ye8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EUw0U0/6Af/ozxqE8Vo9FVKCv0sHYRgpQVPFzsKiQlhHvuMZbKuuISyVCF9v/viq8q54YCQM5n7qT6hOQMkOOgaIuFWfcwfHj/Fe4AwckqXd5JzHk7v6GWQZibb1AXULDyB2lS8a0ImC6C2sYZoSqjefpCokZwOblHr+BHryOlE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ix82eUaJ; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ix82eUaJ" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3665640a55aso112048a91.0 for ; Mon, 11 May 2026 08:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778512352; x=1779117152; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vcvoM5yhRfse1l84YXFUTPi+JFMcUZ44W2hrGEOy/hI=; b=Ix82eUaJ95i9xKJZx8XI2V56GM6sT90rkb/40AuLkJCfWFgGpovO2jBBYji2BFfvNq CF+s8za4p1r7iyRJOJ8iA1ZscjlECWL7UGsg9d0+MfFLBpRGX4m6fWcGWca1+aS/7n2O 57wttxT8Fe6nJKrX5rYsykmzJmfj+ONluqyJ+xKgLXT8Gjbqu2+eyDekfIobShrFXa/E bsIucMPxrZ4dLINlL6Zj5COuj91mhVNCqjccmjymv0qkreqFMXXzyKxFfkvSIwFce23v arih9bwqvfup9RcHtHO1rwNvuLpmNYbN1rOJLUdnueNiQ+QUyKGTogukPpkE+M9obE4Q tnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778512352; x=1779117152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vcvoM5yhRfse1l84YXFUTPi+JFMcUZ44W2hrGEOy/hI=; b=Pr6nutnC+zH/9AGkjFeuRauN4QkA/YBHXpxaW+y8WRa9kSLxOTiGgOkg3MYeGixZr3 4LCyypMVVi6WSjblKW/yI7Y3Zzhksc6bLq+y5bXLqgAfFuDXb8OhgvVqi2Db6VW51dRT +o2aVvFXVB5vhsU12Ax/pdCpvJFIC9i9+x5jhytAo2b/A5KOWlNz7S6Ta8bmgTy7Erdu QLcznab3+yALbG/qqcRRNkzsyiu/E2rV6Jt4FjIbwNXnEMPaT21zmb4VwY8q72WfKA8N w6z++JU5mS9vA7znXZ97zKRIoavEOyXnj71XlytGL7RQRx1aFVbrf2pHhNE2xP/L4nD3 XApA== X-Forwarded-Encrypted: i=1; AFNElJ+m7fy+HhdsvoQe8vHne54HQfIV6d+jwplg6/pJ9MCFFrTHFYKqoDTzaoKxxQ9JEcT0Ut1GXdz76kusQ7w=@vger.kernel.org X-Gm-Message-State: AOJu0YyUFNq06lY8dd1uWuOwlwCCagf07TXMvcdAXgPWLsBlr9eMeGHI d3IdH82/spo6+4LJD88GFkAtBD2qy2tCd3psChG4czs9D41OyWF/itoE X-Gm-Gg: Acq92OGvS+HIjZ2WutJOJ2gh1X07XicgfT4TRDR8yULV3lMNEp1rT9QEAX78nOUhngD ATBqU7S35AVEnp6BLbW12ohQRkuMEYEvtFkyRMGJATdlgH+YqKtfUq564ZN/uGQHoGUw/JCK/SF alAVphSx85VkLEIuQAv7KLiOC6MFBCqTr31yVm48ZjUR+naFVPhBu/TW+6fEIzdYH8jCFbNidvO s6f2InP+2PzsbZRTNsW5u799vDcap0vjG5/fqBVEeOCg8IzzS/pjlsfKeU8FB1vjv9Mky7vvw4q c7WVtYA+JF3PTBfJv7SR/VirnaTIUHIwAiOFPVscDlXdyjBcZXUrWTUtUlYsi+J7c/kueOhy3sJ zzoIGTx7f39qnoOCA7hf9J+wxuV0NIy/vrFExzdMrat5ouhaWx2ZM+1nhoS8eDgIyd6iVbVapp1 RerQ7zGZ5PgZXu4cdYOPCVvvCaiuth05/zn4WgA0ommkdb2twp1xSqtRahHLZLLQnmaLAv3b40s onGFncUQF5EahI9ID1Ga8FGms0d X-Received: by 2002:a17:90b:5808:b0:35f:c796:ca60 with SMTP id 98e67ed59e1d1-365acb8a956mr14322757a91.7.1778512351991; Mon, 11 May 2026 08:12:31 -0700 (PDT) Received: from fedora ([2401:4900:bffc:e9a7:49ca:5a41:a2bb:6936]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d683fa7asm9932363a91.10.2026.05.11.08.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 08:12:31 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ayush Mukkanwar Subject: [PATCH v7 2/3] staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err Date: Mon, 11 May 2026 20:39:30 +0530 Message-ID: <20260511150931.93382-3-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260511150931.93382-1-ayushmukkanwar@gmail.com> References: <20260511150931.93382-1-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace pr_err() and pr_info() calls in cvm_oct_probe() with dev_err(), netdev_err(), and netdev_info() to include device information in log messages. Use dev_err() where no net_device is available (allocation failures), and netdev_err()/netdev_info() where a net_device exists. Signed-off-by: Ayush Mukkanwar --- drivers/staging/octeon/ethernet.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 31464ed63b58..eaa4f04093b8 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -685,7 +685,7 @@ static int cvm_oct_probe(struct platform_device *pdev) pip = pdev->dev.of_node; if (!pip) { - pr_err("Error: No 'pip' in /aliases\n"); + dev_err(&pdev->dev, "No 'pip' in /aliases\n"); return -EINVAL; } @@ -783,16 +783,16 @@ static int cvm_oct_probe(struct platform_device *pdev) dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead; if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for POW\n"); + netdev_err(dev, "Failed to register ethernet device for POW\n"); free_netdev(dev); } else { cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev; - pr_info("%s: POW send group %d, receive group %d\n", - dev->name, pow_send_group, - pow_receive_group); + netdev_info(dev, "POW send group %d, receive group %d\n", + pow_send_group, + pow_receive_group); } } else { - pr_err("Failed to allocate ethernet device for POW\n"); + dev_err(&pdev->dev, "Failed to allocate ethernet device for POW\n"); } } @@ -812,8 +812,8 @@ static int cvm_oct_probe(struct platform_device *pdev) struct net_device *dev = alloc_etherdev(sizeof(struct octeon_ethernet)); if (!dev) { - pr_err("Failed to allocate ethernet device for port %d\n", - port); + dev_err(&pdev->dev, "Failed to allocate ethernet device for port %d\n", + port); continue; } @@ -897,8 +897,8 @@ static int cvm_oct_probe(struct platform_device *pdev) if (!dev->netdev_ops) { free_netdev(dev); } else if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for interface %d, port %d\n", - interface, priv->port); + netdev_err(dev, "Failed to register ethernet device for interface %d, port %d\n", + interface, priv->port); free_netdev(dev); } else { cvm_oct_device[priv->port] = dev; -- 2.53.0