From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Stepan Ionichev <sozdayvek@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7793: replace usleep_range() with fsleep()
Date: Mon, 11 May 2026 15:57:51 +0100 [thread overview]
Message-ID: <20260511155751.38d8f66b@jic23-huawei> (raw)
In-Reply-To: <agHX4-C5xlBqTK-y@ashevche-desk.local>
On Mon, 11 May 2026 16:21:39 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, May 11, 2026 at 10:30:43AM +0500, Stepan Ionichev wrote:
> > The AD7792/AD7793 datasheet (Rev. B, page 25, RESET section)
> > says: "When a reset is initiated, the user must allow a period
> > of 500 us before accessing any of the on-chip registers."
> >
> > Use fsleep(500) instead of usleep_range(500, 2000). The 500 us
> > minimum stays the same; fsleep() picks the upper slack itself
> > (about +25% on a default config -- narrower than the original
> > 2000 us).
>
> > Add a code comment with the datasheet reference so the "why"
> > of the wait is visible at the call site.
>
> Unneeded detail in the commit message (it more appropriate
> to have this in the comment block, below '---' line). Up to
> Jonathan what to do with it.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
I left the comment on the comment. Not needed perhaps but not
harmful either.
next prev parent reply other threads:[~2026-05-11 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 5:30 [PATCH] iio: adc: ad7793: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-11 13:21 ` Andy Shevchenko
2026-05-11 14:57 ` Jonathan Cameron [this message]
2026-05-11 13:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511155751.38d8f66b@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox