From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACD43D667D;
	Mon, 11 May 2026 16:28:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778516895; cv=none; b=JmODmnIiiHiDUOQUwa3ZuJUonB8wEuDjLcHFHx9w/uXjX/mjmHCXJtnhICC0OE1fQ1IaW4GizuZRYrsWprnXSWCfQyhvFUED6OCL7Yc1+uFNUGDZDhEpLf1tWhuv12zEa2afKkAQD/NoVQ+0zTTiElJzGVKj9sYrIfaxeVIsHPs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778516895; c=relaxed/simple;
	bh=NniAWlMwg0MnR6VwlJuOsYihhqkKD5tw4Vf1zwmvhOQ=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=czs1WgdaeAvY5JUh5G3KTi1SZyytHOEL1hCzx7kAD2zVsYjLjoj+J7ZXX+cqQ+BMKE8Z+UxO3iOBPjY1oR6Q4gERLiMhBOuTRm1BMTkwP5KVMEvsQRzNN7M6S74ICh8l7HhzrglGEpZxwXt67czSYypWEMie9LqStiTQXuRkhpo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FdErAr2g; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FdErAr2g"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FA99C2BCB0;
	Mon, 11 May 2026 16:28:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778516894;
	bh=NniAWlMwg0MnR6VwlJuOsYihhqkKD5tw4Vf1zwmvhOQ=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=FdErAr2g44EhXnJtKEi7rHDBqfcWm0A5OWtbXe1WEibnye4I94d9KVuTYU34JKGWy
	 IGXB3TEIxXv8Sv1tx7NbvltWUQHb43Orf8jMN7lU2Tw8JGmXDOn8AKPo8289yRITae
	 tChraIzauoxsLjkZofATYli3oPIj6hfDzAI1q4Ld6Mq9PHFQar8Vh8dmBTEtsZ4QOm
	 OQdV+DuR1bnzRA/v/6W1PUu9joKz3BbYGWlniw4DeKbNNFg01sWcukZ3q6BRBUZkBb
	 pwq+mQ+q/O9aEZOgBWXX2r1hEoP5UOPQNA0N8Hg059Gb4xPMiAm/9XxHS2etI8f43O
	 GB6wxhZXaRkfg==
Date: Mon, 11 May 2026 17:28:09 +0100
From: Simon Horman <horms@kernel.org>
To: KhaiWenTan <khai.wen.tan@linux.intel.com>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,
	hong.aun.looi@intel.com, hector.blanco.alcaine@intel.com,
	khai.wen.tan@intel.com,
	Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
Subject: Re: [PATCH iwl-next v5 0/4] igc: add support for forcing link speed
 without autonegotiation
Message-ID: <20260511162809.GF27589@horms.kernel.org>
References: <20260507214706.309984-1-khai.wen.tan@linux.intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260507214706.309984-1-khai.wen.tan@linux.intel.com>

On Fri, May 08, 2026 at 05:47:02AM +0800, KhaiWenTan wrote:
> From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
> 
> This series adds support for forcing 10/100 Mb/s link speed via ethtool
> when autonegotiation is disabled on the igc driver.
> 
> Changes in v5:
> - add removal justification to include copper context in commit
>   description for igc: remove unused autoneg_failed field (Paul)
> - check that cmd->base.duplex is either DUPLEX_HALF or DUPLEX_FULL
>   in igc_ethtool_set_link_ksettings() (Simon)
> - dynamically override hw->fc.current_mode to igc_fc_none during
>   link configuration instead of mutating requested_mode (Simon)
> 
> Changes in v4:
> - Validate that autoneg is AUTONEG_ENABLE or AUTONEG_DISABLE early
>   in igc_ethtool_set_link_ksettings() to avoid passing unexpected
>   values to igc_handle_autoneg_disabled(). (Simon Horman)
> 
> Changes in v3:
> - Modify condition from "if (duplex == DUPLEX_HALF)" to
>   "if (duplex != DUPLEX_FULL)". (Simon Horman)
> 
> Changes in v2:
> - When forcing half-duplex, set hw->fc.requested_mode = igc_fc_none,
>   since half-duplex cannot support flow control per IEEE 802.3.
>   (Simon Horman)
> - Split the original single patch into three patches for clarity:
>   patches 1 and 2 are preparatory cleanups; patch 3 carries the
>   functional change.

Thanks for your persistence.

For the series:

Reviewed-by: Simon Horman <horms@kernel.org>