From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E0F426699 for ; Mon, 11 May 2026 17:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518924; cv=none; b=EhSbc35Bcu/4/e/hBp9MZ9jbjwd2NpqEKluor1mrgEouOPb09zbCPLHOKIDr/Y0n0zcCiDk8Xj9UaXSaPCElak51aQfzVJ3VEvXJEDhVKkn/GV8H0Jhn99r2wNc8KimQcJj0/3ObD3MtvsSglhaR0Ob4KLPvQEjqT8iLoq7r3OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518924; c=relaxed/simple; bh=VOc+Wayii74xrxQlC1QoXgEhDx6pTCCZ0YyuwFTjpqI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gn5AxRoNpOb/8Nl/VjG03utqAGZaa0BuyNwc07eXsAQN5zbWp+UchgjYJi4M7fryfa8Pu4eoQ+SM6CVAzRpKxiiDGrSF6CiqHgmJz1hUtk9vpU9FfT5vYMnLuYoWXvGj/bfndUroKCydToaPnOg0LGB475JzfnSNtzEQ2I9kVX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LS7DY41r; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LS7DY41r" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8353fd1cb5fso2169247b3a.0 for ; Mon, 11 May 2026 10:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778518923; x=1779123723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oB4TtcqxvRLjMRr1fJG7J4uzFOlt2Uo+LQk87OI5Vsc=; b=LS7DY41rmFvuyhzgONoohJccSFtSeawG1AuLesnDwCxxJ6GtNB9s/9TppmQWEEKbDX sATmr2WCKGklmuNHyp7Ot8ncHh725I0Smgqwooq8Q1EfGarD+akXhiKmlfIBsOjYmnKS DYCs5ogizGHSA84RNCpMCXM/vU9yGNCHPiR13qlJ4g7HRcb7th7bHcEtub72fMA7LGu0 MlMxk4iwT4X9mSgpMqtO5doyO3pXFf7R2r7AB4H7FwB9VOjqRTwKmFQluXU9QWgEFLUo YyhS9Uvc57ArOaI1pX/2wmlIZVmDiGY3kZKEEzRO1Uf4e9IuDbvUJqsCoi/YEBcQWfMi y/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778518923; x=1779123723; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oB4TtcqxvRLjMRr1fJG7J4uzFOlt2Uo+LQk87OI5Vsc=; b=UTU4tf2PvsiBRw+Kjb21knLtZ8QEnpkWJTtdXgBR5jlvE2/GJYQheqOb1M4RE0y0jz i+IDqgSfCCGRpJo/iBLRCJ4qM7P5CQkReb9utUpkNK6p+HYza1aaPMRcNHN9FregoWzX 3GssyKSAWS6JTThvc70BDm38WQEUu94T447donm7flHjMZp7C6iTaQjmFAyW7JZGRWqJ q95Q5f7S+QM54I9dMQSnRansqLO4VTDnlKUGoNXPdlRJys2EIphfCCvyimFHP1YKKCye mblNmfE3nNR0VP5/4K4NmXvjgcZLuXXDJy8NRgRzCgc3DxG6/Vkg7MbsVwCa3nPqRfcQ +TZg== X-Forwarded-Encrypted: i=1; AFNElJ9BUOvW89PsYv7TT19qDGBFDQtMSalw1rcQnsn+6uXnNWM06EKtycaD00sz98HljSBwTeYZg9nPrKUEXfw=@vger.kernel.org X-Gm-Message-State: AOJu0YyqyW9F61O+yleQ1kuRPjZIyPHSMwms9UeaN4/+0C4577zMOKC5 9pDajWhq8SlE+GD/m1TJ0Ps9p5yiHoQ1wh+EiOO+7R+Y9KPFha2qnYQ= X-Gm-Gg: Acq92OEbc+qToUEzHymyyKcKZFaPG4YCcwKiLB3VvyrbjGxkYdmSpWIsL19nT0/CabI oWZgDZvuCD/RBModN94boq2104PDZTHITnlAj7PSSJNejSmqbpfhXzjvv0Ih5kNsAJWJ5UpP7UZ 1/q9n8i/EsxWTmP6Q2N2IxnJPwaxFgSsHvrpwyWGryZv05AUHfZGeAC1DDWv9iLLU6kKDUFYs1E FahLBg3U2p2XTrOvXQMa9up558tGScsQRnyTAFbvQwFvKWkv6Rt2BbtyPb4a7GFcAZT48HW9Tai ZghnAxorgVY2eJ/TzznhmCQCMzaW81EBXPn5YjTSozc+EWkynp2V9du6fvV3tKofb0U+jMhMsDE 8rrsxU48sXeAye+8BQy+YOF8cC3K0wCoOI2P7MbGRRmVsHFrIkJGoMONqlIoHKC0Uqw1/+Mle1r +4N7ykAOl2higotGeATYQthkNAPnfdvpwKaOMYX9I2cLEAv9my86I8vhzN9aC9VumAPY9lCCY= X-Received: by 2002:a05:6a00:2394:b0:837:8a0c:8f70 with SMTP id d2e1a72fcca58-83ee83ec7cdmr272378b3a.28.1778518922808; Mon, 11 May 2026 10:02:02 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbf7d2sm28032387b3a.49.2026.05.11.10.01.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 11 May 2026 10:02:02 -0700 (PDT) From: Myeonghun Pak To: dri-devel@lists.freedesktop.org Cc: Myeonghun Pak , Sui Jingfeng , Jianmin Lv , Qianhai Wu , Huacai Chen , Mingcong Bai , Xi Ruoyao , Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Subject: [PATCH] drm/loongson: clean up KMS polling on probe failure Date: Tue, 12 May 2026 02:01:40 +0900 Message-ID: <20260511170152.16957-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit lsdc_pci_probe() initializes KMS polling before setting up vblank support, requesting the IRQ and registering the DRM device. If any of those later steps fails, probe returns without finalizing polling. The remove path has the same lifetime gap when tearing down a successfully registered device. Route those probe failures through a poll cleanup label. Also finalize polling from remove before unregistering the DRM device. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/loongson/lsdc_drv.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c index abf5bf68ee..3db1f8690a 100644 --- a/drivers/gpu/drm/loongson/lsdc_drv.c +++ b/drivers/gpu/drm/loongson/lsdc_drv.c @@ -297,7 +297,7 @@ static int lsdc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (loongson_vblank) { ret = drm_vblank_init(ddev, descp->num_of_crtc); if (ret) - return ret; + goto err_poll_fini; ret = devm_request_irq(&pdev->dev, pdev->irq, descp->funcs->irq_handler, @@ -305,7 +305,7 @@ static int lsdc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) dev_name(&pdev->dev), ddev); if (ret) { drm_err(ddev, "Failed to register interrupt: %d\n", ret); - return ret; + goto err_poll_fini; } drm_info(ddev, "registered irq: %u\n", pdev->irq); @@ -313,17 +313,22 @@ static int lsdc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ret = drm_dev_register(ddev, 0); if (ret) - return ret; + goto err_poll_fini; drm_client_setup(ddev, NULL); return 0; + +err_poll_fini: + drm_kms_helper_poll_fini(ddev); + return ret; } static void lsdc_pci_remove(struct pci_dev *pdev) { struct drm_device *ddev = pci_get_drvdata(pdev); + drm_kms_helper_poll_fini(ddev); drm_dev_unregister(ddev); drm_atomic_helper_shutdown(ddev); } -- 2.47.1