The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Hungyu Lin <dennylin0707@gmail.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	lars@metafoo.de, michael.hennerich@analog.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Date: Mon, 11 May 2026 17:55:09 +0100	[thread overview]
Message-ID: <20260511175509.4f76da87@jic23-huawei> (raw)
In-Reply-To: <20260509-backdrop-contented-b81438c518f4@spud>

On Sat, 9 May 2026 17:00:35 +0100
Conor Dooley <conor@kernel.org> wrote:

> Jonathan,
> 
> What's the story with adding bindings for things that are in staging?

In the past we've only done it as part of the final series to move
them out of staging.  Whilst the driver is in staging we've always
treated them as somewhat unstable at best.

Of course if we know another OS is using them the binding might
need to be there anyway.  Never actually had that happen however!

DDS chips are normally big and complex beasts. I'd love someone to take
on getting these drivers out of staging but it's probably not a small job.
We do have one modern DDS driver under review at the moment and that
is at least forcing us to figure out the userspace ABI - so maybe it'll
get easier when that lands.

Jonathan

> 
> Cheers,
> Conor.
> 
> On Fri, May 08, 2026 at 11:37:30PM +0000, Hungyu Lin wrote:
> > Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
> > 
> > These devices are SPI-controlled direct digital synthesizers
> > requiring AVDD, DVDD supplies and an external master clock.
> > 
> > Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> > ---
> >  .../bindings/iio/dds/adi,ad9832.yaml          | 66 +++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > new file mode 100644
> > index 000000000000..7e2eece086d0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD9832 / AD9835 DDS
> > +
> > +maintainers:
> > +  - Hungyu Lin <dennylin0707@gmail.com>
> > +
> > +description: |
> > +  Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
> > +  synthesizers (DDS) capable of generating programmable frequency and
> > +  phase output signals using an external master clock.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,ad9832
> > +      - adi,ad9835
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 20000000
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: mclk
> > +
> > +  avdd-supply:
> > +    description: Analog power supply
> > +
> > +  dvdd-supply:
> > +    description: Digital power supply
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - avdd-supply
> > +  - dvdd-supply
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ad9832@0 {
> > +            compatible = "adi,ad9832";
> > +            reg = <0>;
> > +            spi-max-frequency = <20000000>;
> > +            clocks = <&mclk>;
> > +            clock-names = "mclk";
> > +            avdd-supply = <&vdd_3v3>;
> > +            dvdd-supply = <&vdd_3v3>;
> > +        };
> > +    };
> > -- 
> > 2.34.1
> >   


      parent reply	other threads:[~2026-05-11 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 23:37 [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
2026-05-09 16:00 ` Conor Dooley
2026-05-11 16:23   ` Conor Dooley
2026-05-11 16:55   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511175509.4f76da87@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=dennylin0707@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox