From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Maxwell Doose" <m32285159@gmail.com>
Subject: Re: [PATCH v2] iio: adc: viperboard: Fix error handling in vprbrd_iio_read_raw
Date: Mon, 11 May 2026 18:09:03 +0100 [thread overview]
Message-ID: <20260511180858.12cad4f2@jic23-huawei> (raw)
In-Reply-To: <af7oqt-TDLympDIj@ashevche-desk.local>
On Sat, 9 May 2026 10:56:26 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, May 07, 2026 at 08:07:51PM +0100, Salah Triki wrote:
> > The driver proceeds to the reception phase even if the preceding
> > transmission fails.
> >
> > This uses a goto error label for an early bail out and ensures the mutex is
> > properly unlocked in case of failure.
>
> ...
>
> > if (ret != sizeof(struct vprbrd_adc_msg)) {
> > - dev_err(&iio_dev->dev, "usb send error on adc read\n");
> > error = -EREMOTEIO;
>
> This also a local variable that doesn't need to be in the critical section,
> right?
Tweaked and applied to the fixes-togreg branch of iio.git + marked for stable.
>
> > + mutex_unlock(&vb->lock);
> > + dev_err(&iio_dev->dev, "usb send error on adc read\n");
> > + goto error;
> > }
>
next prev parent reply other threads:[~2026-05-11 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 19:07 [PATCH v2] iio: adc: viperboard: Fix error handling in vprbrd_iio_read_raw Salah Triki
2026-05-09 7:56 ` Andy Shevchenko
2026-05-11 17:09 ` Jonathan Cameron [this message]
2026-05-09 8:46 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511180858.12cad4f2@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox