From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5BCC17557E for ; Tue, 12 May 2026 01:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778548531; cv=none; b=RFU7KkbsnGeMQu1O4675R+Fj7Px9EPs7lD9FVDPXRiDpa/tOaRNnJx+jsllTwdXRNI6suOqaHo9/6y2vkB+PLforujYNHJfs0uHv/D3BEOykM8te7oBBX9UBb96VFfOOtOzccZl0zAGA3c/I7tbJgiaNXisO6ZN4RwQ8fK89dOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778548531; c=relaxed/simple; bh=HVbILOszcupi7Ik7PLfUO7G0nFiNC1ryLLFURZp+gYg=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=mYpqY6d2bfSZBsW++f2AMsMqtDNF7JTbdWRRa5b2+uWK1YYUGSdb4XV1pTR9UO+qkP/2mb7bvqWks/vFR2Fg6TNakzf/uugVsyaP8Bd5+ssUroyUbV6Iwv7GMb8gcYYCdoeIueoPmhwLmdHU7qX+4jfFsU2HnhGVecbP7TNcyjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=RcWOCmsL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="RcWOCmsL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 562A9C2BCB0; Tue, 12 May 2026 01:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1778548530; bh=HVbILOszcupi7Ik7PLfUO7G0nFiNC1ryLLFURZp+gYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RcWOCmsLH00BUVroBg1mMxU5PA0Dm+HQFg2RWuS7qR3eKvEq4kGHYhVGB1WXH2yyF uPSRaIROlVqRz9R+e4IF/NvYH1TwwBXGVWPqW6s/6sneOCvifzIOBhpYFaO9yZ3yXC O0tvE4xb2uQmMbb/hXWTIxir6jeinjGtyw2wDSHc= Date: Mon, 11 May 2026 18:15:29 -0700 From: Andrew Morton To: Baolin Wang Cc: Lorenzo Stoakes , hughd@google.com, willy@infradead.org, ziy@nvidia.com, david@kernel.org, lance.yang@linux.dev, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "tmpfs: don't enable large folios if not supported" Message-Id: <20260511181529.a099f05a9d96986d5e88a0ed@linux-foundation.org> In-Reply-To: References: <20260511150158.921c0ac72b31a6fa0a125ab8@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 May 2026 08:55:05 +0800 Baolin Wang wrote: > > > > Please let's not add new metadata without having told others what that > > metadata means? > > > > "Fixes:" should be sufficient. I interpret Fixes: as "apply this to any > > kernel which contains ". Is more needed? > > My concern is that if someone backports this patch to an older kernel > version without also backporting commit 665575cff098b, it would cause a > performance regression. > > Is there a good way to mark this kind of dependency on another patch? Not that I know of. Has someone sent 665575cff098b to -stable maintainers and asked them to treat it as Fixes: 5a90c155defa? > But I've already described this potential dependency in the commit > message, so I'm fine with just adding the "Fixes:" tag. Yeah, I guess the supporting text will help clear confusion. But you're right - our tooling should be able to express such things.