From: Leon Romanovsky <leon@kernel.org>
To: Shirin Kaul <shirin.kaul11@gmail.com>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: hw : use clamp() in _mlx5r_umr_zap_mkey()
Date: Mon, 11 May 2026 21:17:50 +0300 [thread overview]
Message-ID: <20260511181750.GN15586@unreal> (raw)
In-Reply-To: <20260503120457.49220-1-shirin.kaul11@gmail.com>
On Sun, May 03, 2026 at 12:04:57PM +0000, Shirin Kaul wrote:
> Use clamp() instead of min(max()) to make the code easier to
> understand.
>
> Signed-off-by: Shirin Kaul <shirin.kaul11@gmail.com>
> ---
> drivers/infiniband/hw/mlx5/umr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
We already discussed it there
https://lore.kernel.org/linux-rdma/20260310145727.236094-3-thorsten.blum@linux.dev/
Thanks
>
> diff --git a/drivers/infiniband/hw/mlx5/umr.c b/drivers/infiniband/hw/mlx5/umr.c
> index 29488fba21a0..92b76ee65779 100644
> --- a/drivers/infiniband/hw/mlx5/umr.c
> +++ b/drivers/infiniband/hw/mlx5/umr.c
> @@ -1014,7 +1014,7 @@ static int _mlx5r_umr_zap_mkey(struct mlx5_ib_mr *mr,
> MLX5_IB_UPD_XLT_ATOMIC;
> max_log_size = get_max_log_entity_size_cap(dev, access_mode);
> max_page_shift = order_base_2(mr->ibmr.length);
> - max_page_shift = min(max(max_page_shift, page_shift), max_log_size);
> + max_page_shift = clamp(max_page_shift, page_shift, max_log_size);
> /* Count blocks in units of max_page_shift, we will zap exactly this
> * many to make the whole MR non-present.
> * Block size must be aligned to MLX5_UMR_FLEX_ALIGNMENT since it may
> --
> 2.43.0
>
parent reply other threads:[~2026-05-11 18:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260503120457.49220-1-shirin.kaul11@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511181750.GN15586@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shirin.kaul11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox