From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B30147CC96 for ; Mon, 11 May 2026 18:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778523970; cv=none; b=O5qvItIhro3gGNMVnW9hGBphUuHodDVqIr1faiBg6Efjn2TzJdxl8ayn004Ktze1kMIU+hf8xqszi3A0/iShXrhUBVsezNHYx5fvLhvYn5RagBCvArMm6fX7Vo1xb97T7n03NO6L3u4aX93w5BvtREB1X2P1BsOWkBCAT45ST18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778523970; c=relaxed/simple; bh=w41p+XuSWxGXnKnkYfxFdCURnDMoorLE5URRZqMD+dA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qeb1uJnj/rq6EyrnvBZtu2Q0GrHduNLPUbI55KPEttfHfUTxT64/lPxBSSAQeyZBgE4zxa2kDoxiIetsPZg0+/HqR+gIw7eOGEm0o6LeUKQ+AEaJork0qMU5S2MGb4mHKq1NoFW3fmeIErH4ZYDm2e7AvDOVJ33LBtbSArXOifk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YtyScQAV; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YtyScQAV" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8ea8563c693so505788885a.2 for ; Mon, 11 May 2026 11:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778523968; x=1779128768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qGg607mDB+aA+0BtLq6p1jTSY7WNpk5M8K/OgQPTtdk=; b=YtyScQAVT8ZIi/dS3Ya1eLa1bHFmEWpTBLzdi1YCKSAwwcjbx+1c4tC1pYyr9E7bsN AHrjKaVII18Vgs35fj0G3vwd3KrBqsE0qPFoQ+iTJHFtwkBJZzjQHIlOyHkvh/weKb9N B9MXMmxhFOD0ad95ugtf6Tj85ewBNw3esiMruA3JGGfsYeISueAtmjHmrqNoSMRf5lNM JwZDQ3RvPaRP+nuLFpdNUpH14V+9H5pXhFJicZa/wAQLcLngL2WM0u5tGTUdUzQlti6X 6Kqw9va/3bh4v/juABLbu+N7sUqsJtuj9J1GHBsDwPQV/vkPVjJGAv4H3O26c8SkpVor Lv0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778523968; x=1779128768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qGg607mDB+aA+0BtLq6p1jTSY7WNpk5M8K/OgQPTtdk=; b=pBjcRAWR1j/oyig7/ycyHVgj3TJq8DL3vWxrJL7YVKWRFOugcBZgIl/1vt8Xfxk1Gq vtoEDq+lSRaY0nJOUXPNyvoZgbp8kPmeJjv38yaQwkg5r+p5cRkI2WqFcwxlTTDo6Oao vSBQtajMJaFCc3EvbyYIv56HWDivY+Bjd5phfKYJ6NpkEh4XXCAjeA9mNbUT6ATNoxy7 GvTMEOu2v3mWWhN5rHtOMsoF3OccKb/GRJSiZohALHzDOm7BloMpcLzMISrgTJ7uAbcs V4EkQC+wIwX4e+xuIeu5MCLIL0rKO6YhKoTOSoyncJo0hNgrhfV9z+YH+cJ4KhLrE69P dh4Q== X-Forwarded-Encrypted: i=1; AFNElJ9bZnbcvHTbaygmOMW6ElaX843R5SiEhrmqAc2f21atwuoAg7v0/gpzoHKXm7+XN+JkGlktvnGllWHECvs=@vger.kernel.org X-Gm-Message-State: AOJu0YxRxr9BiZ5l2Q2H9YnYwEzrly5lwUyVpWhm1B8so+oIZF4+mqyN H4q4DJofjTvlvFMwG5jnjwV+HiExyFAHp/Y/GLhCjiBKsS/XUNDauTeb X-Gm-Gg: Acq92OFJ8lGTL0ti5ISowB/FBxb4oiKGED664l5udj+CMVbzJCVHf3TDKm3OgQfJjmM Qp++3N1TafSEs/2bTVZLvFuYBLeZGPPbJUQi8VBXyJ46Q2FWWA5JVwChLzJPp2p3SYJ7Gxjc4+P t3bscToR94Gir8hbwl7rNfdwptMmhRkaYOuFIYfC3vrpa7Q6it15d2KGXtaEz9f7ciI+NcxcN24 I8zhEnngHqjduSksPaNJeXQQh6w3cv8CL7iGcWCkT5GJ3+DM0VzSJIDiafVdaE5Q/kvJgLoK0T/ /TY+cLeoeCHI8qZcSLD1En4caWhFYvt6ga22fwYOsX9EILeh5x0yVlQgZa9+YFGfyKIxRwQpLAj VTslwmmZV0pSZOFrZYsLKPhgS9znLiaPxhZJzUqMYQ2B0e2Q0mPGS3vFd5nF+sIWVteKC9pW61H gsVlySZoPd7SEJv0ScvDhhO5t6eHfQrT0mlrCfey5GBlSYQb+bA2lwEA820s1t7/Pc+5/ea9QXc cIRiw== X-Received: by 2002:a05:620a:40d1:b0:8ea:f0e0:26dc with SMTP id af79cd13be357-904d4d54625mr4121831885a.24.1778523968159; Mon, 11 May 2026 11:26:08 -0700 (PDT) Received: from PF5YBGDS.localdomain ([163.114.130.1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-907b8d9ea06sm1111346885a.20.2026.05.11.11.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 11:26:07 -0700 (PDT) From: mike.marciniszyn@gmail.com To: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Heiner Kallweit , Russell King , Kees Cook , Andrew Lunn Cc: mike.marciniszyn@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/2] net: pcs: xpcs: Add hooks for xpcs configuration of rsfec Date: Mon, 11 May 2026 14:26:03 -0400 Message-ID: <20260511182604.1338-2-mike.marciniszyn@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260511182604.1338-1-mike.marciniszyn@gmail.com> References: <20260511182604.1338-1-mike.marciniszyn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Mike Marciniszyn (Meta)" The DW PCS IP data sheet calls out the need to populate these vendor registers when operating at speeds above 10Gbps. This change enables the correct FEC settings to enable RS-FEC encoding on the link which is the standard used for most links at these higher speeds. Note that the overwriting of the MDIO_PMA_RSFEC_CTRL register is intentional and consistent DW PCS IP requirements. Reviewed-by: Alexander Duyck Signed-off-by: Mike Marciniszyn (Meta) --- v2: - Allow mdiobus probing for addr 0 and addr 1 - Add xpcs_find* helpers based on phy_find* to avoid hardcoded addresses - Remove xpcs_bus write and use mdiodev_c45_write instead - Address comment on use of MDIO_PMA_RSFEC_CTRL v1: https://lore.kernel.org/all/20260506190904.4029-2-mike.marciniszyn@gmail.com/ drivers/net/ethernet/meta/fbnic/fbnmdiodev_c45_writeic_mdio.c | 3 +- drivers/net/pcs/pcs-xpcs.c | 105 +++++++++++++++++++ drivers/net/pcs/pcs-xpcs.h | 6 ++ include/uapi/linux/mdio.h | 3 + 4 files changed, 115 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_mdio.c b/drivers/net/ethernet/meta/fbnic/fbnic_mdio.c index fe3a4ce88413..e29534dd1e0c 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_mdio.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_mdio.c @@ -263,8 +263,7 @@ int fbnic_mdiobus_create(struct fbnic_dev *fbd) bus->read_c45 = &fbnic_mdio_read_c45; bus->write_c45 = &fbnic_mdio_write_c45; - /* Disable PHY auto probing. We will add PCS manually */ - bus->phy_mask = ~0; + bus->phy_mask = GENMASK(31, 2); bus->parent = fbd->dev; bus->priv = fbd; diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c index e69fa2f0a0e8..14f89e56958c 100644 --- a/drivers/net/pcs/pcs-xpcs.c +++ b/drivers/net/pcs/pcs-xpcs.c @@ -1402,6 +1402,107 @@ static int xpcs_read_ids(struct dw_xpcs *xpcs) return 0; } +static int xpcs_get_pma_mmd(struct dw_xpcs *xpcs) +{ + int devs1, b; + + devs1 = xpcs_read(xpcs, MDIO_MMD_PMAPMD, MDIO_DEVS1); + if (devs1 < 0) + return devs1; + + /* Locate the PMA closest to the PCS as this should be the one provided + * with the DW IP. This is identified by being the PMA with the + * highest MMD device address. + */ + devs1 &= MDIO_DEVS_SEP_PMA1 | MDIO_DEVS_SEP_PMA2 | MDIO_DEVS_SEP_PMA3 | + MDIO_DEVS_SEP_PMA4 | MDIO_DEVS_PMAPMD; + b = fls(devs1); + if (b) + return b - 1; + + return -ENODEV; +} + +struct pma_pcs_values { + int lanes; + u16 rsfec_ctrl; +}; + +static struct mdio_device *xpcs_find_first_mdev(struct dw_xpcs *xpcs) +{ + struct phy_device *p = phy_find_first(xpcs->mdiodev->bus); + + if (!p) + return NULL; + return &p->mdio; +} + +static struct mdio_device * +xpcs_find_next_mdev(struct dw_xpcs *xpcs, struct mdio_device *mdev) +{ + struct phy_device *p = container_of(mdev, struct phy_device, mdio), *n; + + n = phy_find_next(xpcs->mdiodev->bus, p); + if (!n) + return NULL; + return &n->mdio; +} + +static int +xpcs_config_rsfec_pma(struct dw_xpcs *xpcs, const struct pma_pcs_values *v) +{ + struct mdio_device *mdev; + int ret = 0, i, pma_mmd; + + pma_mmd = xpcs_get_pma_mmd(xpcs); + if (pma_mmd < 1) + return pma_mmd; + + mdev = xpcs_find_first_mdev(xpcs); + if (!mdev) + return -ENODEV; + + for (i = 0; mdev && ret >= 0 && i < v->lanes; + i++, mdev = xpcs_find_next_mdev(xpcs, mdev)) { + ret = mdiodev_c45_write(mdev, pma_mmd, MDIO_PMA_RSFEC_CTRL, + v->rsfec_ctrl); + } + if (!ret && i < v->lanes) + return -ENODEV; + + return ret; +} + +static int xpcs_25gbaser_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = 0, + .lanes = 1, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + +static int xpcs_50gbaser_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = DW_VR_RSFEC_CTRL_TC_PAD_ALTER, + .lanes = 2, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + +static int xpcs_100gbasep_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = MDIO_PMA_RSFEC_CTRL_4LANE_PMD, + .lanes = 2, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { { .interface = PHY_INTERFACE_MODE_USXGMII, @@ -1415,6 +1516,7 @@ static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { .interface = PHY_INTERFACE_MODE_25GBASER, .supported = xpcs_25gbaser_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_25gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_XLGMII, .supported = xpcs_xlgmii_features, @@ -1423,14 +1525,17 @@ static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { .interface = PHY_INTERFACE_MODE_50GBASER, .supported = xpcs_50gbaser_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_50gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_LAUI, .supported = xpcs_50gbaser2_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_50gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_100GBASEP, .supported = xpcs_100gbasep_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_100gbasep_pma_config, }, { .interface = PHY_INTERFACE_MODE_10GBASER, .supported = xpcs_10gbaser_features, diff --git a/drivers/net/pcs/pcs-xpcs.h b/drivers/net/pcs/pcs-xpcs.h index 929fa238445e..187cdec30e70 100644 --- a/drivers/net/pcs/pcs-xpcs.h +++ b/drivers/net/pcs/pcs-xpcs.h @@ -94,6 +94,12 @@ #define DW_VR_MII_DIG_CTRL2_TX_POL_INV BIT(4) #define DW_VR_MII_DIG_CTRL2_RX_POL_INV BIT(0) +/* Clause 133 defines */ +/* RSFEC transcode pad alter + * DW vendor extension in RS-FEC control + */ +#define DW_VR_RSFEC_CTRL_TC_PAD_ALTER BIT(10) + #define DW_XPCS_INFO_DECLARE(_name, _pcs, _pma) \ static const struct dw_xpcs_info _name = { .pcs = _pcs, .pma = _pma } diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h index b2541c948fc1..5219c877b2cf 100644 --- a/include/uapi/linux/mdio.h +++ b/include/uapi/linux/mdio.h @@ -317,6 +317,9 @@ #define MDIO_PMA_10GBR_FECABLE_ABLE 0x0001 /* FEC ability */ #define MDIO_PMA_10GBR_FECABLE_ERRABLE 0x0002 /* FEC error indic. ability */ +/* RSFEC PMA Control register */ +#define MDIO_PMA_RSFEC_CTRL_4LANE_PMD BIT(3) + /* PMA 10GBASE-R Fast Retrain status and control register. */ #define MDIO_PMA_10GBR_FSRT_ENABLE 0x0001 /* Fast retrain enable */ -- 2.43.0