From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4A64ADD85 for ; Mon, 11 May 2026 19:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778526759; cv=none; b=Byd61WteDgVwxJGqQTgi1gQ3Jlt231Ud1ZsLMlKNT18h8Qr6D1IlAwTEsuISFc3O0OEWaylz5bPgu63TYLsaiQHN7JdoGthkCuJl8uGtgMRgcL3FTwreyNGHr9hzt2i1RpdjJgFumN7mcygtD6M66daNgmZJR5ZsW+06aZbz80o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778526759; c=relaxed/simple; bh=HMPkYA8vLk6BW/UOOQJOOgFaU8+AU+9MI2MmkTJJ3xY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IjIikSuXTzkMT8VMhp+6WpyIgnYE5gN1MoHY9vLs8bgtE6Tx00VrnBdZonIv1sDfKCXA5CkRBg9TqY3A5lBOC5NdvWWnmBwZRqSFqPLL6/FjKYzaq5MgL/aASxXOI1MG2zaneflCOFP65RsTe8us+hoMlsRBr0sb/fIDSzm8CoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ad55jnZl; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ad55jnZl" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-366070f71adso4193132a91.2 for ; Mon, 11 May 2026 12:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778526758; x=1779131558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xArGq1W9dDFcfzmBReyO33DGfNzj4pxhNHfsKRuBCvQ=; b=Ad55jnZlU27fluKZ8apFAE6aaqSWjq+6QZi4RQ+d0ky3pXo/1QzqwJ0hRZ9mDNjSeo 2ZSWKB27sHLo5UGHmd+te8MbaIybhWPqRYHDFG8Q2phS8ZSMjg1R4ZtpRKKPN6qYd9Sg X0M0Ofoj0W3MWjC8rujrJaFwReuKn+0k7Nms8djnyXB/9tU9DlsjPEH8d4CjldLCujN5 zpiXOn2qw39S2v87TcIi/KIS1+ryGXx6C2uHhiAGI353pXke8auKNAIPax5GBQ2Q2ABX ALizrOOz7qspr/DDD1N1jwM+R/kUf4vnJ1gDjJ8yOuLTIM1aJD4zq4hZ34fxm6tZxQqQ JrRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778526758; x=1779131558; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xArGq1W9dDFcfzmBReyO33DGfNzj4pxhNHfsKRuBCvQ=; b=dyAgisDN7Tw+z2b6NibZcuRP5H74uJFHmz0hHrjlQHtbSEDxPCT0ve9YS0fMzWAWkW qBccVQEZDvYmUJqm+YDb6McHYIk8YFDm5S/qwhVue3k5uanTrxZwdLykbVSFPNsqgJv9 RQcnwW/2ukoDheyb4+Et5Y3hS1W4rACDUBbuyUpZ1uWGILW4TGFOraaMKli/nxptRL8U EPJV5OmcHSCVYdr9J6PViqmdk2ITP09GpUVDtOarAYHt6C7kcNDv7QG574rbJUkYDz6q g3c4eliDJINpY37E7pxSBOw4E6LllNsFRXJxKj8t0ImU/IqPPjyZtqDUnBCJKX132ZmN xXvA== X-Forwarded-Encrypted: i=1; AFNElJ8AJylpwQy1HKkHKoDuoZ+c6KCKLT7+9qSUl8as0fPEp+C4DbAS2522oiZ0lo4AnLi1soK9x5IIIMv0Q3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyrI+zzHMjiTDA8dLY7vEdT1Nh83bWPGeNt8eoDfWJ4lwI4hXpi EFo3AmpwcvXHX/VLTWU/idj0Q+r9e6KUldmlS0yhuVkxqRrbAo/YSSqh X-Gm-Gg: Acq92OFh6EQEwxeY6nh/bFKNbJyx7ptzreZvPEFerUTI9E8DpuapJvcefjVj/znTIQu Ls/V2G4kdib03AQF0Cd7pdw5rlEObFKtvZOad1di2OXanFP5X5cQ0DKUxyk05+IcP9OElQHwyd2 CLNFM+eCzry/779i9cujz2NkCFeLuiDAVDg99Ol8O48c89Cz+4j/pcSl4PYCD6CjJPVKgoltUuU gHi2jvptHxyPiG9S2tfFZytDqzE/VynAbYaOHcd9UcvTfgOORs0xxiMqOMx3gXr5zTSFB5MCov7 ubxXantXNMsFKlRHyEQegQINtWKVWT4nb9Fs6ysZj0q/sKEul2X0DVhb5+eEmHtXt8v5Od5gqdQ 0tu1jICGBhHki03GSBo+AImZdQOsVWOYViYMGRliPROA7W1xjlGKbgTlylW5XORpnslFBWboSPB ERmeL7ZUBTNMjDRsODWX/DlDWDUX0F4g== X-Received: by 2002:a17:90b:2248:b0:35f:b348:63e with SMTP id 98e67ed59e1d1-365abbe373cmr27047114a91.9.1778526758140; Mon, 11 May 2026 12:12:38 -0700 (PDT) Received: from vini ([2401:4900:8fc8:73c6:dda6:576b:fa0d:f68e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d629f3b5sm8686184a91.8.2026.05.11.12.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 12:12:37 -0700 (PDT) From: Vineet Agarwal To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vineet Agarwal Subject: [RFC PATCH] mm/damon/sysfs-schemes: fix double increment of nr_regions Date: Tue, 12 May 2026 00:42:15 +0530 Message-ID: <20260511191218.98881-1-agarwal.vineet2006@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damos_sysfs_populate_region_dir() increments sysfs_regions->nr_regions twice when adding a new region: once explicitly before kobject_init_and_add(), and once again through the post-increment used for the kobject name. As a result, nr_regions no longer matches the actual number of live regions, and region directory names skip numbers (1, 3, 5, ...). Use the already incremented value for naming instead of incrementing nr_regions a second time. Signed-off-by: Vineet Agarwal --- mm/damon/sysfs-schemes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 622c3799db87..5d966ac86419 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2998,7 +2998,7 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes, if (kobject_init_and_add(®ion->kobj, &damon_sysfs_scheme_region_ktype, &sysfs_regions->kobj, "%d", - sysfs_regions->nr_regions++)) { + sysfs_regions->nr_regions)) { kobject_put(®ion->kobj); } } -- 2.54.0