From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 213553B5314 for ; Mon, 11 May 2026 20:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778532956; cv=none; b=D6da92rzNkAQMxoF3ereuPzssVS4daVlGM/pKhaKMfZ74aL/C9PKYpI15e97pF0UaVkivCsnRgtFLfgoFwiJS2IXYXVf0gfSSXVSxLGXGhU2fLXpE9R7vhFHEXL26CAKCDiMEc0/vo0Le7tEc/ZKvMRS80EVLlewr6sIHToADxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778532956; c=relaxed/simple; bh=JoDL26nJZLzsTVSAvQhlHLPWBGibCLeQm+1s5B4ehF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QRtzyneQErMyErvsInuKfKIoqtdtA3BIRrqP8U1JEoLVE6gpZzxOcSEUgvlhaegnzAVnBCaotCQv5d3MLyfJO0NBEJGWdTvCe3Rm2Dsqzr65qfykB3mODP975+puP0qLAr2LYh8YESTdqs3owdMLr6LLA6BanItRPpeFELgx9xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=dchAs2qJ; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=5bbynROG; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=1yQSSNz/; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=pBXbFuxm; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="dchAs2qJ"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="5bbynROG"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="1yQSSNz/"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="pBXbFuxm" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E85E9686A8; Mon, 11 May 2026 20:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1778532953; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+WLat0LfBW9mjj9R0xjrRvGkhOfoWk8scIZMYapRcA=; b=dchAs2qJksBAIGPknh5NLo4THGJYe8WTg0tz5Q0UT+UvJ5iFyd/CsdcVrUwuXfenWy/VJk oQtCxMKqkFnrVWoOGOGqM8ZvfusUgx5OAanE3fmOtkIa626a5YrYiMo10IZf+GXmt0r0D1 KzLARFMI2a+GWR8egaw7plhKYQj0Ehk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1778532953; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+WLat0LfBW9mjj9R0xjrRvGkhOfoWk8scIZMYapRcA=; b=5bbynROG3Ft0IZI1l7XUBTdHYAU2L4xtXJr2/VRYIzQ1U1swPVwM/xyOoT3FRbUc40lpAx RTgLn8zPud8Qy1Bg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1778532952; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+WLat0LfBW9mjj9R0xjrRvGkhOfoWk8scIZMYapRcA=; b=1yQSSNz/4WSTJBh9fj+YuLhBvv1h4bb7ZMxWLjFN8INjVb+I3AvPV4OV4eNF0hlZeJBf10 wPNCxvkRXX/tIGR1vwAtAmvl5DV51G2tyvD2euFOSZjpAa0joeikHX+zgtJn0TzQmnhsvt Gv2si1DIVoStRekLiS06jeR6q7htBfU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1778532952; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+WLat0LfBW9mjj9R0xjrRvGkhOfoWk8scIZMYapRcA=; b=pBXbFuxm0YunHdySVGrItuq8Gnv+KKdJcqHIVYI1pOaNy8POQMhIn0BoNBn7jHVlnitI2y gb5elQhiTXxifIAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9684B593A3; Mon, 11 May 2026 20:55:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6XqjIVhCAmpzYAAAD6G6ig (envelope-from ); Mon, 11 May 2026 20:55:52 +0000 Date: Mon, 11 May 2026 22:55:43 +0200 From: Petr Vorel To: Simon Glass Cc: linux-kernel@vger.kernel.org, Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Przemek Kitszel Subject: Re: [PATCH 1/1] checkpatch: Ignore format macros Message-ID: <20260511205543.GA20488@pevik> Reply-To: Petr Vorel References: <20260511121237.11030-1-pvorel@suse.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Level: X-Spamd-Result: default: False [-2.00 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,perches.com,gmail.com,intel.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:replyto,suse.cz:email]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Score: -2.00 > Hi Petr, > On Mon, 11 May 2026 at 06:12, Petr Vorel wrote: > > Constants from are used only in userspace tools, they are > > from ISO C99, let's don't report it: > > arch/mips/boot/tools/relocs.c:572: CHECK: Avoid CamelCase: > > arch/s390/tools/relocs.c:52: CHECK: Avoid CamelCase: > > tools/testing/selftests/mm/vm_util.c:244: CHECK: Avoid CamelCase: > > Signed-off-by: Petr Vorel > > --- > > scripts/checkpatch.pl | 2 ++ > > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 3727156e4ccad..4c7a952a418c0 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -5940,6 +5940,8 @@ sub process { > > #Ignore SI style variants like nS, mV and dB > > #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE) > > $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ && > > +#Ignore format macros (e.g. PRIu64, SCNu64) > > + $var !~ /^(?:PRI|SCN)[dioux][A-Z0-9]+$/ && > > #Ignore some three character SI units explicitly, like MiB and KHz > > $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) { > > while ($var =~ m{\b($Ident)}g) { > > -- > > 2.53.0 > Reviewed-by: Simon Glass Thanks for your review! > How about adding X as well, since also defines > uppercase-hex variants like PRIX8 Yes, but that would not be cought as CamelCase (no lower case character). Kind regards, Petr > Regards, > Simon