The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Harshit Shaw <shawharshit116@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix line exceeding 80 characters in vme_user.c
Date: Mon, 11 May 2026 10:17:59 +0200	[thread overview]
Message-ID: <2026051123-popular-peddling-e67d@gregkh> (raw)
In-Reply-To: <20260511080815.3521-1-shawharshit116@gmail.com>

On Mon, May 11, 2026 at 08:08:15AM +0000, Harshit Shaw wrote:
> Wrap the vme_user_vm_mapped() function signature that
> exceeded the 80 character line limit as reported by
> checkpatch.pl.

You get a full 72 characters here.

> No functional change.
> 
> Signed-off-by: Harshit Shaw <shawharshit116@gmail.com>
> ---
>  drivers/staging/vme_user/vme_user.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme_user.c b/drivers/staging/vme_user/vme_user.c
> index 11e25c2f6b0a..f5e29933ba68 100644
> --- a/drivers/staging/vme_user/vme_user.c
> +++ b/drivers/staging/vme_user/vme_user.c
> @@ -446,8 +446,9 @@ static void vme_user_vm_close(struct vm_area_struct *vma)
>  	kfree(vma_priv);
>  }
>  
> -static int vme_user_vm_mapped(unsigned long start, unsigned long end, pgoff_t pgoff,
> -			      const struct file *file, void **vm_private_data)
> +static int vme_user_vm_mapped(unsigned long start, unsigned long end,
> +			      pgoff_t pgoff, const struct file *file,
> +			      void **vm_private_data)

100 is an ok line length to stay at, the original code is just fine.

thanks,

greg k-h

  reply	other threads:[~2026-05-11  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  8:08 [PATCH] staging: vme_user: fix line exceeding 80 characters in vme_user.c Harshit Shaw
2026-05-11  8:17 ` Greg KH [this message]
2026-05-11  8:22 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11  6:45 Hanu-man12

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026051123-popular-peddling-e67d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=shawharshit116@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox