Re: [PATCH v6] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

[gregkh <gregkh@linuxfoundation.org>]

On Thu, May 07, 2026 at 09:36:00PM +0530, Ashwin Gundarapu wrote:
> 
> 
> >From 50c6b6259becbb357e3d7c9f8e26cef10b4e0ef3 Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Thu, 7 May 2026 21:29:11 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
> 
> Remove braces around single statement blocks.
> 
> Found by checkpatch.pl --strict
> 
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 9cf1c95dd924..c14b8dbd478b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -483,13 +483,13 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
>                         break;
>                 }
>  
> -               if (rtw_roam_flags(adapter)) {
> +               if (rtw_roam_flags(adapter))
>                         /* TODO: don't select network in the same ess as oldest if it's new enough*/
> -               }
> +
>  
>                 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned))
>                         oldest = pnetwork;
> -       }
> +
>  
>         /*
>          * If we didn't find a match, then get a new network slot to initialize
> @@ -2410,9 +2410,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe
>  
>         len = 0;
>         p = rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPERATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie));
> -       if (p && len > 0) {
> +       if (p && len > 0)
>                 /* todo: */
> -       }
>  
>         if ((pregistrypriv->bw_mode & 0x0f) > 0)
>                 cbw40_enable = 1;
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot