The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pramod Maurya <pramod.nexgen@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	nikolayof23@gmail.com
Subject: Re: [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h
Date: Mon, 11 May 2026 10:09:53 +0200	[thread overview]
Message-ID: <2026051131-refund-credibly-182b@gregkh> (raw)
In-Reply-To: <20260510175103.562518-3-pramod.nexgen@gmail.com>

On Sun, May 10, 2026 at 01:51:03PM -0400, Pramod Maurya wrote:
> The extern keyword is redundant on function declarations in header files.
> Remove it from all prototypes in cmd_osdep.h and fix extra whitespace
> in the struct parameter types while at it.
> 
> Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/cmd_osdep.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h
> index 41daa3c339a8..4e52e7240058 100644
> --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h
> +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h
> @@ -7,11 +7,11 @@
>  #ifndef __CMD_OSDEP_H_
>  #define __CMD_OSDEP_H_
>  
> -int rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv);
> +int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv);

This is not an extern change :(


  reply	other threads:[~2026-05-11  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya
2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya
2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya
2026-05-11  8:09   ` Greg KH [this message]
2026-05-10 20:08 ` [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Nikolay Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026051131-refund-credibly-182b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nikolayof23@gmail.com \
    --cc=pramod.nexgen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox