From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1574E3A8741 for ; Mon, 11 May 2026 07:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778486269; cv=none; b=k6T7JaJ3YFMvnypzrR7ikzl2Y5swxCNqV/vEct6VLeabW25JiDixEeS+3a8Gjugiy8CryGb1xEGxFVxek7Dekf93C6jAxTiHNzFYUpDX1lobXR3dn8m8FzbUjvQ2HBr0Dqu/nTzmyKh4DoOo1GlKwUk6FFRPefbs/hJwHfVaYcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778486269; c=relaxed/simple; bh=798sJiKbFZJ6lw3Oj16ENmUOOX9iO3PdQraKwGKwgQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fUxPt+s6KQ69NWBN6aM0J16ZMASer8DrdMF5aHplTWZSzRxN5hWKfbkSvlzM4IsW3unPKWGyaZKVCm4W7uucYYEVGPOWOUxY7o52qkJlwNiMZwDVQW1lg73+4i7LdUQIYI+RCiUunVfkSbEfjtAlAAsqxVA31wGKh0GBanxVi9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KykhHDPT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KykhHDPT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66A91C2BCB0; Mon, 11 May 2026 07:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778486265; bh=798sJiKbFZJ6lw3Oj16ENmUOOX9iO3PdQraKwGKwgQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KykhHDPToBhaoXlUZHLXd8rNts+xsMcFo/cDvohs+veF/lnGBtpA7Sr1rOGsuxNIm y1VUnY/qAftVBFOyrFuz6yzZaZIAJ5vVBwH83tpMFq0XQ+Utk7MnDOJNm3htiYLpIx 51S+P1TmrNDv5xEvOAI02s/FDptYgl0ES/qQyVus= Date: Mon, 11 May 2026 09:57:43 +0200 From: Greg KH To: Denis Arzubov Cc: linux-staging@lists.linux.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Fix const pointer declaration Message-ID: <2026051136-bribe-retention-76a3@gregkh> References: <20260504223628.60428-1-denisarzubov8@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260504223628.60428-1-denisarzubov8@gmail.com> On Tue, May 05, 2026 at 01:36:27AM +0300, Denis Arzubov wrote: > Make g_fbmode array pointer const to follow kernel coding style. > This resolves the checkpatch warning: > WARNING: static const char * array should probably be static const char * const > > Signed-off-by: Denis Arzubov > --- > drivers/staging/sm750fb/sm750.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index fadba95850be..8fc0d1c66991 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -33,7 +33,7 @@ > static int g_hwcursor = 1; > static int g_noaccel; > static int g_nomtrr; > -static const char *g_fbmode[] = {NULL, NULL}; > +static const char * const g_fbmode[] = {NULL, NULL}; > static const char *g_def_fbmode = "1024x768-32@60"; > static char *g_settings; > static int g_dualview; > -- > 2.43.0 > Please always test-build your changes :(