From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9223314AC for ; Tue, 12 May 2026 06:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568477; cv=none; b=s0k7okEtvHrtUJPznKQBy4l2IYHzxBF/8QJrvtUxfHzMXKRa5LzJvAddBgHeowPJtjN+jQRDhPSvpNymGC2MPmeJof8Pg/BncbS/JirG8i17K5czeK2loWJT15LrufUMErzupzQRL8/pehitF6F1GgUB7KpbXdiHiKpcvSgfvSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568477; c=relaxed/simple; bh=gBj1E/CKiORk+xl+ASYBMQ5sWMfE7HvshMxqF7YdwVk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=XMw8AiT6oXJ2vaKtJkZTzyKfqemh8cej9Ua0/nvGLh69B6J/KT1qWPBzVXthQc77K+8Rh5GtQkdM+iYUAag/qRiOY5xqxYl6Uu/O8Bqeyktr6Mv7ZTrbTlD4LzrFVFCToValUFarA2xTlTWq6TWfC8SRQPX3MBsAoAd7erKe+nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=RA64xLNj; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="RA64xLNj" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64C4BwAZ1813823; Tue, 12 May 2026 07:47:37 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=W uk+LzyPueCiKjFyG6u1k80LKDaf7h16Y4+dMk2Yndo=; b=RA64xLNjWLypogYkD pE71am5x9pJl+E6f9UNhbb6REGYEex/gKEb/bjxK5EUjEo/TFN/4NHhuWhBr7Edz YGHkgbjE8s4PtPmVzgI4chCrzCYhmWSeaUqvVYAuXvkVGLQoZhzvI1fkfpzKXbj6 hyT16Vi2CrAgREPF2wU8PmWwhpHVR/1FNa5NtMv6v1hbOmVUW8wknNqYb/fGP1Q/ SdcZ72H9kMZ9bdKAngc6jbgzP1V5s7x8dFJMGaXUKaowe+YDdZcG8t5qRWvzvUBk ByaMBEmU8ddsKK8LTMTYzTZIlZJuFmUWLR8Hn0+5qUPSkqylaE2PFHEEdKRofanR okWXQ== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4e1w0t2c6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 May 2026 07:47:37 +0100 (BST) Received: from [127.0.1.1] (172.25.128.214) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 07:47:33 +0100 From: Brajesh Gupta Date: Tue, 12 May 2026 12:17:05 +0530 Subject: [PATCH 3/4] drm/imagination: Rename FW booted to FW initialised Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260512-b4-context_reset-v1-3-439bee96ed83@imgtec.com> References: <20260512-b4-context_reset-v1-0-439bee96ed83@imgtec.com> In-Reply-To: <20260512-b4-context_reset-v1-0-439bee96ed83@imgtec.com> To: Frank Binns , Matt Coster , Alessio Belle , "Alexandru Dadu" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Brajesh Gupta" X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778568444; l=4988; i=brajesh.gupta@imgtec.com; s=20260417; h=from:subject:message-id; bh=gBj1E/CKiORk+xl+ASYBMQ5sWMfE7HvshMxqF7YdwVk=; b=qeKtEzvE5ScWCuxzY8p03ggmyXOmRyuAilmdKCSxpsdJC3ZXvCql6pcAIuyDn+/ysIIZ2p5Fk ZoaDgjc3+xsCaaOUVOPyfIL6+af5l8quDBrgxv3D2CS4cK5IxQ4BU8x X-Developer-Key: i=brajesh.gupta@imgtec.com; a=ed25519; pk=vDcrSP6vOpWKs914T986xUbB/vY0/cU7mRRb16MRkcg= X-Authority-Analysis: v=2.4 cv=b/6CJNGx c=1 sm=1 tr=0 ts=6a02cd09 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=aRQ8HefCnzIA:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=xXLj2AOFsAhGXIg0LM0A:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDA2NCBTYWx0ZWRfX/3NPxuGjl3md wet+dK3322u4pntkrLlzIpt/8BPr8lkyovMulsEqOqnKmj0Q79aBj34kBTCS5E1OIHax/vLgpel dyMAS6ERNnKrPaui2zun64FA4oPs3GS9+S28tJONUBr2+IG3Lh6KaNQkNOi5H2mI+yx2HI8f/0z d0CHcxJA+Oh+5NTKsvZv2R9RVf0/yFEs4xGoLJPNxjEftE2KNbH5TsVbiMlUFdj2qQAjC0yuCJ9 hucp7UpN91F8JK+0DRV/0gxfrlGIUJ5tPqApO8AXyKb2asDpIVvsfcAdLU3DjB3DdOj26aR2cRU TPZ/Adw0lARkZ14j8dFovM9S2p8LtJeEq3FN/eg3ICGKj8TrKxmt+zD3MlhoSDO7XaFB7XvxJtA ZPm676geiVSoDnXJwfFYkv8tiGFZcBpqrnvdAEW9wtqEnRE8Irz/zRKa9hIb6mtnpqNFH4uru3P SUEBB4cuZpVCzz9iUkA== X-Proofpoint-GUID: 2_XFnxKXLJmmvII2a9_giq_qtJS-8fJ2 X-Proofpoint-ORIG-GUID: 2_XFnxKXLJmmvII2a9_giq_qtJS-8fJ2 Update name to FW initialised from booted to better represent FW state. Signed-off-by: Brajesh Gupta --- drivers/gpu/drm/imagination/pvr_device.c | 2 +- drivers/gpu/drm/imagination/pvr_fw.c | 4 ++-- drivers/gpu/drm/imagination/pvr_fw.h | 7 +++++-- drivers/gpu/drm/imagination/pvr_mmu.c | 4 ++-- drivers/gpu/drm/imagination/pvr_power.c | 14 +++++++------- 5 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c index dbb6f5a8ded1..49696101b547 100644 --- a/drivers/gpu/drm/imagination/pvr_device.c +++ b/drivers/gpu/drm/imagination/pvr_device.c @@ -213,7 +213,7 @@ static irqreturn_t pvr_device_irq_thread_handler(int irq, void *data) while (pvr_fw_irq_pending(pvr_dev)) { pvr_fw_irq_clear(pvr_dev); - if (pvr_dev->fw_dev.booted) { + if (pvr_dev->fw_dev.initialised) { pvr_fwccb_process(pvr_dev); pvr_kccb_wake_up_waiters(pvr_dev); pvr_device_process_active_queues(pvr_dev); diff --git a/drivers/gpu/drm/imagination/pvr_fw.c b/drivers/gpu/drm/imagination/pvr_fw.c index 288516dc2560..b8ad3f1d222c 100644 --- a/drivers/gpu/drm/imagination/pvr_fw.c +++ b/drivers/gpu/drm/imagination/pvr_fw.c @@ -1004,7 +1004,7 @@ pvr_fw_init(struct pvr_device *pvr_dev) goto err_fw_stop; } - fw_dev->booted = true; + fw_dev->initialised = true; return 0; @@ -1044,7 +1044,7 @@ pvr_fw_fini(struct pvr_device *pvr_dev) { struct pvr_fw_device *fw_dev = &pvr_dev->fw_dev; - fw_dev->booted = false; + fw_dev->initialised = false; pvr_fw_destroy_structures(pvr_dev); pvr_fw_object_unmap_and_destroy(pvr_dev->kccb.rtn_obj); diff --git a/drivers/gpu/drm/imagination/pvr_fw.h b/drivers/gpu/drm/imagination/pvr_fw.h index 1404dd492d7c..3390c84e4fd3 100644 --- a/drivers/gpu/drm/imagination/pvr_fw.h +++ b/drivers/gpu/drm/imagination/pvr_fw.h @@ -295,8 +295,11 @@ struct pvr_fw_device { /** @mem: Structure containing objects representing firmware memory allocations. */ struct pvr_fw_mem mem; - /** @booted: %true if the firmware has been booted, %false otherwise. */ - bool booted; + /** + * @initialised: %true if the firmware has been successfully initialised, + * %false otherwise. + */ + bool initialised; /** * @processor_type: FW processor type for this device. Must be one of diff --git a/drivers/gpu/drm/imagination/pvr_mmu.c b/drivers/gpu/drm/imagination/pvr_mmu.c index 2e4da5b2c499..e9fefcc4e234 100644 --- a/drivers/gpu/drm/imagination/pvr_mmu.c +++ b/drivers/gpu/drm/imagination/pvr_mmu.c @@ -133,8 +133,8 @@ int pvr_mmu_flush_exec(struct pvr_device *pvr_dev, bool wait) if (!drm_dev_enter(from_pvr_device(pvr_dev), &idx)) return -EIO; - /* Can't flush MMU if the firmware hasn't booted yet. */ - if (!pvr_dev->fw_dev.booted) + /* Can't flush MMU if the firmware hasn't been initialised yet. */ + if (!pvr_dev->fw_dev.initialised) goto err_drm_dev_exit; cmd_mmu_cache_data->cache_flags = diff --git a/drivers/gpu/drm/imagination/pvr_power.c b/drivers/gpu/drm/imagination/pvr_power.c index 88fcce433d12..a73a6815306b 100644 --- a/drivers/gpu/drm/imagination/pvr_power.c +++ b/drivers/gpu/drm/imagination/pvr_power.c @@ -216,7 +216,7 @@ pvr_watchdog_worker(struct work_struct *work) if (pm_runtime_get_if_in_use(from_pvr_device(pvr_dev)->dev) <= 0) goto out_requeue; - if (!pvr_dev->fw_dev.booted) + if (!pvr_dev->fw_dev.initialised) goto out_pm_runtime_put; stalled = pvr_watchdog_kccb_stalled(pvr_dev); @@ -378,8 +378,8 @@ pvr_power_device_suspend(struct device *dev) if (!drm_dev_enter(drm_dev, &idx)) return -EIO; - if (pvr_dev->fw_dev.booted) { - err = pvr_power_fw_disable(pvr_dev, false, true); + if (pvr_dev->fw_dev.initialised) { + err = pvr_power_fw_disable(pvr_dev, false); if (err) goto err_drm_dev_exit; } @@ -408,8 +408,8 @@ pvr_power_device_resume(struct device *dev) if (err) goto err_drm_dev_exit; - if (pvr_dev->fw_dev.booted) { - err = pvr_power_fw_enable(pvr_dev, true); + if (pvr_dev->fw_dev.initialised) { + err = pvr_power_fw_enable(pvr_dev); if (err) goto err_power_off; } @@ -548,7 +548,7 @@ pvr_power_reset(struct pvr_device *pvr_dev, bool hard_reset) err = pvr_power_fw_disable(pvr_dev, hard_reset, false); if (!err) { if (hard_reset) { - pvr_dev->fw_dev.booted = false; + pvr_dev->fw_dev.initialised = false; WARN_ON(pvr_power_device_suspend(from_pvr_device(pvr_dev)->dev)); err = pvr_fw_hard_reset(pvr_dev); @@ -556,7 +556,7 @@ pvr_power_reset(struct pvr_device *pvr_dev, bool hard_reset) goto err_device_lost; err = pvr_power_device_resume(from_pvr_device(pvr_dev)->dev); - pvr_dev->fw_dev.booted = true; + pvr_dev->fw_dev.initialised = true; if (err) goto err_device_lost; } else { -- 2.43.0