From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD16E202F70 for ; Tue, 12 May 2026 00:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778545990; cv=none; b=Oyd4l0zY+WT5w4UGa596SIfhVtcjIyyi/aBChcLk3d/KHJL3si6VLdVU+22t7jYlsLSzK7tN2xxTyXZQTD4MzO2zKRYuceQ9/QAlPS8/oWfcIwoij+7EqM7JLMZSL3gL+cA0C4VZqHSAcXhIH+VnVD4N1Y4WZPoBB0Mk/aXsyKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778545990; c=relaxed/simple; bh=8apqNBwiUQ3KFEg2m0RNCENPpWhJVedpM0Uk42cNPhg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mrO0/ueQkLKRMAxnWqFULOEfnTUW4ir5hZMZAcN0ahUQ1Fi1UyTaE+TGJXxheK43W/40GUNM07tWdnCA5Sgpk3GmfmuRX3c5DrlyPt0Eys8ossFyeQNqFNFCHhqnDN1S4uj9OyXYTvbqQpUdsucG7eGnT1L1qdINf84nfG2zLrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ntyK2ig3; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ntyK2ig3" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-65c396d3b36so5129360d50.0 for ; Mon, 11 May 2026 17:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778545987; x=1779150787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YFO4d3KKfbsFkrq+A20d24Xfl/9uhV3LI/OXh0Z5sZ0=; b=ntyK2ig3iuf1wstJRhDmfAExxhvHRpuRTkZjVWKFQBMTDnF8Azgulo+9BBNrLyWAf0 /4QY8kcNHkp78/+Yx0CMhW4TJXhuTIlBOCVC+Fw2QXZYjT5wxu63v3vrYWziug70xD5r k58hOK1PbU1+cEZUvTgT492L3NcxqITp4Zy1bk78/a9By1SZpVBtOpMXBLKm8oLx2342 fCqXfM1IWsNqxU/2jnmjXNzOtuCHNocG1KNA3D+423A93eJtex4BRfZ3Vaw2wYGD8Vco Q/hvAJwyrNphmNDU9Z7CB/nBqL4Gz7cAnNokx/mGcTfRUi4giiY6rBv6y2XzJHHjHVp3 x6pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778545987; x=1779150787; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YFO4d3KKfbsFkrq+A20d24Xfl/9uhV3LI/OXh0Z5sZ0=; b=Zev/kWLP8Mpdmly5tiE0ETkuPu5BQljH+F39fx9Mib65Q7horXpiNrypiYVkQ719f2 iFFY9QXyPuE5hcBDxhpEAAPmecncy6v5lARpeKH/8cKNbqb9+LtaFWT5au7BLVAGA37Y dOylTDBXtDq1C8fnb2CI9QB8DicnwSsZDYMnf/f61tyKvbmQ8DX0UNFMYYKsaSvJAIyS 1r6TGCdQAcF4Kyo9qgC3GNLPYdLij3ow6NVwLlzuQuqIkPgzrfJ31ZqJzbe4t4YW8WmR Y3oviRzNjtzDBc1a2XdkJTBsOjYZhst7g7Uz74EOYUoLhlecdjLqzwhA12S2siXQuWng rsfg== X-Forwarded-Encrypted: i=1; AFNElJ9lXCksqxNJFfRXVSVPaRUMc4qqEoSTQR/7aGwiR8UFiRN3vv6F6AzsyS4RJTegVwYPqpIMakECsTqvM0g=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5Ea3qKl9uv3YQvtKg8pIxemhOSJQP3/3ppdF0iogCnj0+JqFD NOifWNgEiBTcgmoXkZQi8jDOeFYx6YcAKkry5ijAYhMwfeBan+8RZw17 X-Gm-Gg: Acq92OE7MuGFwl2OnXLb6XLFPUmgEI09jchWekYNGNEfuL8a9gKx4rLTXANY+rV6qJ7 XkSYhH9w0fnAht4eF2cQlvveUe6iw7quRZu1poV2+tWs3plu5miYyeaNMPNTrY+IjjpoUBimkeL GR1QbI5LNORHVkud7FHfIVyx/W7oyF0yYPsVJILLDtJm4me1cIg4UflKYmFzoo50EZWVYUAyXm0 f01MxBX9gdbW3bJuLA/qIqXQg6nyOyWQCemLFgaUK4mS8ejyY/hGDzMz6DTab0ygNULoJ+XvZKD GtGo7U2Y1k1g4XWmqazRq7qq8K7+tMgokhco24r0/Cq1ZC2ECif4clTtzJQlounCPPcKgiRg9cE 2LBlaWihuyf7wvx+Oh1Y2dvQVNC9s8S1fQjqLV7n0BlBQvpM1cRX/z0lFEbbjQDkBjfFH+e/odJ xX+SIR7gbL5VTrnRyCorWClcHTu7R8sCxMtAfHcKrs9+exkX0uI4kUeC8khYNHqu1hPBykFMZa3 V1etp19dIk6w+/jsSi6XTklv0HHRYdomxnURoYVavsGlS8oNA3+kFe5ttdTiEDBtZa/rBVbdt3g LyX49/JJ/o0ThXc= X-Received: by 2002:a05:690e:b8a:b0:65c:47ad:26c1 with SMTP id 956f58d0204a3-65de128608emr736702d50.46.1778545986903; Mon, 11 May 2026 17:33:06 -0700 (PDT) Received: from noahzen.tailef97f4.ts.net (host-119-66.flgaliv.gainesville.fl.us.clients.pavlovmedia.net. [153.33.119.66]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65de4aec812sm39439d50.7.2026.05.11.17.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 17:33:06 -0700 (PDT) From: Noah Techoueyres To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev Cc: nikolayof23@gmail.com, linux-kernel@vger.kernel.org, Noah Techoueyres Subject: [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c Date: Mon, 11 May 2026 20:31:15 -0400 Message-ID: <20260512003115.5570-1-noahtechoueyres@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix both block comments and assignment statements that exceed the 100-column limit to follow Linux guidelines for readability. Used intermediate pointers to fix assignment statements. Signed-off-by: Noah Techoueyres --- Changes in v2: - Replaced repeated struct access paths with an intermediate pointer to traffic_stat to resolve the 100-column limit. drivers/staging/rtl8723bs/core/rtw_cmd.c | 38 ++++++++++++++---------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index c1185c25ed36..5c6999ac17f6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1106,24 +1106,25 @@ static void collect_traffic_statistics(struct adapter *padapter) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); + struct rtw_traffic_statistics *stat = &pdvobjpriv->traffic_stat; + /* Tx */ - pdvobjpriv->traffic_stat.tx_bytes = padapter->xmitpriv.tx_bytes; - pdvobjpriv->traffic_stat.tx_pkts = padapter->xmitpriv.tx_pkts; - pdvobjpriv->traffic_stat.tx_drop = padapter->xmitpriv.tx_drop; + stat->tx_bytes = padapter->xmitpriv.tx_bytes; + stat->tx_pkts = padapter->xmitpriv.tx_pkts; + stat->tx_drop = padapter->xmitpriv.tx_drop; /* Rx */ - pdvobjpriv->traffic_stat.rx_bytes = padapter->recvpriv.rx_bytes; - pdvobjpriv->traffic_stat.rx_pkts = padapter->recvpriv.rx_pkts; - pdvobjpriv->traffic_stat.rx_drop = padapter->recvpriv.rx_drop; + stat->rx_bytes = padapter->recvpriv.rx_bytes; + stat->rx_pkts = padapter->recvpriv.rx_pkts; + stat->rx_drop = padapter->recvpriv.rx_drop; /* Calculate throughput in last interval */ - pdvobjpriv->traffic_stat.cur_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes - pdvobjpriv->traffic_stat.last_tx_bytes; - pdvobjpriv->traffic_stat.cur_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes - pdvobjpriv->traffic_stat.last_rx_bytes; - pdvobjpriv->traffic_stat.last_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes; - pdvobjpriv->traffic_stat.last_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes; - - pdvobjpriv->traffic_stat.cur_tx_tp = (u32)(pdvobjpriv->traffic_stat.cur_tx_bytes * 8 / 2 / 1024 / 1024); - pdvobjpriv->traffic_stat.cur_rx_tp = (u32)(pdvobjpriv->traffic_stat.cur_rx_bytes * 8 / 2 / 1024 / 1024); + stat->cur_tx_bytes = stat->tx_bytes - stat->last_tx_bytes; + stat->cur_rx_bytes = stat->rx_bytes - stat->last_rx_bytes; + stat->last_tx_bytes = stat->tx_bytes; + stat->last_rx_bytes = stat->rx_bytes; + stat->cur_tx_tp = (u32)(stat->cur_tx_bytes * 8 / 2 / 1024 / 1024); + stat->cur_rx_tp = (u32)(stat->cur_rx_bytes * 8 / 2 / 1024 / 1024); } bool traffic_status_watchdog(struct adapter *padapter, bool from_timer) @@ -1743,7 +1744,11 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf) pdrvextra_cmd = (struct drvextra_cmd_parm *)pbuf; switch (pdrvextra_cmd->ec_id) { - case DYNAMIC_CHK_WK_CID:/* only primary padapter go to this cmd, but execute dynamic_chk_wk_hdl() for two interfaces */ + case DYNAMIC_CHK_WK_CID: + /* + * only primary padapter go to this cmd, but execute + * dynamic_chk_wk_hdl() for two interfaces + */ dynamic_chk_wk_hdl(padapter); break; case POWER_SAVING_CTRL_WK_CID: @@ -1881,7 +1886,10 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd) _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); spin_unlock_bh(&pmlmepriv->scanned_queue.lock); - /* we will set _FW_LINKED when there is one more sat to join us (rtw_stassoc_event_callback) */ + /* + * we will set _FW_LINKED when there is one more sta + * to join us (rtw_stassoc_event_callback) + */ } createbss_cmd_fail: -- 2.53.0