From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD24237BE7F for ; Tue, 12 May 2026 02:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778554623; cv=none; b=TC7feQ4IzRPd78fl+C0NTyvnwvpojfl/nNt+p+fPBPOr99kwvV8jEInsKrW6+3DmdfunAH3zRBQE+myhLkC2pO7fI5jwWk/L6o7CgiQi9jYlS1wsDY6URJzCXCB+/ydYIifePRCem6bd04lKYzKn2ipRcEzKuutzjV+rE6UiTts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778554623; c=relaxed/simple; bh=iAgIKhZeMhfwnNaJoqYXsgwYQ/hRb18subq/jtb9fGU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nJhswtLrl7VzaMfBmyCWO6bRRTWHaB9kHohcZdt3W9SHO2CUh6lObewY1D6V9lz5+FUSxqRZXWNQM6X2WkvxGjCpZ2yYpeM3AokBBIGQ3q0eIoMjgK7HoCYGjTzLQ8v1i8cUYein5jVbjqF0g/lcNhoCmnLtYESs1Aw3EMFr6Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XR7uRrAa; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XR7uRrAa" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-365e70c39d0so6438180a91.0 for ; Mon, 11 May 2026 19:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778554611; x=1779159411; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0TmeEHVbfUCyTIyNuBDod729zIuSuUZz3NFAI/IFw5M=; b=XR7uRrAaeMbzTXUmJNnwk7GsAH29xu9UAX1bAIp1C4StDXWP/Dik/iBHV868rmiJOh t5+QMqGnC1T0q3fu2MFZ+3mmrVfBIqwUjnS9mBvBthkWMnhxJKtxot+nrytY9YrMpGI1 aJwxNiqc5duIG6DuoZ/ZBTKsSx3cdnRvq2dJ+NLIJ1Kbb64Nsig7dv4nseLc88N/DRF4 JaWeQRXQClgvWRE5K0U6MMam+7T/vQTOOXHfpNaQBix7tSoopcdFMW6H4CtxB0mZ2Zmv qudYny+19isumw8L452olvQZvIaVYjy3YxAmmFfWvweFe8s2i2+nuxCS2h4WVAI96W4R Zv7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778554611; x=1779159411; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0TmeEHVbfUCyTIyNuBDod729zIuSuUZz3NFAI/IFw5M=; b=o+84ZopyJmHb4aK6LlniKcJdAVXGL/yH0Wnczv3RyEI8Zem6jSn+SS5VeJFuX0YKop kHSe9C37cF1eC2WnA1C7Mgy+ecUhTEk+0Hb/sAZqSrN8A0Pk5QUmL2j/zoGTLj/wSl2y w9B78yyOgmbRmUyDfX7BwHJDyS0b7sdNWTV4p848KwfkyWnQi8VUniSmJcbpWzvJ673a zNg7GzZyRPtywmrmBf8T1PsEOiXoEY8ekOoqfQTWSubcx/gUQfRk0+WypQT3IIl6hRAv OaW7W+txHwRVFNnKwCxwBqFLo5DO97xD3fzaFieUyetffoSu4HPx/W7Y9jRVxhVbcEpc /PfA== X-Gm-Message-State: AOJu0YxlGDNRgczJNFq/ZDPqdPqifm6c64h8NKl+iueOGyyUuS5Oi1aq qOgLRHjFq+6VZF6wBaMNAigPEMHZtGn14x8W9kCW3HzHeJLDJGK9V+hzgr/Bb92bYKXziUXSHgO veOWgQXg4f4vqVjkx7D4YT1iP/dIRi0Wq8KNrfuZkD8o2Q0wjpaOl+a8T9oaw3sf49Pw2/UmX0C oML3+7JphkagbcOqfw8TYx/N5PlXesyK35/Lo7m3vVyBOWd2Ok X-Received: from plbko7.prod.google.com ([2002:a17:903:7c7:b0:2bd:9a1:9a05]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:988c:b0:2b0:c90f:449d with SMTP id d9443c01a7336-2ba793aec30mr195410885ad.19.1778554610574; Mon, 11 May 2026 19:56:50 -0700 (PDT) Date: Tue, 12 May 2026 02:56:18 +0000 In-Reply-To: <20260512025635.2840817-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260512025635.2840817-1-jstultz@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260512025635.2840817-9-jstultz@google.com> Subject: [PATCH v29 8/9] sched: Break out core of attach_tasks() helper into sched.h From: John Stultz To: LKML Cc: John Stultz , K Prateek Nayak , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , kuyo chang , hupu , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Pull the core of attach_tasks() out into sched.h so it can be used more generically. Suggested-by: K Prateek Nayak Signed-off-by: John Stultz --- Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: K Prateek Nayak Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: kuyo chang Cc: hupu Cc: kernel-team@android.com --- kernel/sched/fair.c | 16 +--------------- kernel/sched/sched.h | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9fb2b2ec1a1ec..7f5a1b4328249 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10047,21 +10047,7 @@ static int detach_tasks(struct lb_env *env) */ static void attach_tasks(struct lb_env *env) { - struct list_head *tasks = &env->tasks; - struct task_struct *p; - struct rq_flags rf; - - rq_lock(env->dst_rq, &rf); - update_rq_clock(env->dst_rq); - - while (!list_empty(tasks)) { - p = list_first_entry(tasks, struct task_struct, se.group_node); - list_del_init(&p->se.group_node); - - attach_task(env->dst_rq, p); - } - - rq_unlock(env->dst_rq, &rf); + __attach_tasks(env->dst_rq, &env->tasks); } #ifdef CONFIG_NO_HZ_COMMON diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index d0f3e164a61d2..e1927e53e85cb 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3045,6 +3045,25 @@ static inline void attach_one_task(struct rq *rq, struct task_struct *p) attach_task(rq, p); } +/* + * __attach_tasks() - attaches a list of tasks (using se.group_node) to + * the new rq + */ +static inline void __attach_tasks(struct rq *rq, struct list_head *tasks) +{ + guard(rq_lock)(rq); + update_rq_clock(rq); + + while (!list_empty(tasks)) { + struct task_struct *p; + + p = list_first_entry(tasks, struct task_struct, se.group_node); + list_del_init(&p->se.group_node); + + attach_task(rq, p); + } +} + #ifdef CONFIG_PREEMPT_RT # define SCHED_NR_MIGRATE_BREAK 8 #else -- 2.54.0.563.g4f69b47b94-goog