From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712573C9ED8; Tue, 12 May 2026 05:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778564300; cv=none; b=fEeLs0R5H6iE8zjntqMcHw2K7fpO3plA2bDvXgTh1enW/RDX+RQ+skUbnRmPc+T+n5MhURB/BUkowcF1dg08q8QGTAsMbBc7UsNjzqlO4RnA/7FKgV8M5g8kC9G3lqWoJUjMlIlOroZrPxCe1+pQY17cD5YtlOx0DZF57q3x8wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778564300; c=relaxed/simple; bh=16fmh/53jLOcSRwr5NGl7E1RhDPXNfW4uNvhC37G5pk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aysuPNQE/g23zROg3/7kV+4jsfjGDaHovi/aGr4ipG8vOycbVj5j/3fJxpFMW7+Rs/QK3e18xBJS/BdtyOoweNSQoHMOQCkA2sriKeTHwhfgKjfLQUWHpMJ9JvvyKtc6X7mryJK5P7oyukpzEhNQ9808m0qppkBdbYGEz1GY37s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FL674Njf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FL674Njf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22FB9C2BCC7; Tue, 12 May 2026 05:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778564299; bh=16fmh/53jLOcSRwr5NGl7E1RhDPXNfW4uNvhC37G5pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FL674Njf+cCxYewyyKqU4rEKKXwczXoyBhO5qkMs9ZRPPuFvkvEk/69CqAVE3xlTs pfulEvd0CCIRdfAjgtFcKmqIK4V/dtRgeaquq2Ge6+N3ptO6wgmPGzBHcW1vIhd+GY 2ArdEPLDpu+Y/ySJOyZlg92+4DuwMEIUUvKJWZCM= Date: Tue, 12 May 2026 07:37:35 +0200 From: Greg Kroah-Hartman To: Chhabilal Dangal Cc: Sudip Mukherjee , Teddy Wang , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] staging: sm750fb: remove unused #include directives Message-ID: <2026051203-slurp-slain-7458@gregkh> References: <20260512044732.56417-1-yogeshdangal66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512044732.56417-1-yogeshdangal66@gmail.com> On Tue, May 12, 2026 at 10:32:31AM +0545, Chhabilal Dangal wrote: > sm750_hw.c includes under #ifdef CONFIG_MTRR, but no > mtrr_add/mtrr_del calls exist in the file; the driver uses > arch_phys_wc_add/arch_phys_wc_del in sm750.c instead. > > sm750_hw.c, sm750_accel.c, and sm750_cursor.c all include > , but none use any platform device APIs. > This is a PCI driver. These are statements that don't really describe anything :( > Remove these dead includes per the TODO item to refine the code > and remove unused code. > > Tested by building the full kernel and module with CONFIG_FB_SM750=m > on x86_64: > make -j$(nproc) > make M=drivers/staging/sm750fb modules You don't need to have these lines, it is assumed you test-built this. > Signed-off-by: Chhabilal Dangal You need a blank line before this line. Also, your patches were not properly connected, please use a tool like git send-email to send them out. Also, you are doing multiple things in this patch, please, only one logical thing per commit. thanks, greg k-h