From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2660E37F744 for ; Tue, 12 May 2026 03:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778555107; cv=none; b=rZsFHk9EH3U7ip/iS/vflf8PbLHp+aeCFmWWOu13NgX/c37AD2iXawmF+pT6AGXxHByxPC/aQjRYdTwHScHh6IJ4glNSN++//llytsDLm1vEmPDFyboWZe8gs+VheTg2MKCenho/NIRvBDtXE9Z4WslrwJIxsDhsNDlN7xsYCD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778555107; c=relaxed/simple; bh=6RssfQ9fqaQKnWyUvEg4cF+yE8dQdz/JKxfZmnJL5g0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WOjHNxuMsKWxBqgYwR33WL2X3g5Gj99E0KKIKbPqA9naRAOQ9kUG2w+6ZEDmB+4n3YDkcFrLVzd9UvmrNGmFiyYVL2k1XEtXrth6Ghr/ndGCIIyhLPRBPSeQuViriMRQhZVh/M3ZiKz9dkd4ffz984N3nbRbd+BtCDFRiP0xm74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DmVVMr8J; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DmVVMr8J" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-13317450f83so1611100c88.0 for ; Mon, 11 May 2026 20:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778555103; x=1779159903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=96eBVfPO2WsqijNQU6Am2kTwmNePUyhezZIteLHJWPw=; b=DmVVMr8JRcZA8HC9N1INqWmzT6zqjDl/t451MSkGLh5b8nRttEBp5FY68wUP2IGiGf nBqzGqTzgxYTOeFMn/zeAT/+ItKMBgKlIcPgGYydvoTBttwjweWTi5Ql66Byfrjv6SPV dJC1TyS0oIUXHDZpS7Hy41w4EIrR3VHrvSCMDZmBKKDtxObhrE10f+xKc2mcIGhkPcsw X0521IQ5N/gfwmdZSm7jDZTVQ3zjI/DACgqw8u0/kPdqiylcalgupP5MgciuhYKSfUxv NkYNNS1uiGylHxkY4VJXeEYf2PgiNV8DkRCQAD/gChL0/vQRJo/TiXd96oQfA3fhjj7W pyFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778555103; x=1779159903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=96eBVfPO2WsqijNQU6Am2kTwmNePUyhezZIteLHJWPw=; b=L+9pwzMPcY6cDFotNlO+CtFifpKvayVfihq2Ek2zcNvNTwIOYhKq7zwiL/BjlN1vDJ 6Lo0WrUfu4LjQAJbvW8cw5Q+BdVTCLH6tUmylbbxUt21vPf1YHX++O/LcuCOMBJN2Wh3 O5ZoBIh9kTQVURBqeVU2A2aLJr8WshgglHBixkt7B7MaekBYYfqNALRg7qDeRF8Z/bOF RzH/9E2LT0bHrLmaPKqtHgAczF+rZ64yIHWM8avbpGh83bzinrdxfYTUzi68PRrT+UCx fpSJuy+OTIFQQBpRwnLyb+Ez5TX9Ov2SNJzPfrDlo6fUkKQ8URbAovqi6RLQw4YwS7Of 2zeA== X-Forwarded-Encrypted: i=1; AFNElJ8k2ENMA1hQSAEZ4qNe/HTQH0ADyyG+yA+Urwd/HNPKEQk4Mibcm8FpVnXsRn795avf1AXNw/idDW8hM7k=@vger.kernel.org X-Gm-Message-State: AOJu0YxU/eHwNWOvW9n9yXCPYbgnEhNNGjm2utGt1EIatDJxZORCXrIw QjTli3BsqOdTmWCuDZTBDZSuvH6Vx21WPIYtPRVOvLBYe1OfVHfLma0s X-Gm-Gg: Acq92OHEzzxCARvH6/inDWN/esNCAdmIBANAaw7pXJ0a4W+dXHeR+883im2BuHu6SyM KTRDXxsfpC4EaGASyl0ydBcLn+frF0FJXYB7rcoAGFHD/6AHQstdp85k/VXZlR9WYJJvZ8wNF7f jX/afo1Qjm/G4rDz8gl8pKbC8rZ+uomSGzEp1jhabKgRxifkZggKom8uVzaepz0ZyXDv/nD2T2M WGy5s7A2Rn/xxN1CX4ePkn6EzcDn0656pRi37pCc6hddL40S+AIusRLBl89of5BsVzMJRiRX/9P GBiPyosNnjRRg2ttTA+BIPtKP5XWe42ViRuoWfPWrFVhjTcX/tSrC9ybkCE30EYwXGOhDhhBp5M cfsjJAwmuSGVvlWa8UGZfbEL6ludR7D+5fQOfvqm1FtWo9yZXbUkk3kPYqkaz4baMLYm0tq3VE+ rwpCDUlxsoPGyHJ3f4xGEywa5c+xKU8r0VBMxkdZPHZpAcWB8aekGRp80= X-Received: by 2002:a05:7301:2b07:b0:2ea:3370:6e51 with SMTP id 5a478bee46e88-2f85bb7309bmr8550296eec.4.1778555102562; Mon, 11 May 2026 20:05:02 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f888e381c9sm15858223eec.26.2026.05.11.20.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 20:05:01 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/2] staging: rtl8723bs: simplify LPS_RF_ON_check control flow Date: Tue, 12 May 2026 03:04:44 +0000 Message-Id: <20260512030445.6360-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260512030445.6360-1-dennylin0707@gmail.com> References: <20260512030445.6360-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace err + break pattern with direct returns to simplify the control flow and improve readability. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 24 ++++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index ca1cb58fc801..7f297f2d2ff4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -389,35 +389,29 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, /* * Return: - *0: Leave OK - *-1: Timeout - *-2: Other error + * 0: Leave OK + * -1: Timeout + * -2: Other error */ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { unsigned long start_time; u8 bAwake = false; - s32 err = 0; start_time = jiffies; while (1) { rtw_hal_get_hwreg(padapter, HW_VAR_FWLPS_RF_ON, &bAwake); if (bAwake) - break; + return 0; - if (padapter->bSurpriseRemoved) { - err = -2; - break; - } + if (padapter->bSurpriseRemoved) + return -2; + + if (jiffies_to_msecs(jiffies - start_time) > delay_ms) + return -1; - if (jiffies_to_msecs(jiffies - start_time) > delay_ms) { - err = -1; - break; - } msleep(1); } - - return err; } /* Description: Enter the leisure power save mode. */ -- 2.34.1