From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F9FA3016FC for ; Tue, 12 May 2026 03:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778555108; cv=none; b=ogquMXYWUK1jloKgoqTlF2run4VB95HikStavFKYBt9nfkvRk7Sf5JTBOojL910UiRtBYTD76NHWMamecin0kzXr0vQCbyM+vAwCmsNNNtxNa5qdN+nMXhKNo6Lt/EO6VyTi4yNX5C9mqLuD5WEL5S9y0UzVDR6Yb7zjscrHgU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778555108; c=relaxed/simple; bh=OjS84fyr1Np8GryesdkwyZdtusIvDqhk9G7atC1y9sw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LA1PGXmSoahmIxXkMzYMZJWJZFFgu5yTBXJsM1OoOKjzTt0ImGF3aLm8l9wMRr+RKdxmCcpln7KWhjVovlTrp54FKJg7UC1OxvwzttaBqTuI1TSno8rPYkorRALZYuWckmVf502LLmsZBSnBnNcpfATPabA84xCvAdMNbEIIODo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eTUEAZPd; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eTUEAZPd" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-2bdcf5970cdso3680089eec.0 for ; Mon, 11 May 2026 20:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778555104; x=1779159904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mwrfpKa7ZrSAnPBOF79N3IhxzqvT+3wAOiHHA54y3cQ=; b=eTUEAZPdUo7bOnIkU9qN9A8yfGX7iHdWXT26XJNpKjbEZ1PIP8fqnJ7Fqc4aJpzbZC altJRq1CA0+rAgQQAGt/mofUM5Wb9yF/gchpYPdZ1Na6tSiqBS3y9UNsteWEolA6Qn3l ccBwrE+gg+RmVhc0tpofTpWkN8aj8aW/f3i8Cl/CMDBcgRpdHqKaBWoO0Y/eXZg4qA30 JU4M4OooAH+Fnh3OtlhrPHlHbdG97ZB5oGJrLy9quw2H4HOlveB+47IXgmd5jKDafsFr 477iJNrtxJEUykmtJbVOuhrX84rg6tHAIWPLNgE2FjVZnXnqgYSrmW76dyp7EXipfJuC AUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778555104; x=1779159904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mwrfpKa7ZrSAnPBOF79N3IhxzqvT+3wAOiHHA54y3cQ=; b=aI8Z4HsWF4nhhi3gjRfZxgViKN9XowAGVHbW2WyvowVndEQaGk73klX+4/8e7gOnmB A5SLKhSoc8qxFGg71C16EFYsI3BNoXiMOcKfksgS1CL+Zi3gBbTk2UbBHBVq5UCLEJBQ C5InDI5y3QfNCKZ1RGbHY33TBqErtIub9HXzjYDkfgsu2ViBEe4jN4HlQB+PE+OB9uwz gjcjGTDj1hC+XP6mPzxaWPUsVFXb4sjSb469iyLrH1ffSm6KzoWJPZuBwb34rYWzqZ41 4yYtwAD57qsvIL+3BDKEfGlb26v3OzAaAij9EASsnfU8vZl/qNMsqG+7gAXJEvLSVapr ljIQ== X-Forwarded-Encrypted: i=1; AFNElJ8lszcCvHmVFx3MvmjpONKBFCevugGyzEsaUPrRxZGikzCAyy7gsp6E0DZQZX9g2ge0R3uaIgwOiOzf1K8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7cKGCYRkCaMapgTqchi3PyDwLMqOKqXKhegEmJrWfSXo0iSZd 0Kzt9b1DXFv9dLu7EOd8F3N/R9olrV6yaQkBLsv8zFaa5m5OZRLh1Iqa X-Gm-Gg: Acq92OHk6Y3HSpg+1CaQfh1R7jnGFp8B01NuxFX3WwAgB5YGHvsbxRu9NIWdqjEoyJP Dh+yPb0GZIPQizJb7xl4ndRVMBDTJ69LZFoocJJhOnKIzeLXHkRiMobmRoZ69pYX+KJhNh6cexk 2tvtE7+TG1NubRWwPWbMsDVBE6vbiCULm80lwv2rqS/3TH/yVvhcSk5EecQH8ks1HoQ28lO8gyd DzjlszLrXNEHI7QPKPF5ez7/8IlK2mNljA2TQ0BX67aCW8fFYVgYdXahAL2hAHUVGx1PO9v8CjU Yxklyfst9/Sm4YwPQTi5JRCeIY1IBUWYwWrEZURvX/JKCoCiwLpoGQ4nNeh7ilDdfY3DOXrMtL2 rr0z+wUWsNFTwCHUnAyU7bdM7Ot6r8w0ch+5CH2+3OLnOpxHMIsJq0PJiDOIAYKqZ3H7MdhRk/a No+YVo5R+fBPn2Gi0a14usjYAIcZ6fjVnuaLbo+5uncMth2dJOYloM6WI= X-Received: by 2002:a05:7301:4591:b0:2ed:e16:6b39 with SMTP id 5a478bee46e88-2ff946e0259mr1090002eec.17.1778555104173; Mon, 11 May 2026 20:05:04 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f888e381c9sm15858223eec.26.2026.05.11.20.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 20:05:03 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 2/2] staging: rtl8723bs: convert LPS_RF_ON_check to errno Date: Tue, 12 May 2026 03:04:45 +0000 Message-Id: <20260512030445.6360-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260512030445.6360-2-dennylin0707@gmail.com> References: <20260512030445.6360-1-dennylin0707@gmail.com> <20260512030445.6360-2-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert LPS_RF_ON_check() to return standard kernel error codes. Replace -1 and -2 with -ETIMEDOUT and -ENODEV respectively. No functional change intended as callers currently ignore the return value. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 10 +++++----- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index 7f297f2d2ff4..b0122eef5c32 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -390,10 +390,10 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, /* * Return: * 0: Leave OK - * -1: Timeout - * -2: Other error + * -ETIMEDOUT: Timeout + * -ENODEV: Other error */ -s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) +int LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { unsigned long start_time; u8 bAwake = false; @@ -405,10 +405,10 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) return 0; if (padapter->bSurpriseRemoved) - return -2; + return -ENODEV; if (jiffies_to_msecs(jiffies - start_time) > delay_ms) - return -1; + return -ETIMEDOUT; msleep(1); } diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index c27d07861b8c..7dc9c4e2dfd2 100644 --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h @@ -233,7 +233,7 @@ int ips_leave(struct adapter *padapter); void rtw_ps_processor(struct adapter *padapter); -s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms); +int LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms); void LPS_Enter(struct adapter *padapter, const char *msg); void LPS_Leave(struct adapter *padapter, const char *msg); void traffic_check_for_leave_lps(struct adapter *padapter, u8 tx, u32 tx_packets); -- 2.34.1