From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D9A30B50D for ; Tue, 12 May 2026 04:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778559132; cv=none; b=s+6dL9+1sDJcXWcsIdJwfEEjrEqVOeyUKvPmxXiCO0EvNyG8ezXiTYKiLdcivRDaGeDMmGjxyXOpMQs7Z3MnEzt3QvGN8hcY5wn2uSTunzFQLq5SFQgrfUCRfVdgZkOhoiPrMw36vr1Nh3VcU7eqej6vfh9V3yzXKmFhzhfyjNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778559132; c=relaxed/simple; bh=d71o6GJ+kZubNzWiM4mqlQWz/y4qngthAy2ag9npHgg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PhGwN8MeKGtDEpE/AZ/ssqOH6epHVcBMhov5Wk8r8UiTlNfJOzVAFx8ACf3x63ZaKX4QyUVzrUhv8vusztJsgJpqvXJeX46JByAPPzWV4tfInRtDJA8ambtPFkP8AUKGg63NH9w1AWNQuGfJ8Pr8Um2NFXdudUH/XtbJ0hiioHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kH+Gip+Y; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kH+Gip+Y" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bcf48850c4so6296645ad.1 for ; Mon, 11 May 2026 21:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778559131; x=1779163931; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PPUpmSjgTJAbeTHDAZfVXaAmUiYjeKJO1WxUBCqQG2M=; b=kH+Gip+YgLMwwZyMbhz56I/TsAMxxk4134Zqbk9FoCtD98IycZU2kbHt3X6MPZmvNz loS/eQWlL5Ei6mEMcbiVpjfG+3/gjFxpd7ssFpZ0scjkRpnqzvsxi9vxwMyW7NfPQB0D G3PjEnh9HHJ8ZrzeqHHeZkhDoJMUk13ihEiSnUy5VaPbdJch+jkzNsvOWagA8kZoJzcs fDH3WlkenIP/CNejN+jXPwGtr9AGKIDVlQWRCvzJbnpRh+WH7TcXPSsDHcwY1rydFXPo RKNFuP9gOFrbM0cJ9SZ1tAHAPrb2iP+8Gks/IitfaeBXsuDW4bwhN95urA4TYWxJ/e4g x0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778559131; x=1779163931; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PPUpmSjgTJAbeTHDAZfVXaAmUiYjeKJO1WxUBCqQG2M=; b=pOcJyOAP1yXtnzZ2xmFpGbXpcz9Y6RhZHzctFFBx3Z6EguXtXVNrPM5Kbaol5ouSZC ItbXnsWKSE3xDbJOouCCLbWpYmcAduDjK+434E5Ieis8yA3i5Fqz8DVFSzX/FVbIZWdZ kD2+pVzBjvCCT801e4pvaESV+2U8Q31zbHbYX8FjeSnZX8n1IpmRtXYbyoVHhRfEG8g6 /gNthOzYN+IlsYfSnYmZjxwTShdaYzSnYri/+doMu9iVO5JtzGvKGU08jyAl3thlXBcf G2pXAM464zB1lIWFJZGZKLwhMLgXJuCznBgnZSPY4sx2kzkb5IdhI6YE4HMB5uM0Xmp6 CTCQ== X-Forwarded-Encrypted: i=1; AFNElJ9sucxUkC1KmTNAGxInTHWwjaAOiosXGiWXkA67G2aHz3rq4iK0Rv1yKzrD0Obnp4uf2fFSSlBa/Ell7eI=@vger.kernel.org X-Gm-Message-State: AOJu0YwOj7Ps/RJxOl/SrvleFGJxVQdUF+81UT2Nj2MMfZtMF56ulZKG 4qwprqn7MqCUOVG4PtbW6KCfhjnhts8g/Cg01Udjzq2M0x6XfTuMqL0d X-Gm-Gg: Acq92OFGdGnmG81Ts5cl7jIG1nPecnbjBnY32vhD46Wh38v1UesnYNZqsFghwy+6v+G nC81CXG4i5pSucZUYfpIMN8lzU5uOEgBoYIIftGEO4Lx/82qjODnmD7c5LSe4sC4UIE+9bMsh12 NiYq2+q7ub9MCAe6tKnUgevWP6/vrc1tqtS3y8H+SEkNez+zTftpH49jRL2t+E0V0j4Bq2vRpfC tyTnhbCSRSz0jNfqFJaRRdqVJjtfD74Lhknl9uoP2C4JhJdAZ/JmUB9thjHWOe6oHb2mIqQhMZl OO2FoLddwfJisCs0CSiGy772+qiMiQG7r/MY00YbUwDZ3TzBfV3escJR+WMqK/qdeqtrQLjqhzd P2cSe7LeZX04yV7i+dh6e+f3gzbTC0TQljz8I4ZJJ7kLUgLsoZUSEm22K2j8ai36zVmbdCuIVud xrMktOEzwhZ86a92buJpBdbl1G54N4rv/Hr8wRvXFN X-Received: by 2002:a17:902:bd47:b0:2b0:6e60:9586 with SMTP id d9443c01a7336-2bd01174247mr10425085ad.17.1778559131150; Mon, 11 May 2026 21:12:11 -0700 (PDT) Received: from vini ([2401:4900:8fc8:73c6:dda6:576b:fa0d:f68e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bc83101ee1sm85082565ad.79.2026.05.11.21.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 21:12:10 -0700 (PDT) From: Vineet Agarwal To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vineet Agarwal Subject: [PATCH] mm/damon/sysfs-schemes: fix double increment of nr_regions Date: Tue, 12 May 2026 09:41:57 +0530 Message-ID: <20260512041157.109845-1-agarwal.vineet2006@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damos_sysfs_populate_region_dir() increments sysfs_regions->nr_regions twice when adding a new region: once explicitly before kobject_init_and_add(), and once again through the post-increment used for the kobject name. As a result, nr_regions no longer matches the actual number of live regions, and region directory names skip numbers (1, 3, 5, ...). Use the already incremented value for naming instead of incrementing nr_regions a second time. Fixes: 66178e4ec30a ("mm/damon/sysfs: use damos_walk() for update_schemes_tried_{bytes,regions}") Signed-off-by: Vineet Agarwal --- mm/damon/sysfs-schemes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 622c3799db87..5d966ac86419 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2998,7 +2998,7 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes, if (kobject_init_and_add(®ion->kobj, &damon_sysfs_scheme_region_ktype, &sysfs_regions->kobj, "%d", - sysfs_regions->nr_regions++)) { + sysfs_regions->nr_regions)) { kobject_put(®ion->kobj); } } -- 2.54.0