From: gregkh <gregkh@linuxfoundation.org>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-staging <linux-staging@lists.linux.dev>
Subject: Re: [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Date: Tue, 12 May 2026 14:16:45 +0200 [thread overview]
Message-ID: <2026051205-shale-tactile-b85e@gregkh> (raw)
In-Reply-To: <19e1c19a323.2dbc56d746976.8507108782933043169@zohomail.in>
On Tue, May 12, 2026 at 05:41:42PM +0530, Ashwin Gundarapu wrote:
>
> >From c981cdc1149e5ae7e5163f80be1631fc11c4b14d Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:38:31 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Why is this in the body?
>
> Remove braces around single statement blocks.
>
> Found by checkpatch.pl --strict
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v8: Fixed double blank lines. One blank line only between statements.
> v7: Added version changelog below the --- line as requested by Greg KH.
> ---
What about v1 - v6?
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index c14b8dbd478b..3d88a3a185d5 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -483,10 +483,10 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
> break;
> }
>
> +
> if (rtw_roam_flags(adapter))
> /* TODO: don't select network in the same ess as oldest if it's new enough*/
>
> -
This is not what you describe above at all :(
prev parent reply other threads:[~2026-05-12 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:11 [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Ashwin Gundarapu
2026-05-12 12:16 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051205-shale-tactile-b85e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxuser509@zohomail.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox