From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f74.google.com (mail-dl1-f74.google.com [74.125.82.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 137ED3C1979 for ; Tue, 12 May 2026 05:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778564186; cv=none; b=Neoqe56x+1oRgDwlCBhGjSbnBoPIEHWKFF0278EfwEicYoMB3aMZZbm9cy31D/gRKR3mJNkFNr/76qV/LzbI2Demi7KimsfvNJAzNrktvwzlUsGsktOBT0+MRbp0D2Bk3x1C03fuWZuwflp0/m17Tx5jVShI5FuHKoqbko+CySc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778564186; c=relaxed/simple; bh=Xs0QKg7ZFGHCgpb39xNtKbutgLWpIgoU5BMBYce+utQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=itY66K3mAdPfN8CooyD0Fcqh4ytiWJhmvAukfZUIP0PZvVEWl4/YQJK7Ll2TRKyhHH+dA3XppNP0kf59b4SUiGktTlXWSzX0dKpWUe6V7jPmkkLpKzeFyMiGmWIjSjcohPDGTK1xnDD+iG3M2OAgA1J7rd+rsyPQXok6J64fctY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Wnrzdy0q; arc=none smtp.client-ip=74.125.82.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Wnrzdy0q" Received: by mail-dl1-f74.google.com with SMTP id a92af1059eb24-13312be8a31so6429698c88.1 for ; Mon, 11 May 2026 22:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778564176; x=1779168976; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sv+fBrgnLHWDPJNXQeJxnE6YmYGegAklGdTMc3S6cgE=; b=Wnrzdy0qyc+MQdZmlZ1AwxNNeuSwkYtnEoK5/I7+m9tVjoCuLVkWqHCizvO/xKof2T KKy17+vf7uwQu8kEbi9hFBKcRV3pbxnCJrRxmtbg963jHL1cP607RPpxxxMyBmAV5/2a F93k0Mp/b0nR72rQqxFg3xo0TSuTAGaRXNaWebixQ3l5okIQhHEAAS6DVbgGrH+jXBa1 C2EJUTPNAnkjMDaHLx66aCgETkBksJestWSFPcY9W4a1zZxSi5MmPWFjbShHrZ+kpEda j7SAJ0pBMMY+wrMrnwJWYWxeClTUKZjVwJOuMNj6vQds2CV0lpXZCbVBNZFUABrFuThY CJJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778564176; x=1779168976; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sv+fBrgnLHWDPJNXQeJxnE6YmYGegAklGdTMc3S6cgE=; b=o4IbnsyVwtA2c5vuPQUM1+am4saLPQzlCHrKauyQq7FFotP0D5Ry80wJnqB26CaQO0 5bJ2UKPi9G2TZuAcnMEMSSZ4A/Dn/pIdNFkLijsNSSRQohBF597Qw9UTTawGZcjojZ0z 1YzYG7wAcm7ogvmS+bCyeq/B/jbNog9aU7ot6I16SfOZZ9k0A3lbFwJYVRbMKqWn5POC ccUD8IJ6/8UMaNzk65t8H127P5tvR1vN2ivixaj1gsYSTC2ziLuz3udLutGnxPnakk41 eo9lvY/8fBN+rLcxwSptcEiOlszAv2Uc9vCfZxr0mvkuqmeIHhqNjmMXxHB4+F23ODmM QTjA== X-Forwarded-Encrypted: i=1; AFNElJ/rChP3Dg8RtbIVKTDYi0YZWfrc+ujKN7C4El8acayHCPnMHRWCVdbH1SSHW+MTBL3QHFAHKypmQ7stsPo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz88LuA8hv0U+N3n2Rv+FPSeI0GfORknnjjtjl00fAgUVLaoiTY XtcdwAqJYzlLUZEW1knsONPI1sypcGL9ee+G5B5jh9687kG5QqZXPaZuUdG3913YHCQjPy90qyH QFzTs90NZDg== X-Received: from dlbuy7.prod.google.com ([2002:a05:7022:1e07:b0:12d:b319:ccc4]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:701b:2219:b0:133:1be4:a357 with SMTP id a92af1059eb24-1331be4a563mr1743979c88.1.1778564175356; Mon, 11 May 2026 22:36:15 -0700 (PDT) Date: Mon, 11 May 2026 22:35:38 -0700 In-Reply-To: <20260512053539.3410189-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260512053539.3410189-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260512053539.3410189-14-irogers@google.com> Subject: [PATCH v1 13/14] perf pmu-events: Parallelize JSON and metric pre-computation in jevents.py From: Ian Rogers To: Quentin Monnet , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Adrian Hunter , James Clark , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nick Terrell , David Sterba , Nathan Chancellor , Tomas Glozar , Dmitrii Dolgov <9erthalion6@gmail.com>, Costa Shulyupin , Alexandre Chartre , Yuzhuo Jing , Leo Yan , Ankur Arora , Markus Mayer , Collin Funk , Howard Chu , Dapeng Mi , Swapnil Sapkal , Thomas Falcon , Ricky Ringler , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Currently, jevents.py parses hundreds of JSON event and metric files sequentially across all CPU architectures during Kbuild startup, taking ~3.3 seconds of pure single-core execution time. Refactor jevents.py to pre-populate its internal JSON AST cache in parallel across all available CPU cores using ProcessPoolExecutor. Configure worker process initializers to guarantee standard event mapping inheritance under spawn multiprocessing semantics, and apply depth filtering to prevent redundant worker tasks. This accelerates jevents.py execution by over 11x (from 3.3s down to ~290ms), fully reclaiming multi-core concurrency during the build generation phase. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- tools/perf/pmu-events/jevents.py | 36 ++++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py index 70a45e62f5d1..eb72c154f946 100755 --- a/tools/perf/pmu-events/jevents.py +++ b/tools/perf/pmu-events/jevents.py @@ -457,8 +457,8 @@ class JsonEvent: return f'{{ { _bcs.offsets[s] } }}, /* {fix_comment(s)} */\n' -@lru_cache(maxsize=None) -def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]: +_json_cache = {} +def _read_json_events_impl(path: str, topic: str) -> Sequence[JsonEvent]: """Read json events from the specified file.""" try: events = json.load(open(path), object_hook=JsonEvent) @@ -474,12 +474,16 @@ def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]: if updates: for event in events: if event.metric_name in updates: - # print(f'Updated {event.metric_name} from\n"{event.metric_expr}"\n' - # f'to\n"{updates[event.metric_name]}"') event.metric_expr = updates[event.metric_name] return events +def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]: + key = (path, topic) + if key not in _json_cache: + _json_cache[key] = _read_json_events_impl(path, topic) + return _json_cache[key] + def preprocess_arch_std_files(archpath: str) -> None: """Read in all architecture standard events.""" global _arch_std_events @@ -1381,6 +1385,10 @@ const char *describe_metricgroup(const char *group) } """) +def _parallel_read_json_events(task: Tuple[str, str]) -> Tuple[str, str, Sequence[JsonEvent]]: + path, topic = task + return path, topic, _read_json_events_impl(path, topic) + def main() -> None: global _args @@ -1459,9 +1467,29 @@ struct pmu_table_entry { raise IOError(f'Missing architecture directory \'{_args.arch}\'') archs.sort() + import concurrent.futures + tasks = [] + def collect_json(parents: Sequence[str], item: os.DirEntry) -> None: + if len(parents) == 0: + return + if item.is_file() and item.name.endswith('.json') and not item.name.endswith('metricgroups.json'): + tasks.append((item.path, get_topic(item.name))) + for arch in archs: arch_path = f'{_args.starting_dir}/{arch}' preprocess_arch_std_files(arch_path) + ftw(arch_path, [], collect_json) + + def _init_worker(std_events: dict) -> None: + global _arch_std_events + _arch_std_events = std_events + + with concurrent.futures.ProcessPoolExecutor(initializer=_init_worker, initargs=(_arch_std_events,)) as executor: + for path, topic, events in executor.map(_parallel_read_json_events, tasks): + _json_cache[(path, topic)] = events + + for arch in archs: + arch_path = f'{_args.starting_dir}/{arch}' ftw(arch_path, [], preprocess_one_file) _bcs.compute() -- 2.54.0.563.g4f69b47b94-goog