From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A98036F919 for ; Tue, 12 May 2026 07:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569333; cv=none; b=nWlPWxMZjbmyYTPu54/4OnCTMOLAT7dv7bB+BfeF1hN0amEgmJUOCcRPClCf8GSEvWp5C00WTh8QXROVbDPAYE9NzOEIdIAx5VASTTchvvBtZWhsWx/+sNTvJk/80piE0I7v0fI83AAV7DGNwnEN4d004qNXa5ROoWHW6Cm/NJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569333; c=relaxed/simple; bh=zt0B7Jo7Lvmb5XTSLfP5bdnMkYALGEm2GSCOl0p8A4E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Sd0tqEjMVoi8OapNaigf6Rr3tk/12tBpqIJtQCUwgEBtQqxZTXjRVjUWSXMfhc9XqbQ12DAiAO/IrgagFNKFxNXYPye33drc3G2+a+3FrFuKaJurqz4HZqsO+rnaE/2i5bJ0laXVDY06nrQbTZCwCTcvXyVJqrxhS1jv+DV4v0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nyMb6y0W; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nyMb6y0W" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b4583f0a1aso33275545ad.3 for ; Tue, 12 May 2026 00:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778569325; x=1779174125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x3qKjhd1X6fafQ8IlizL6dqyB99X77F8kgo/x1i07BU=; b=nyMb6y0WIrb0a/Bke/CvMo/aWn0ReTMevtDlGCp2QmlBfoDmLzTYF51FGtP91poSpg DYeBMIhwnTbuW0EhxUk9x2+aJ1mp/ZIMoX2W533CLHNt43xnQ6X+ggAC7wavvo00CHi2 CTqTo9Okc9ALQ9o8Y78M1xtpgezN/RQPPiPQLEQdBkVMQ43GctduC4oSqYosJ1Vyk7Q3 RRjIlJ+QkE61A/G495Uk0uvQsmzMGQivBMxG+y6S1fQNyB7AVaIrmpGqYf0M7ZEE/phI RZamUgbSPgeR0Z+LeZiMduGgdV+4ti+6cpgMqAkA9kwIykBX20GFgVCCsxE52RXIkImW CAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778569325; x=1779174125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x3qKjhd1X6fafQ8IlizL6dqyB99X77F8kgo/x1i07BU=; b=kKPEC4wVq6z5FwhvCpTs0vNrMKsTJLHWxSswKClYbC4X63/VcLdISyZQh9RvKV7qRK Mz7ZQRydnSw1V65V471E6q1PN8MEXlN7RVi1PLalLrQXGj0p7Ez8Ux0B70EXEIXeIzsQ 8N4GpPuHS1667y3lyRxeHnl3oTvzMS7i2/7oXSOnY/9PH05VhI+z5YI/klco7DBEkwQw APiu/Yo1ZEkKPz00JqZ1srqYkQQbZ7wJLwt8zQPlnlekIMG84b8vViCkWVPmXd15Uox8 vJNOo8KEbbRp3AeMZuh6qbCk618X9WEL9iklksD4Wib1kLpUBh1ON+l+dlg+bN+KVNxX dpOA== X-Forwarded-Encrypted: i=1; AFNElJ/dTQ/b8g4WUeIvNPALZn57YO/iPwFYvksGEJWm8XWmawDL8rLLl4x9oCnUwTd3XyiSOqjNMGzpKGfzaB4=@vger.kernel.org X-Gm-Message-State: AOJu0YxNfwxsu/n7fJqRRlpuWWCICJrnaKQBlLFzdLi0Tc9riKkQqOQu TPouTZCEDXjQW+tfxAap0OoL6638oswukQSS8WywE1lEoF702GtG3UI= X-Gm-Gg: Acq92OEkeMl+efrPfs+HFcFOOaXUjr1peYp5ePH/KgjFyRc2qfeLnHkipR3aYIMt3uV G7/QLx5cv0UoOCuKFnDXQcvwSHM7aISOxJ2rw5zWPqAQW/n8zsIbs92jKE5359Va4Wz9atfM9ZB aiQ6KP1YlqP/5Z6Gycf5QTp/0IhjSI/SPiUOY7Rkjyq7ICNpOBLa73JfqMKHgyyCgm5o/hHLfLS HxgwJ9nhoDOna/ltR3cIYl4/y0myu9yl32BhMDsISapJlZckHntjdBMHLhf129hA+xLGA7RQi2/ rUnvzRyAyzmO/TrA/zNE0JCU8lgUH6Te3XvfyZp2Zv1pSoBKf3iqj5ALF9NMJ51GAnLB1+Qzd1V wpkyeyBxj9L7KyBkST/T3KJimR9QqopPJ1BND0aWpcmAM0tMKqDlkp3JZ2myzZjCve6yOs6JA8G hCuH1PlrZGlTAcekjIPdJjwZzCRjDiSuIKto1pgMbrvdERj7u717B9mO0dIU6P1YTpqAwOVzokO Q== X-Received: by 2002:a17:903:283:b0:2b2:4b4e:e4d2 with SMTP id d9443c01a7336-2bc7a9c7762mr131236155ad.15.1778569324707; Tue, 12 May 2026 00:02:04 -0700 (PDT) Received: from localhost.localdomain ([211.198.234.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d27254sm123293635ad.4.2026.05.12.00.02.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 May 2026 00:02:04 -0700 (PDT) From: Myeonghun Pak To: Tobias Klauser , Greg Kroah-Hartman , Jiri Slaby Cc: Myeonghun Pak , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Ijae Kim Subject: [PATCH v2] serial: altera_jtaguart: handle uart_add_one_port() failures Date: Tue, 12 May 2026 15:56:57 +0900 Message-ID: <20260512065837.79528-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit altera_jtaguart_probe() maps the register window before registering the UART port, but it ignores failures from uart_add_one_port(). If port registration fails, probe still returns success and the mapping remains live until a later remove path that is not part of probe failure cleanup. Return the uart_add_one_port() error and unmap the register window on that failure path. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 5bcd601049c6 ("serial: Add driver for the Altera JTAG UART") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Drop the unnecessary port->membase = NULL assignment. drivers/tty/serial/altera_jtaguart.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c index d47a62d1c9..20f079fe11 100644 --- a/drivers/tty/serial/altera_jtaguart.c +++ b/drivers/tty/serial/altera_jtaguart.c @@ -379,6 +379,7 @@ static int altera_jtaguart_probe(struct platform_device *pdev) struct resource *res_mem; int i = pdev->id; int irq; + int ret; /* -1 emphasizes that the platform must have one port, no .N suffix */ if (i == -1) @@ -418,7 +419,11 @@ static int altera_jtaguart_probe(struct platform_device *pdev) port->flags = UPF_BOOT_AUTOCONF; port->dev = &pdev->dev; - uart_add_one_port(&altera_jtaguart_driver, port); + ret = uart_add_one_port(&altera_jtaguart_driver, port); + if (ret) { + iounmap(port->membase); + return ret; + } return 0; } -- 2.47.1