From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "William A. Kennington III" <william@wkennington.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] i2c: designware: Improve device disable handling
Date: Tue, 12 May 2026 12:27:07 +0200 [thread overview]
Message-ID: <20260512102707.GA84797@black.igk.intel.com> (raw)
In-Reply-To: <20260511-dw-i2c-v5-0-6c382e1b5de6@wkennington.com>
On Mon, May 11, 2026 at 08:06:25PM +0000, William A. Kennington III wrote:
> When the I2C controller attempts a new transaction while the target
> controller is shutting down or restarting, it can lead to bus lockups
> and system bootloops if the hardware enters an inconsistent state.
>
> This patch series addresses this by ensuring that the internal state
> machines are properly cleared when disabling the controller if target
> activity is detected.
>
> Additionally, it adds a shutdown hook that gracefully sets the target
> disable bit before disabling the controller. This guarantees that any
> incoming requests from the controller are immediately NACKed during
> shutdown, preventing the bus from hanging.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
All look good to me,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2026-05-12 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 20:06 [PATCH v5 0/4] i2c: designware: Improve device disable handling William A. Kennington III
2026-05-11 20:06 ` [PATCH v5 1/4] i2c: designware: Introduce shutdown exported function William A. Kennington III
2026-05-11 20:06 ` [PATCH v5 2/4] i2c: designware: Convert PCI driver to use shutdown hook William A. Kennington III
2026-05-11 20:06 ` [PATCH v5 3/4] i2c: designware: Convert platform " William A. Kennington III
2026-05-11 20:06 ` [PATCH v5 4/4] i2c: designware: Handle active target cleanly William A. Kennington III
2026-05-12 10:27 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512102707.GA84797@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox