From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6136B395AE4 for ; Tue, 12 May 2026 10:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581757; cv=none; b=Zi4HXyDnwVhc/iEdR6ht6IZd6YM/KQS7j2xHEOxQRjETi83JsF2FbCjForm8GVMLGuRyU8WagQ5p2emUW+g1ZLiBFC5ns6gYjGI7YbfywMzIbCvpSZsnk0sron1SjFdTEWSc1VTQ4MkK7V1bYE3+vF2rjxuK8WD53mArzoeRGfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581757; c=relaxed/simple; bh=QjMDfvdryRt0S7+FLA/RMBSIWxc6BkIoiKPbgA3WMHo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=czAIdFnmdf2gKVIucRFUgFwCaSLTsDF8OEZjgUQL0rsptHmb8VTZxIIo0nftGVS7lDQpXOjV634OfNOk2DY0sSkhTvjZ9E8u2ysdWZwf9U5qDhlk2F7NPOw1W56EMBuERQhKIeEK2IAM1LDYH9azZ+GRorfnmx1SPWi2DsEXCR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e4RhUgKL; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e4RhUgKL" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bcd730e090so13399505ad.2 for ; Tue, 12 May 2026 03:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778581756; x=1779186556; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y0x0i+gcegzHfZ4KyqltqDvyEBGkthH8obOAct/iNNc=; b=e4RhUgKLCqUaBPcdf1vMZiy4gPNa6gAbhoIw+1WfANThSB2IzY+i0CtyTfXi2s5VlA aCOGsNTbXB5EVnCGRuEIijVaQAexDnt99iHY653aiD03pLaZc6QYFlMt4cl8wc0JBnVE oruTRt4+SPcO0TNRL31SlPDOz/RnHLIApfB67wjtNQpCXDSkJmkV6PsN6Bt5EhlkHHUM 0MbcRfHwysiP8PVTzHWT1jV2XcRZpcLs6kd3RyX9hNS3F4Uf9W8vxHAG6BhfSJ/bH4L5 wopCrc7FTyyho0GnGVopUPBPLRjCDWjGa0pL/G7P6xn8yvbcNsumvugnoGkcdt3hIfkJ u7/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778581756; x=1779186556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y0x0i+gcegzHfZ4KyqltqDvyEBGkthH8obOAct/iNNc=; b=m/JRhLORNvTt+1Ewzd/BwbH1IMVNfq4xulZcAg3EPlZeBi65rn4st5nMPxQJ4JmmDm Mh/WHcX0aUnKBdztqyINGNJg2q35fWtp412mHy/Zw//WpXEdgXcHBh/jstN0GgFvmFpr RWDO0bKZpJeA34qYHPLFQ8Xz9cUwljJUpAbz7WAQ3fqywrHyxkSeFEwKUn8CFGeBzHWo gzscvVxBD70Znu4En+JGzBVQ+qLI/PFgO3Afv6YhGtjrZLWWsKmhFCBMBbGTsXx/wR9t WQHuONgq28jo5xouhFYldV0cNsSoWMetFrccykekBcnE9Dqoy4eEDMDO/qzT6+jXcXHa jFmA== X-Forwarded-Encrypted: i=1; AFNElJ9R1Tdos08n3AGakdUJSbyyNfFvjuXLRExUay/2zhv+Uc+14Llix5cbx6ldd5lsSj9SWpc4HmgXD1yslaA=@vger.kernel.org X-Gm-Message-State: AOJu0YyxMhZWRKRVItbxDvYzMNKlg5doUGqRXB9m9FAno+Rbg2L+2TLf zev5Hax5FUCoHHdyK7Ymh8enX9zGqIgLvi/RVNF+GVqPy2QYHIENs7LB X-Gm-Gg: Acq92OFi4NO3mEmoYAwVxP8dLNB+ECOmHvjafdurz8nkZ8tmsyLxErJ6gJpy9w3VZl3 SZ4CuLKecYoh2rwJ5cUKxhYhK5g5BhDPT4rexRck7XXDe1tQOvvnI0zDwQqKYRrlcMikZlZoeOz r4O4fEnIHeIE5sjs1BRIWC5b2Af87iq8GOwDj6nZ0H2kNKDKW29CWZ5fy6yot1SFbBlEa1pllKp jtMZvRqbtC6L3ymFqe+WsmdOd6cm25E07PtGNzM7RECZxw0Zop5XJK6f2ujFJWGSm8Y9OpYt4eS xCh7KgsPu0O/zh6uZ1L/hEWVGyPA7Lf7EXz+hsd9ghHaImn8ZqDyT9oAmovxoECRfhEN25xessL zujdSoGnHqsaxa74mznwf9OtrqcBdH/GmguQwvQX0fGfLTfDnI4YjFtkEqkIrYvqr/o1V1X8H/+ 2K+3odc2bNWBZ77ozCUAcxYRfldo2Iad4StI79RFc= X-Received: by 2002:a17:902:cec8:b0:2b4:63c8:ce18 with SMTP id d9443c01a7336-2ba794bb379mr309763995ad.12.1778581755727; Tue, 12 May 2026 03:29:15 -0700 (PDT) Received: from zenbook ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e3571dsm129849905ad.42.2026.05.12.03.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 03:29:15 -0700 (PDT) From: Wilfred Mallawa To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Damien Le'Moal , Wilfred Mallawa Subject: [PATCH] nvme/tcp: release socket on sock_alloc_file() failure Date: Tue, 12 May 2026 20:28:32 +1000 Message-ID: <20260512102831.3593121-2-wilfred.opensource@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wilfred Mallawa If sock_alloc_file() fails after a sock_create_kern() in nvme_tcp_alloc_queue(), the socket is not released. Add sock_release() to release the socket if sock_alloc_file() fails. Fixes: e40d4eb84089eae1 ("nvme-tcp: allocate socket file") Signed-off-by: Wilfred Mallawa --- drivers/nvme/host/tcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 8e5421d2e8b9..f4b9d8acc7b1 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -1820,6 +1820,8 @@ static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl, int qid, sock_file = sock_alloc_file(queue->sock, O_CLOEXEC, NULL); if (IS_ERR(sock_file)) { ret = PTR_ERR(sock_file); + sock_release(queue->sock); + queue->sock = NULL; goto err_destroy_mutex; } -- 2.54.0