From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B100838398B for ; Tue, 12 May 2026 10:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581942; cv=none; b=XgKVc+LvZdmvisnrRj+d8lVKriOs8D6wJ0UEE/4cVBr8Ja2GtVqgT4udjW4P6jEHyyBVqkEDZf6YLyqOxfs2Qg6d4dDeIN/nlLW6iUF6ugvkrqsc9J0Hc7ouizp8G//otPatula26MpA4zotE/xpwGatx0xSyS3Aboj3/Pcnnhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581942; c=relaxed/simple; bh=tvp7L1oZJYHVNwIsz78SgXYaRd+6+wYWtLy29bKHyAo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VQNqlX9PJTW+Ha3CUoRrqrfKnbki/G5PAHHC1pW3XQvVsGYknAqBeJoBc2MhOxFTX3Ac1HuxdkkF5KhC+RRqKRzf9nU5ZAxzstIrW041V300okh/6QLC0bmcYQiCxieCSxdnSHMfo+RXA94SYTB1a/UCRjOKoPN9xOlJFyXPlRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dZKiwpw3; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dZKiwpw3" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-835378dc7cdso478450b3a.1 for ; Tue, 12 May 2026 03:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778581940; x=1779186740; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OhehjUWhhndTO+aLTrKXJGjjblaTc3IzZAO9VvBbULE=; b=dZKiwpw3r4leLnSC1x206+V5c7JXBoxEn5ABGWOOh482bGr/cjtjOXuiqNhz3Ehrha 512Bbpzk3eEUUHu8bMbB2xdB24J/XP63/+nmu8rVCS8eOmEI4d81tBQ6SFh+1cWBmrKl iR/hHgF8EL2TPRKWwknvh9gh709aCW5/efs6JY7rgYMgM4bWbPHUkFAFNcuX11CubkqN IRo9hYLa+IwzrIo7pUpGUUGl+32wHgL8uS1xYZzDQGrghXqEdCcoJIq/6yiIQdecyJaB ASDK1wcDeWqFC2TTkFDK9L5hFsIdP7FnbrhhOlM0CfTgFcLUXPm7B21Ua2A5p0X7JFV1 vKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778581940; x=1779186740; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OhehjUWhhndTO+aLTrKXJGjjblaTc3IzZAO9VvBbULE=; b=FX8enG3rzMNv9kE2NXpAwmsOK+KgCqs8LRDxNRAMUZlfd627PQQNfjhQkPs4893aQC m2k3XLEYQkSUYDewvA0f5zxp/d53XNd7WQknRZtMCXcKCyItLEITCfyJPxSvRNUZeK5G 2o8eKP66J3w5i/GBDlvpbo0huWFjUnQ18EL5guvHbhDoZ2i4cF08FDtP0tgmgpKMv9eJ IUz/2UhvfQZcofyX03UQ0JHB8BG2ytZkIKiOJMT8IuRD1I3HotZb2jUXH5XFrispQPkW uLfkOnqjIa6ggfTR4xFG79hVCaOhaHa+F6N1PG5KmOatyQp4hKuqLXmz6xC8ZBizjeGk feUQ== X-Forwarded-Encrypted: i=1; AFNElJ8AjgpmcIqDT+hd4QqSXrSwH4t5zHlAMyUR4Id94q/PZi/zxi4FNMOhwSCuRyVlZN3Jl5nCbYVhvg6Pxts=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9Rhn3wOcM+81LDlo2mtnPWqY+LgNp7IfLSFl52Xtcq48ElvD6 xnvDU2S7MagiZAVoE/SFKSpJ/dc8Pg9HEB9FbSLXbuBbQf/3XdtVs5Gf X-Gm-Gg: Acq92OFGXeUt5ZEcGZjbU/e+6E1oEmkt/nScO68xYGPyZ5u2WTaCMJLilao29DL8ODg 0UX4RVZAE9FSM3NAwMP7IPf62Mt3WjLzMrXOKxjWWoSA0hvcn3W5TXMAcqeLXGj9rVzXyI0nJIH d4ckyCL6Xy4YKkH6gnTP1ORus2nKObcPT2J6jXmfZ9PH7mMK5IP2RhoAPsekUM7IdVJGqm8qojx YceLEMBBXnSsBFOpkjDMeO5pnY08ATPp3wHhUTvDvIghb0LimJ78w2zGTwkeLTkB5UqDGPSKKnv LA4f4bT3E08x/B9HzXGd3M4OjwHjGM2TeH3MUn219+vVB1axQTAqjCzAyLejgXzbGQ5Kq+vICyu Aylgs97OhoFwU0NaAlvE8CCR35WleLCerli2kEBmh9hMUNpuAYOCRrA0r9BRKZEazAyrkM3nqB+ d/szTEdvGYgzkWP3ywRfWlIcv3HEEJa7ITb4cwRQqkHp+EG2EjuHA= X-Received: by 2002:a05:6a00:4088:b0:835:36f2:7332 with SMTP id d2e1a72fcca58-83a5aaf7775mr15856894b3a.2.1778581939943; Tue, 12 May 2026 03:32:19 -0700 (PDT) Received: from fedora.izzigo.tv (45.62.127.193.16clouds.com. [45.62.127.193]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839679c8462sm23025473b3a.38.2026.05.12.03.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 03:32:19 -0700 (PDT) From: Frank Zhang To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: detlev.casanova@collabora.com, cristian.ciocaltea@collabora.com, daniels@collabora.com, dmitry.baryshkov@oss.qualcomm.com, heiko@sntech.de, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v4] drm/bridge: dw-hdmi-qp: Guard clear_audio_infoframe when PHY is down Date: Tue, 12 May 2026 18:31:53 +0800 Message-ID: <20260512103153.8861-1-rmxpzlb@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following panic was observed during system reboot: Kernel panic - not syncing: Asynchronous SError Interrupt CPU: 6 UID: 1000 PID: 2348 Comm: pipewire ... 7.0.5+ #4 PREEMPT(full) Call trace: ... regmap_update_bits_base+0x70/0xa8 dw_hdmi_qp_bridge_clear_audio_infoframe+0x3c/0x58 [dw_hdmi_qp] drm_bridge_connector_clear_audio_infoframe+0x2c/0x48 [drm_display_helper] ... dw_hdmi_qp_audio_disable+0x28/0xa8 [dw_hdmi_qp] drm_bridge_connector_audio_shutdown+0x38/0x68 [drm_display_helper] drm_connector_hdmi_audio_shutdown+0x28/0x40 [drm_display_helper] hdmi_codec_shutdown+0x60/0x90 [snd_soc_hdmi_codec] ... snd_pcm_release_substream+0xcc/0x120 [snd_pcm] snd_pcm_release+0x4c/0xc0 [snd_pcm] ... The root cause is pipewire tries to close the HDMI audio device after atomic_disable(), which sets tmds_char_rate to 0 and disables the PHY. In this case, dw_hdmi_qp_audio_disable() will call dw_hdmi_qp_bridge_clear_audio_infoframe(), accessing register without checking tmds_char_rate. Add a tmds_char_rate guard in dw_hdmi_qp_bridge_clear_audio_infoframe(). Decouple write_audio_infoframe from clear_audio_infoframe to avoid the redundant check in the write path. Add PKTSCHED_AMD_TX_EN to the clear mask to keep the enable/disable balance. Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp") Cc: stable@vger.kernel.org Signed-off-by: Frank Zhang --- Changes in v2: - Move drm_atomic_helper_connector_hdmi_clear_audio_infoframe() inside the if (hdmi->tmds_char_rate) of dw_hdmi_qp_audio_disable(). - Link to v1: https://lore.kernel.org/all/20260416093150.13853-1-rmxpzlb@gmail.com/ Changes in v3: - Add a tmds_char_rate guard in clear_audio_infoframe path. - Decouple write_audio_infoframe from clear_audio_infoframe. - Balance the PKTSCHED_AMD_TX_EN bit enable/disable. - Link to v2: https://lore.kernel.org/all/20260418101936.7731-1-rmxpzlb@gmail.com/ Changes in v4: - Update panic stack on 7.0.5 - Link to v3: https://lore.kernel.org/all/20260423081514.15444-1-rmxpzlb@gmail.com/ --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index d649a1cf07f5..1c18f8650fcd 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -886,11 +886,11 @@ static int dw_hdmi_qp_bridge_clear_audio_infoframe(struct drm_bridge *bridge) { struct dw_hdmi_qp *hdmi = bridge->driver_private; - dw_hdmi_qp_mod(hdmi, 0, - PKTSCHED_ACR_TX_EN | - PKTSCHED_AUDS_TX_EN | - PKTSCHED_AUDI_TX_EN, - PKTSCHED_PKT_EN); + if (hdmi->tmds_char_rate) + dw_hdmi_qp_mod(hdmi, 0, + PKTSCHED_ACR_TX_EN | PKTSCHED_AMD_TX_EN | + PKTSCHED_AUDS_TX_EN | PKTSCHED_AUDI_TX_EN, + PKTSCHED_PKT_EN); return 0; } @@ -989,7 +989,10 @@ static int dw_hdmi_qp_bridge_write_audio_infoframe(struct drm_bridge *bridge, { struct dw_hdmi_qp *hdmi = bridge->driver_private; - dw_hdmi_qp_bridge_clear_audio_infoframe(bridge); + dw_hdmi_qp_mod(hdmi, 0, + PKTSCHED_ACR_TX_EN | PKTSCHED_AMD_TX_EN | + PKTSCHED_AUDS_TX_EN | PKTSCHED_AUDI_TX_EN, + PKTSCHED_PKT_EN); /* * AUDI_CONTENTS0: { RSV, HB2, HB1, RSV } -- 2.54.0