From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C10A3839AE for ; Tue, 12 May 2026 10:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778582535; cv=none; b=tIH2/hr7wEv9JyInwPWSFNxFwEPYMHeHTgAbFh/Bz3SQ6GG4I60oSFnOPUSJ7sEj23eBZt8L3cuHSVi9mtWEnTm2SUN0VdI4yYk2GUz7dJVmrNkz+gbAqEfR9bCKCvzxKhPY1qHPcNyCT/VQYk73S/H9csDu0ul85FNADmQZAk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778582535; c=relaxed/simple; bh=9LJZFV0jW021j4yZVWqpJ1kgIvrdohtlQqsGPSbnGn4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-type; b=QR5ORCbBxSaheAMAOQo9SuwDTdKkhUgYxRmC2sMiC8p++W29PRL/+QEYyQeCL3FMIXjpu7cTnwpc+s90ZzVooyCbORZvW+LWRwCA0LVC+TAxbK+hwTkqDX+oHd+lXL1Abds5slc0k6dFV+0rqjr2TgBEt70Xouqv/J0LQvSKHsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qH0KX4/d; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qH0KX4/d" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778582529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g2ehNE9gEwYk4+HkxtBJsq7JvVMi5mWHz3WbHgieBuE=; b=qH0KX4/dVPYp0SDCd6fI+E7z3Cx36QoMUdvchPbgNe+4oVHL0nFqetofyklMwfDxZEFL1c 9AzxSYvPDdu72zP97BNr3Ab7pSmy+93c86ruQ75m/ow5z9Tf7M1GkzErckZbn+Bnvu8Nw9 1ZMuYAOiuHUOhEny9gwUsWYuONagvJc= From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, chrisl@kernel.org, usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH v6 0/3] mm/swap: use swap_ops to register swap device's methods Date: Tue, 12 May 2026 18:41:58 +0800 Message-ID: <20260512104201.716213-1-baoquan.he@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This can simplify the code logic and benefit any new type of swap device added later. And also do renaming in this patchset: ------- file renaming: --- mm/page_io.c to mm/swap_io.c function renaming: --- swap_writepage_* to swap_write_folio_* in file mm/swap_io.c Changlog: === -v6: * Fix a code bug Kairui found out when reviewing patch in mm/swapfile.c in patch 2/3. Has fixed it by moving it to appropriate place and add comment to explain. -v5: * Change the return value of init_swap_ops() as -EINVAL as per Chris's suggestion and adjust its invocation in swapon() accordingly. * Add Chris and Usama's Ack tags. -v4: * Fix a typo opeations -> operations * Fix a code bug inside init_swap_ops(). I was taking a change at the time, thought the change is trivial, so I only compiled but didn't run kernel to test in v3. Now fix it and test passed. Thanaks to Usama for catching the above two issues. -v3: * Rename setup_swap_ops() to init_swap_ops() which reflect the function behaviour a little better * Check if sis->ops, sis->ops->read_folio and sis->ops->write_folio is NULL in init_swap_ops(), but not spread them where they are called. And once the checking failed, fail swapon immediately. This is suggested by Chris. * Call init_swap_ops() before setup_swap_extents() invocation. This doesn't harm anything and can benefit later adding sis->ops->swap_activate method. -v2: * lots of cleanup for patch 2/3: renaming, moving data structures, and using const properly * collected tags from Kairui, Nhat and Barry -v1: https://lore.kernel.org/linux-mm/20260302104016.163542-1-bhe@redhat.com/ Baoquan He (3): mm/swap: rename mm/page_io.c to mm/swap_io.c mm/swap: use swap_ops to register swap device's methods mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* MAINTAINERS | 2 +- include/linux/swap.h | 2 + mm/Makefile | 2 +- mm/swap.h | 12 ++++- mm/{page_io.c => swap_io.c} | 104 ++++++++++++++++++++---------------- mm/swapfile.c | 9 ++++ mm/zswap.c | 2 +- 7 files changed, 83 insertions(+), 50 deletions(-) rename mm/{page_io.c => swap_io.c} (90%) -- 2.52.0