From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC9BD399346 for ; Tue, 12 May 2026 08:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576297; cv=none; b=MdglVItWq3hID4sBrNePOjEaTU8CGtxSIARxFYhdcGA8n98i0npESXlpB6VVDDkuSj3FfHnqHFG/rri11BhlGJfjc86wz118K2btgeyJL8RLjJLvLsbq7NMHDI1dS9mwEfUQow2VxCtTk0gcMDBkWWKxySFXn4Ld/eZbnoWTAY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576297; c=relaxed/simple; bh=MCfrd6jW5ODBYkMsqF2MPDg4H/ZD53Xrz9h2ds4XocU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lehqit/vklQLn0e0NAuneu8f89geLVveJlJNvMYww5FkCql7FGihIlnnAUCXYZK8IpsMHlOWHQHScMlfbSo63dshwfLr4ptp376FpNJFus/zGjUNTEJTytXE09ZnK4qTe/Zc5OMU8VIfyqONYZlAyVTua7ccFornBYVgKmUeA9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=Xifc/s0C; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="Xifc/s0C" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-39397d63804so60590641fa.2 for ; Tue, 12 May 2026 01:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1778576289; x=1779181089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TDcJjfwRuaogDZZ2iYpIm3E8oXXRYqH8FZMjLowrT7w=; b=Xifc/s0CGDv9zzDQMr18OM6c13PUwynH0XUDKP0knK8WLFRwsCtgR50ub2OI5xEviC iBrP6Qkforw7mVJxSLDpv1WjYkSOy/z/FR+zIKVu1SDFk49SiDMpdR/RZwY+iyX9wZ+6 lJuRRlhHOMLRtdjVwyqz8E1R0lnIJn0C7doqwS/sC9ophx58nX+CNWqafwns0xlUOcUy uSsLCZ4zxcZx2Z+Dve5gFM2GJYs3B2iwx7e1U3BGLzf/yeMbFGw0r5K998bgv/kYFXIP YYluGhk428jEhs8tvvH0vsy1fhWnb7ru8o+c2dKAk7ZtRs64lgLzt1zNjMXL8Yb2z2Rq JfEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778576289; x=1779181089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TDcJjfwRuaogDZZ2iYpIm3E8oXXRYqH8FZMjLowrT7w=; b=OAO5HVoCYOhMGVdtTBldan98AvjNE/zO7zosXLPIwaYswMpLKaylLUXHCdLSv79MQW CmJlgq734OKpJL9o+VNVe3TmnmZZBKzLAqjq5kBXP3I8fQlwwvtCc6BEJzAFz15+9g2v iL6xipy5sGjyQplZFrwZohCvT/9ys/71Sd23IWG0IjuGcwBta6CFd6NVgwJ1DXYhG6Ke LV4H1jt3lBo5eC84I41gKV73DxfnExKR0809zejle1xVGXuaThksnSyhATpBTT2c6NYv UNSeTzwiJyNS4Nr2EJfz29caRuAtNNo08vHYcv7TndjGgNc1kI38FJE8F1HNMVl4/oZA rDLQ== X-Forwarded-Encrypted: i=1; AFNElJ9LcCKsdFV6oxidbxvBVLGgHp/SmInqLu6soNkfboqpNExyQmO+hekys/lqiyFgmD5UCD8b/phKKc6s7f8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0IfEOgl1h6hGcvj9TGzKo0v9fi+EPgq75VAL7Oo96ymMNj7OM 1zURXXjKYenZ0QZGAHS5N5Xny689+IYj8cvNeqQQfQwLfJiVDDGigZw8GiOQMJle+C8= X-Gm-Gg: Acq92OE/xjnJ8g7fxJQSkKDooBSFGW0u4XjJGHCM52YFz1dq+f4mv8TB0Qu7ZaZpi3u s+nBc0Qi1MNsRnFScYBhRkE/+FnWabgAdL5qmNIvj+RffGKgYJqBT8A/QqtKO5O8RZiCp7JUffX W/2xsKZ2/Cx+2TEaHs17weTiMteCJmiDaUudhWT8euBr+sauk4FbMu/7YDqutPlrbCaSMVAloBQ G9m0VysKzCEWM29W0xCpd1LO1OFhUT93Mfw9bDyJTuC90aSwF6akJeU6D1O4QzhronI555ylB8U xX3G4GYAPdnORHS1MHx5GFe7ICOXa8BqTfys1X+vnYRWQ2keBMG1lCOgZB5zyxmBKFq5RhXEK21 9BTpWbOFjoxaYcteIbm4OW5CuBm5WOOcMq14HwEq3ONnekL/Iy6RYSJDKn49am9tQJdRAio+vmV H5jNNtjF5pjpGry/1akx56fLkOWppuayZMV4s6+lmu15CJRv/LVM8= X-Received: by 2002:a2e:a546:0:b0:394:987:945e with SMTP id 38308e7fff4ca-39409879746mr41452291fa.1.1778576289113; Tue, 12 May 2026 01:58:09 -0700 (PDT) Received: from stephen-xps.local ([62.119.255.230]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393f5f18cf5sm32928361fa.2.2026.05.12.01.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 01:58:08 -0700 (PDT) Date: Tue, 12 May 2026 10:58:05 +0200 From: Stephen Hemminger To: netdev@vger.kernel.org Cc: jhs@mojatatu.com, Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next v5 5/5] net/sched: netem: add per-impairment extended statistics Message-ID: <20260512105805.1dfe97b0@stephen-xps.local> In-Reply-To: <20260509171123.307549-6-stephen@networkplumber.org> References: <20260509171123.307549-1-stephen@networkplumber.org> <20260509171123.307549-6-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 9 May 2026 10:03:26 -0700 Stephen Hemminger wrote: > unters for each impairment netem applies (delay, loss, > ECN marking, corruption, duplication, reordering) and for skb > allocation failures during enqueue. Exposed through TCA_STATS_APP > as struct tc_netem_xstats. > > Counters increment when an impairment is occurs, independent of later > events that may mask its on-wire effect. Added allocation_errors > (similar to sch_fq) to account for when impairment could not be > applied due to memory pressure, etc. > > Signed-off-by: Stephen Hemminger > --- > > Note to reviewers. The READ_ONCE/WRITE_ONCE pattern is to > align with upcoming changes removing qdisc_lock. > For some reason current AI prompts are obsessed with complaining > about 64 bit torn read/write on these, since the counters are > informational only, any such complaints are false positive. The automated review comments on this patch are false positives. Unfortunately, the review automation doesn't look at precedents in other qdisc like RED, FQ, ...