From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0440437DAB5 for ; Tue, 12 May 2026 12:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590031; cv=none; b=qx+6+2ZCeL93qLcbV5B6/3B1D6aNz1PfWUGznKIoQzd9oUsqWTLDTeG85kpucLIEx07Hx8qHfVpe9y1TdVS8hGfmSgTUOdneNLbzxw7/ZDT2TheZQmq0UL1wEkm/3u9nGl9Un4Gx3/Ev7urbHf/a/9j1LmKz2SNQ9JHgw/zvG4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590031; c=relaxed/simple; bh=PuUPcY5OMP5K1cBvSCks6HMg6sUOyK2ya4wyaOSaxoY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D8ND+n0JkiDNCXonmbZVLfBSolYJo/MUrtW7RkWGLbEENpmCL+SAB1Fw7nR7neLFVoaMRZA7atCtEXDjHV8BTspaHK6Ty+gXwClgVvkAqFzUbagdFivcpZDt1u12mKBBtOxDoHFJMD7/kEq4vZjZoMI0+y6Gl5kgpnoRp9F2bPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pPhXqQ3W; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pPhXqQ3W" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778590023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=72v+6i2aPLMGvDKwXeJqu+cc9p2Lr8lwtpXy1lG7xAU=; b=pPhXqQ3WRZQsQ+IXVUCvsIRUCu6cSntT1iPGWLvprR0ATjHe+v+VKaZPIxw5pe0vs7amlt GV4V+svnb1wVJQQRxlPzSJblrcd/0hqePjSRaBSLucskfNyQgVXEj/gwdyG8p0Cqt8JhTw sFB///z5vqEzrOBXj+exvRxFQ+uQUDo= From: Thorsten Blum To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Conor Dooley , Nam Cao , Kuan-Wei Chiu , Klara Modin , Han Gao , Pu Lehui Cc: Thorsten Blum , Alexandre Ghiti , Yu-Chun Lin , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: propagate insert_resource result from add_resource Date: Tue, 12 May 2026 14:46:28 +0200 Message-ID: <20260512124628.300360-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1072; i=thorsten.blum@linux.dev; h=from:subject; bh=PuUPcY5OMP5K1cBvSCks6HMg6sUOyK2ya4wyaOSaxoY=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFnMiipeapZrIzTd2803hBXukQhZcMpgkdanvV12StYmD HJXxUw7SlkYxLgYZMUUWR7M+jHDt7SmcpNJxE6YOaxMIEMYuDgFYCJXwhn+Kc9ZN0EjVMXgVPLU hg+1u69L8Uxi7Fmf+CK+/YSAQ8fDowz/s3/W/9kl++47N//rN0GXYpr/MxcJ6L/r4ZbZ+0iv9OQ qNgA= X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Currently, add_resource() returns 1 on success, even though its callers only check for negative values. Instead, propagate the insert_resource() result from add_resource() to align with standard kernel return-value conventions (0 on success, negative errno on failure). Signed-off-by: Thorsten Blum --- arch/riscv/kernel/setup.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c index c89cc272440b..6e3d8acae71a 100644 --- a/arch/riscv/kernel/setup.c +++ b/arch/riscv/kernel/setup.c @@ -71,16 +71,14 @@ static struct resource *standard_resources; static int __init add_resource(struct resource *parent, struct resource *res) { - int ret = 0; + int ret; ret = insert_resource(parent, res); - if (ret < 0) { + if (ret < 0) pr_err("Failed to add a %s resource at %llx\n", res->name, (unsigned long long) res->start); - return ret; - } - return 1; + return ret; } static int __init add_kernel_resources(void)