From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF0C383986 for ; Tue, 12 May 2026 13:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592169; cv=none; b=teqJa3od+amv7Oxg//W9LaiQqKMoOf/Zfw5wr1EwqSS3tf3Vvw36T4gpwbcjWzGd0hvhFt/XY/Jhs6v0cbap+55Q8OwMiyw9cvBrLVPodsQYzy4kcMK4uDBamYP8W4dEQjTlAYuQcFVUxGsTzkrVNZ22w/kb1CPQVQEkxOXN5gU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592169; c=relaxed/simple; bh=tUiX1FT6aSC1ohF8JSrt4KlsfpJ4FMfCX75a7xBnWxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZV/28wXAqaJOwRkcoBZdzZcwRO71NDWYEWdC6mz5HywK6mQGA3+2Whwh3L+JLRAY2U31D/Akq/56+wlKbyt+J6lk5nUGj+qULZnyWDCg3ispCirpWO6RXmSIHmqqKJb2dAQ8gdWRCzfEoqLfGPBxl12Lz7QNlVcHK/8nsKCFJWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bnpSsEes; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yp8CV62b; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bnpSsEes"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yp8CV62b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778592167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aHVYCXjf4x686H2N50v76tG96sCBSr2lERtEog8vZYE=; b=bnpSsEesN1YjmWdvqbUTc71NYabjz+ETZV8drtrFAf98GpeRe4Tg8kBoRLF5Q3fkFRq5U7 O5+KIQ6uPrehYb5WZVHa7YNIHqBWemvG0XzJZJ5n5+bH46t80nfr2jJk+7EgE8gsVKWg/r +CWpmnsqcp5fXDc3Br9b/aMsbN24Pyo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15--gMrjlFlPjmoGzG2VD6lOg-1; Tue, 12 May 2026 09:22:46 -0400 X-MC-Unique: -gMrjlFlPjmoGzG2VD6lOg-1 X-Mimecast-MFC-AGG-ID: -gMrjlFlPjmoGzG2VD6lOg_1778592165 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48fb4ffebe7so404865e9.0 for ; Tue, 12 May 2026 06:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778592164; x=1779196964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aHVYCXjf4x686H2N50v76tG96sCBSr2lERtEog8vZYE=; b=Yp8CV62bNzygOKr24EczfgWzj6wJzraYbSbA8GSWRf6wZoftU3AfQ0EUjKzDGpg6Eq OEcYyZs2r95KwtHOj78oM2iInQI38mZ/iZa41KDy8OvFr+Ii5I9DuhrPJVYw4x7AskGN ccecpbyZISyKgjyFfSiIO+inCPJInFBADOmFvCI88L+7siTcxCe1+uIU2TdqtXFtDR5B Q7jSjZOsvLU2doq7SSP7S1kQQSLw5U1FRC78uVx/1Q19Yn8Zz+9Abs8qt7l93C4gG4mP aA7n+d2xKDOsqf7Mx5ETU7ntYEawW3tCpEI8eU+0KryZmfA11kq7xMLG8VqLV+zszEuZ D+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778592164; x=1779196964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aHVYCXjf4x686H2N50v76tG96sCBSr2lERtEog8vZYE=; b=qzWWjyxZOu/czIaLtgzZsmSUSjiFij0yTNSk1SA1TIBEE5TEqg8dWglj6e1pQGw/Hm hT7kXaZnKSncvt53ZfywjyJrSviBqeTbzXk2ZwVZisT8iVV3cCOkrosZm6L8lNxMxKyB ByTpsGaC7NJtEz29G4qGedYj5FMQBnFqbmpj4H9420pc9d/cumE1+jYMDsHG4V4fEUW4 R8juxsPtWycamGPbMs7G1vLUx8Cc9tv//e8OphNSfPI58GxgVPAzhh4adRSmur5xsYbo 5RiLN9K914374CQr/pjJffeqvNkygq5D9sxS1XJ8ENwrIZYwkiCk/GbW8OShuUGnm3y3 Shpw== X-Gm-Message-State: AOJu0YzSCo4K9liiVf7q7kxbzFdC0NzmdO8Eieu4FJNERKKOa/guf/u3 zt7N8kDO2kBYxWHWol0HA6Ozl3McnNdRNbCxypUJgVlei/BwQ9RTT7JmO3+xpt5MSOERpuCaIop E1y7iVeRz75fW6ibMBE25XY1IR0EaNFo35/3aN/FwNyr4LiaIDx8hDa63bzFCVG0z7fj0ajEOyY 6v3lmdXusb0/1Mn8uAU9Pix2lu0K8YMjGX5OkSWeDy3uVXQ17GJk0= X-Gm-Gg: Acq92OEpEZ+GeoRh1eCCr90H+XM4O0QuRKkvtzMC1VS+ylc8rglPaTNBr0VEVo4daiY ilvFUYmSnrflyXbbeF9TcXsqVLpEtFFu3EghoKNr9HB9VMu2dlvWdv/W3DMjQk8gmWQhiI/n5++ kKalEy/s/ZCh7SkNabPwMlBx9+/y0GuBvDcmMEQUpFXMtrO1a+MPHpesmZMxMZagTK7QmbmS3Vp yNsRlyrd1wDoQ5zYUnFGeC35C3cQZXZkgL9qP3zczgSIZ4lbH5d0kFa6Ci5hhs9s/TIBoAn9l89 pwc5dBJBFDFiYOlOWFN1znryjjnakWxQ3JxWYm8N1FWGg0PoMxQlvLyarJWia15Kipj0McZjwm/ kgNesG6qQV/dzvPgEZRudXiXN0cUGaF4uFyoUp/q7X561Ni8= X-Received: by 2002:a05:600c:8b6b:b0:48a:7f90:2231 with SMTP id 5b1f17b1804b1-48e8fe7c959mr44713345e9.19.1778592164040; Tue, 12 May 2026 06:22:44 -0700 (PDT) X-Received: by 2002:a05:600c:8b6b:b0:48a:7f90:2231 with SMTP id 5b1f17b1804b1-48e8fe7c959mr44711945e9.19.1778592162795; Tue, 12 May 2026 06:22:42 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f442129sm17673625e9.28.2026.05.12.06.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 06:22:40 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 1/2] drm/bridge: ite-it66121: Set TX mode in the .atomic_enable callback Date: Tue, 12 May 2026 15:22:15 +0200 Message-ID: <20260512132232.333654-2-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512132232.333654-1-javierm@redhat.com> References: <20260512132232.333654-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HDMI transmission mode set and AVI infoframes enable are done in the .mode_set callback, but it is more correct to do this in .atomic_enable. Because the information about the sink type is in the struct drm_connector display_info.is_hdmi and this might not be available when the .mode_set callback is executed. Currently the driver is not checking display info to determine whether the mode has to be set to HDMI or DVI, but this is a bug that will be fixed by a follow-up change. Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/bridge/ite-it66121.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 19a027d75b61..648ca50712df 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -669,6 +669,22 @@ static int it66121_set_mute(struct it66121_ctx *ctx, bool mute) IT66121_PKT_GEN_CTRL_ON | IT66121_PKT_GEN_CTRL_RPT); } +static void it66121_set_tx_mode(struct it66121_ctx *ctx) +{ + mutex_lock(&ctx->lock); + + /* Enable AVI infoframe */ + if (regmap_write(ctx->regmap, IT66121_AVI_INFO_PKT_REG, + IT66121_AVI_INFO_PKT_ON | IT66121_AVI_INFO_PKT_RPT)) + goto unlock; + + /* Set TX mode to HDMI */ + regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_HDMI); + +unlock: + mutex_unlock(&ctx->lock); +} + #define MAX_OUTPUT_SEL_FORMATS 1 static u32 *it66121_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, @@ -729,6 +745,8 @@ static void it66121_bridge_enable(struct drm_bridge *bridge, ctx->connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); it66121_set_mute(ctx, false); + + it66121_set_tx_mode(ctx); } static void it66121_bridge_disable(struct drm_bridge *bridge, -- 2.54.0