From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D18349CE8 for ; Tue, 12 May 2026 13:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592794; cv=none; b=Pq9nG+jjZim0aaq8xCC1S7V/TPe+A9ZzGVfjnWamyXZx/C0ziYtNE9Nq+dqoqkw9f3z5J0nIEdzV5iJyNXjEYUfmUBOiGp2pIaAJJ6Zt4v5FrR8lMyNJwIVjrWCXfi4byAe75tLHhJvxCM2+DTbbhDhLQN0vC+X3giUxTq7lLTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592794; c=relaxed/simple; bh=ulTqOnJ0/DOZtfwfiFl6Nx8CEJn66OQ5TqF7AqphWHg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pRpv3t9iZH8vU212ed9sLOOX4mplBIHE816t/WhhB9twr0Bwurg6jbUcdOaxHjpod/PUyMHcQxMPcmgZQGxpOBDWKYuQw5Mq8Otucn6NYw/BdBFguwjj51RLlMVYlV/9z/UZxBayIaQ3/3irE8/bsqXGWVeBP0aYipxfRjKC/aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cLYajK5D; arc=none smtp.client-ip=209.85.210.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cLYajK5D" Received: by mail-pf1-f227.google.com with SMTP id d2e1a72fcca58-83bbc41c7b7so496496b3a.2 for ; Tue, 12 May 2026 06:33:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778592792; x=1779197592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M43xE3rgAlqZemGJ9rIPU9yoPZP2zJ9KSuP357iBUFo=; b=otJHN4YUJjSyYr2zVgUAUTkQMecX68uT+kqBo1DBfunTtM33Ng3fOaXBrHIraARqU5 bo6jxJi7Oh5JfBBVB68HRWmtkZSHjuom1AUrR9NAl4nPAyIgEiERDPhNpsWtix+QOgDk c4RMDy4VwnrfBxNzUUrvgV6iVkmHJof9ySCzUkK52FZgT2rutyo4vrRQUbfFk0vwr8GV dL7zHcIg5W4iIwGEcmTi4u4qUfOnjn1yJdPcmvP/SlYVOpuW2U+NTOMX/pQ5uguv8p3Y jfgWzPyooP4hPuiRMVDfm1XZrbo+158YZyokXtaAcorDp2RI7AKSeN2qImjZO4b+ZBVM 0HnQ== X-Forwarded-Encrypted: i=1; AFNElJ8laUocumBpkHoi2lfYd+2C+b7axhqlDG1pzxvaiX2BGQAx1WfmR7qe7iA3ajVl7Ifc5itZyZUzzTs5mIE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/xDDJ2tLhEogLNbbEUyCVkFbOk5C1tOGCdwDnGfqAAaHYrLnm pM+H+6Usl2FupEnMhI06x1Wq5sra1eqtqA7LqGy/1dRN5DXz4tr89sxa+SOKkXTSYKjpCRTgy5k R9+Rmwir5gjW+pH2ZCFSOYUOR8O408uQkChnLiZQIX08gVWo8PBmAoxuB00tNwUJAgVYLIH2ApQ I/b3h+vV82bpmUEnBv+9tQQsds2DkYwHmk0Fm4Hr0DFdbIuD4s4Xh3bHm9OBQeToFoYX3cMRwET xBtKN9NHcHbiXXEj0MJygA= X-Gm-Gg: Acq92OEZCqq+uI9u9KqZnOC03eKFbg4ERdPCzFijC0U1DGPc2ONpPCLvK/fojdp/4WT NdbQW1Ol1SpWMW9S+/4QSxO+/a30cpTbQM0LZBXcoHXdWFnaF8WFkfQXoKCm3IGe1ftumDvWSUl EJnamEKF513zuGaOhy3YuO30pZK596ZDTHQpbACg0q/0vpw2VUAJUCHezfbRJFyot6SwBGhivlG GF2n4AUz7M6wlhOtbQFTpBchQwLrl7GPNBwLgf1bsnvReIe8pkbqIeJ6UXBWjyIRmyiaXaVDewL a3JmO4a24pzS+6PAHx7fNe2JtQ9OCnPnk8rYJ5mDhyywdE1VhcmWEBAAJh1UhB7T9VUzNo8y7yz CLeuULmnzbKrxW3xFUuBLZSv/rshVMOIky4CIk45pXkkuRIUKzsAlmPRYR0hBqNW+eMoOzWIcb4 /UKsnT9A== X-Received: by 2002:a05:6a00:8593:b0:83e:f208:b11d with SMTP id d2e1a72fcca58-83ef208b44amr1188880b3a.6.1778592792392; Tue, 12 May 2026 06:33:12 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-839679c0eabsm2211645b3a.7.2026.05.12.06.33.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2026 06:33:12 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2f218ed8dc3so670700eec.0 for ; Tue, 12 May 2026 06:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1778592790; x=1779197590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M43xE3rgAlqZemGJ9rIPU9yoPZP2zJ9KSuP357iBUFo=; b=cLYajK5DZBJeryU/OxEZQZm1OdozSix9DFXPBQ6BZV6L/5lVZ1wO8NioZz5nlduvJ0 yBIwCa1qjiqrhb6b0wUwhC2N5l1Fmay/BHOLgO2a+O3zIhdRxQWI8EvRsbjrZu663rAV es62J3rW/4QBD4AiGtXb3P60B+ZNoatCaOVVg= X-Forwarded-Encrypted: i=1; AFNElJ9vGJb2OsHP55sMVGY+G0gtlgY9NOjr4JPyzqK+SaEBzOoxFTMiaCZid7W4GB4GSpo4sH8OfgFcU3/kPTo=@vger.kernel.org X-Received: by 2002:a05:7022:6992:b0:119:e56b:c3f3 with SMTP id a92af1059eb24-13203e9654emr5811847c88.3.1778592790498; Tue, 12 May 2026 06:33:10 -0700 (PDT) X-Received: by 2002:a05:7022:6992:b0:119:e56b:c3f3 with SMTP id a92af1059eb24-13203e9654emr5811823c88.3.1778592789838; Tue, 12 May 2026 06:33:09 -0700 (PDT) Received: from photon-d7fac424c0d3 ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13278210d40sm22957383c88.4.2026.05.12.06.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 06:33:09 -0700 (PDT) From: Ankit Jain To: edumazet@google.com Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, ncardwell@google.com, kuniyu@google.com, horms@kernel.org, shuah@kernel.org, quic_subashab@quicinc.com, quic_stranche@quicinc.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, karen.badiryan@broadcom.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com Subject: Re: [PATCH net v3 1/2] tcp: protect locked SO_RCVBUF from Silly Window Syndrome Date: Tue, 12 May 2026 13:28:12 +0000 Message-ID: <20260512132812.25147-1-ankit-aj.jain@broadcom.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi Eric, Thanks for the detailed review and explanation. > Applications using SO_RCVBUF with tiny values can not expect kernel > behavior to be stable, > since rcvbuf management depends on metadata size, which can vary > between kernels versions/options. I agree with your reasoning. Applications locking SO_RCVBUF to small values appear to be the primary trigger here, disabling auto-tuning against modern metadata overhead. > If a kernel change is needed, I would rather enforce a sane sk_rcvbuf > floor when the MSS is learnt > at accept()/connect() time. > > ( TCP_SKB_MIN_TRUESIZE / SOCK_MIN_RCVBUF definitions ) Enforcing a safe sk_rcvbuf floor based on the learned MSS and TCP_SKB_MIN_TRUESIZE at connect()/accept() time is a much cleaner and safer solution to protect such applications from SWS stalls. I will implement this approach in v4 and update the packetdrill test. Thanks, Ankit