From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB423C2BAF for ; Tue, 12 May 2026 15:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778600319; cv=none; b=n27TJxpit4UxfL0xXVGvMuDk/h31jurk7cZUJIEEh8eJf0F75aWrLpvytO1ANblPidTOtlHjBantKRqW1kBKQ7LOQA0Fr9ToWkspsNZ9onnpuatrBs+M1ZAGb4dieXvxEU2LJlqFlAsFKOqEM9zg/XbcRKdvrEvWRXUv2ejJQnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778600319; c=relaxed/simple; bh=h9bsPBYcOXqMfv+VjbAyojonmmoubV1MX83pq2oMIGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FuwPtoeMYe9WJXG/x30RYIBOfXMDkyv/ZaT1OgHqfRZHS40Yx6N9Ikp9iaj+s+sB0/G8ybp0/4xIGKejphSgOGSMqMiFieOVK4+OfxovJpPxzaWkkqxDwzoLv4Q6mDg2PuOQ7GfCSME955g9uv3dXv/ffmoq3fM3LE3RJmtYCCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=otX1Kn8/; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="otX1Kn8/" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8f0579401c4so682954485a.3 for ; Tue, 12 May 2026 08:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778600317; x=1779205117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZT0wrWmrJN0SJeayxN4+PzyvP8WgeUPSpw6VtORWwAU=; b=otX1Kn8/5Z6QlryhBcoKfihkk9x9XtTF0rG2W+Fk4bKJrFUnrZlnj2U2TmC7J9Tt5D jNyjve4LtQB+3aAJNFgOAFfwpBRFOaq7wD/kkhNQcuoz55TogsiGz/eqoFBW8O3I397g H5KAIWLFzcJa9GggW4NGld+y8NNdewdnJG7uXY8E7ALFOY17r6tsLp/878l+5j6mlO/i qdgFDd3xZQnPpR91Wm6I+/fW3nfmFZcOx/T+384hq+C6b9LlBSzR2Qosx6fD60Y0B+EV 4zCcmJajrDje2mr/7E1SVTTlKtn5qah+CK228T9bteQYbZJmZBdRJV8PLzgNl2FEOQaC 6Rig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778600317; x=1779205117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZT0wrWmrJN0SJeayxN4+PzyvP8WgeUPSpw6VtORWwAU=; b=eoKmmNGY56v6Aa/JdsVb1hh0w5jlDqo8EQhRyPwiRNH6dctv3oUAMuYDiCy6n3OKMl tbe1lu2JmMgyKJ2sct+a9GsYmoHSdnxl2oVO6mSTpLJpsMpN/Q7nYcS+m/jMdOgVQVS1 oPLCa+wlN1kCZrrKtgfdACzlUpmjUwG4sYOD/SqSlmkj0suq6cbVGiWAsBrgcI+Ej9Tc BkNzn4CsKaN5jT7sOao2zbgV6vLXDbl8I5iztG3FwOphV4Y21QRhj396inRLbz/SEe6K aswMqTyXp7iaHNQCF0Z+A0UnWwVHVzRcOdaKn+M6ygqjfwfeM+cpmmwAZgMegjcEjNpl r2nA== X-Forwarded-Encrypted: i=1; AFNElJ+NujPvcuruDl2ByD8ERJWqjLWKjKEmAjDcJJoL8AZ7OLppuA/h3efi4XJrckQqgo/mltGXIJLDu9AHNwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzmofvY8qzALDO8LKT5ndvHzJ8S/RS5OPd2xj3Jb+FYIi+6VLse m13BfukcqCFXvD28Xc8GNZjLt5GGqqGbi9bRZuJgBNjZz68jhkGhkzcC X-Gm-Gg: Acq92OHP+U55uLSePhVvM1h49JueQS5gO3zpNxXgsWkYsjBesSJZzcMsoTQRihA2X/m VY75N8CLGCcJDgYZpekVrCsD9uQMpyKdf4CJMNbkGKyDXFTD3x7taP6lX6Htpo13myLUb3YHVCB OsmzDsz4GRHh7dD2X1Ef3BgLuRgAk/QFUkkts8rOcmR7KFXD+s5U6hVYG7Vqb0urSvpdQ8SXVyi aSchvthqdF2pIWgKxz6SHpGwJs+EoM9oKInYEKtwjdV7V1Vyeyno829XCt289OdbeysIW38aGZq oASwDN2ovz2wDD3iBLi041JuH/fYBNPufISDsvqBdVIUxQPeTVp1+fwUAUk4e/lanLQCGvF3W1N 4pq85NgfcRWXCCdjP5tihkkEICa1UepYnCRcwwn5kqaZ7fQB4Kec5FOuPk4etslIaJNYNeZaOl8 MswIr7YqmB+MPM1RIuod5UUsjTTE9dlGYYqNVbyK6lodLoBGNMryELO8waT4VylHE6qXa/8UOVL OBd/siMUtE9zK8= X-Received: by 2002:a05:620a:372a:b0:8f4:e8ce:8f4 with SMTP id af79cd13be357-90cfd34179emr518940485a.47.1778600312657; Tue, 12 May 2026 08:38:32 -0700 (PDT) Received: from jeremy.kali (srv1619992.hstgr.cloud. [2a02:4780:75:55a3::1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-907b966f5f1sm1412826585a.8.2026.05.12.08.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 08:38:32 -0700 (PDT) From: Jeremy Erazo To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] usb: gadget: composite: fix integer underflow in WebUSB GET_URL handling Date: Tue, 12 May 2026 15:38:25 +0000 Message-ID: <20260512153825.327038-1-mendozayt13@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051237-delicacy-gallon-268c@gregkh> References: <2026051237-delicacy-gallon-268c@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The WebUSB GET_URL handler in composite_setup() narrows landing_page_length to fit the host-supplied wLength using landing_page_length = w_length - WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_offset; If wLength is smaller than WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH the unsigned subtraction wraps, and the subsequent memcpy(url_descriptor->URL, cdev->landing_page + landing_page_offset, landing_page_length - landing_page_offset); ends up copying close to UINT_MAX bytes from cdev->landing_page into cdev->req->buf. KASAN reports a slab-out-of-bounds in composite_setup on the kmalloc-2k gadget_info allocation, and FORTIFY_SOURCE traps the memcpy as a 4294967293-byte field-spanning write into url_descriptor->URL (size 252). A USB host can reach this from a single SETUP packet against any gadget that has webusb/use=1 and a landingPage configured. Handle the small-wLength case before the math: when the host requested fewer bytes than the URL descriptor header, only the header is meaningful and no URL bytes need to be copied. Setting landing_page_length to landing_page_offset makes the existing memcpy a no-op and leaves the descriptor returned to the host unchanged for all larger wLength values. Fixes: 93c473948c58 ("usb: gadget: add WebUSB landing page support") Cc: stable@vger.kernel.org Signed-off-by: Jeremy Erazo --- drivers/usb/gadget/composite.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index a902184bd..dc3664374 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -2172,7 +2172,10 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) sizeof(url_descriptor->URL) - WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_offset); - if (w_length < WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_length) + if (w_length < WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH) + landing_page_length = landing_page_offset; + else if (w_length < + WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_length) landing_page_length = w_length - WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_offset; -- 2.53.0