From: Jakub Kicinski <kuba@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] FDDI: defza: Sanitise the reset safety timer
Date: Tue, 12 May 2026 18:06:31 -0700 [thread overview]
Message-ID: <20260512180631.7c50adff@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2605061216430.46195@angie.orcam.me.uk>
On Sat, 9 May 2026 22:04:50 +0100 (BST) Maciej W. Rozycki wrote:
> case FZA_STATE_UNINITIALIZED:
> netif_carrier_off(dev);
> - timer_delete_sync(&fp->reset_timer);
> + timer_delete_sync_try(&fp->reset_timer);
> fp->ring_cmd_index = 0;
> fp->ring_uns_index = 0;
> fp->ring_rmc_tx_index = 0;
> @@ -1018,7 +1018,9 @@ static irqreturn_t fza_interrupt(int irq
> fp->queue_active = 0;
> netif_stop_queue(dev);
> pr_debug("%s: queue stopped\n", fp->name);
> - timer_delete_sync(&fp->reset_timer);
> +
> + spin_lock(&fp->lock);
> + timer_delete(&fp->reset_timer);
Noob q, why use timer_delete_sync_try() above ?
next prev parent reply other threads:[~2026-05-13 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 21:04 [PATCH net-next] FDDI: defza: Sanitise the reset safety timer Maciej W. Rozycki
2026-05-13 1:06 ` Jakub Kicinski [this message]
2026-05-13 15:29 ` Maciej W. Rozycki
2026-05-14 0:18 ` Jakub Kicinski
2026-05-14 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512180631.7c50adff@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox