From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03C5255F57 for ; Tue, 12 May 2026 18:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778610619; cv=none; b=tsE/BtDvH5yVSjMU+xT0tzJBwJp0NRiFIOci29N2CxVi+5+Y05Cjf7fenB0iS12nwVUUevFxNyIdzof3nNeSUf9En+ABJfoQDiGcDxcC+fw4k9TCxfysj3wjE9/rEjBsvZHL09vmIX0YKkYOf/RCRvmSqheDsoBxigEzpANpgN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778610619; c=relaxed/simple; bh=Ev8+ae7yxH6LIx0vV16mfuXO7NpD41J+W6pwdhrch+M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YBkEa4rT7w7ocyPSXnTOQBtCgUWUe1OrcmtyEYkGk4+CjkF4k7lEAtWHcK07sV/HrWaNwbv2Ma5Q1DB4eVAeZgZOVbNGEwNUlLKh743PscAB0AyRn1Bv/qenvoWuKw4hw1jDLR4cv2AUg7DKWPbPbmI0g60cFmIO6mgrnWj92Vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k6P/J3Ug; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k6P/J3Ug" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c798fc1a28cso2748810a12.3 for ; Tue, 12 May 2026 11:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778610617; x=1779215417; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mKZMv11nwqLYu9TXYZdupqbbdF1zc6hH1M/c3s/e/XQ=; b=k6P/J3Ug7cv6pdH2mD3t1ZhZVfagDR8bgSHq9X2LssK/Cr6QLWNQIqC6l9GXE9WnjO k34/8pttCb5LueUvXnbepbxsNVjxxaO3Hp8ludE/YdchjvPUkm1IDT6XGf2GzWq3QWth 2S4u/9Uwl+Ja0riW7v2Yi3rs/4HXDP1hwXU3R0bzFYL70MX2GDG7FzWSupHZ8Aolsklf 6IsiPa7abRBlC8qBDu0eFJjASgu/GREV9lIwtlvFwyMf4cva0jkl5XOtmakZdYM3fAjC W94tAYkaTdEecb4GcI0ePeDo+fo9wuoUDNt1HNeL+bpWu77pAJ9lVVkeyJojDHMKWZz1 w66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778610617; x=1779215417; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mKZMv11nwqLYu9TXYZdupqbbdF1zc6hH1M/c3s/e/XQ=; b=a+Zf6W6rMcIIK+iQcE/O7ZHg0H08Zg6Hrg44zyck/iyHdlbz79VZeqT7VifdToSR0o I0+df82j8RZim58W+ZnP5XOzfIbmKqkjKpSGIe2pSiIA8JfVmUIgFLa+axszySdwW3c7 3m5BnFEwav5yNKfaRmtCy1TzXX5r0T05ntB8cu1ieOzkfIud/jgxn3xCx8i7egFr/lK6 KNXdgKQ00Mms/nBQT9DRBImOfDmWg//xa0shhbs/EvlKmNkf1YzTAhep6Zxq3W6HKaRz V0COpqZuHIksx74C2jYGaytKHAZq9kGhY6X7Gi6y/KH2n+zwM6Vn0Gbdq1Nilf/HGK6J FiMQ== X-Forwarded-Encrypted: i=1; AFNElJ9uIdxrFZzys1lZMwWZjzV4aQkpS02yHyxlsBQIEtQw9UnO1dXQXZMKl4tJQParfNDlmpn1oZtOZZRptq8=@vger.kernel.org X-Gm-Message-State: AOJu0YyAonk2YVLzJEN30GMnE/zDN3eqvzhxOe2/nxFTQoypmKWdl5hl V/TL5NzepMOA0xP+YdGmEqP8ISvCHah3yFeqyDHh6a3r9uV/afTVxZR6 X-Gm-Gg: Acq92OFc2ANb2bB5LvHa4PVk5MccD2Se9MOAZ6bTXfbT4aW2XrEKV27y2pUTf3whTiK 7yI36LaIIaOvJs//DSHPXS1Y+UWBZ8vdpUX/zn83Pm9hzZ5RjzIy82RetmFi4TbVVBfcmRSeKwn EUAZe6oR7S/+6QNLJlFdoZdP9I8DgqRU4dZwB5swVTovWk6o4ND6h2GiHbqYZ0S+iw3Dds+m3a0 QT6YhN4c3gglqIz2vVR6WDGWYfi+Id6tK80EwB4IFfkgbVtC2Hsi4FLkVhMGk+4oYIYu0LH1iIv 57qAf+CL8eeH9iOZ3Qu/z3WTtyf7cAWUlcIl5UebLY5zeHDPGaBlzG/dOOgolcwza2ROEB1dMGP s8WIddlReQpp3Wxl+bqJczRQVCxeJnIvrCjyV/spSeJTG5YsHWFTQ8vvRxLcN78BouR2pZ3Wejr O97qTFE4CRsJDS+2pXWu9/+YeFM7/C3yv33wxJZpCj X-Received: by 2002:a05:6a21:32a0:b0:3a2:d838:bfd1 with SMTP id adf61e73a8af0-3ad99611749mr5199023637.30.1778610616853; Tue, 12 May 2026 11:30:16 -0700 (PDT) Received: from MAHADEV.localdomain ([103.135.229.217]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c826771e730sm12650097a12.26.2026.05.12.11.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 11:30:16 -0700 (PDT) From: Harshit Shaw To: andriy.shevchenko@intel.com Cc: gregkh@linuxfoundation.org, error27@gmail.com, deller@gmx.de, chintanlike@gmail.com, tzimmermann@suse.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Harshit Shaw Subject: [PATCH v2] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Date: Tue, 12 May 2026 18:30:06 +0000 Message-ID: <20260512183007.14511-1-shawharshit116@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace direct device_create_file() calls with the correct ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the driver structure so the driver core automatically adds and removes the sysfs attributes when a device is bound or unbound. Signed-off-by: Harshit Shaw --- v2: - Use DEVICE_ATTR_RW() macro instead of DEVICE_ATTR() - Move DEVICE_ATTR_RW() definitions closer to their callbacks - Remove trailing comma after NULL in attribute array - Remove extern declaration from internal.h, not needed - Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver structure as suggested by Greg KH and Andy Shevchenko - Compile tested with: make M=drivers/staging/fbtft modules drivers/staging/fbtft/fbtft-core.c | 3 -- drivers/staging/fbtft/fbtft-sysfs.c | 80 +++++++++++------------------ drivers/staging/fbtft/fbtft.h | 2 + drivers/staging/fbtft/internal.h | 2 - 4 files changed, 32 insertions(+), 55 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 3da42c8ca6e3..e6d33127cecc 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -782,8 +782,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) if (ret < 0) goto reg_fail; - fbtft_sysfs_init(par); - if (par->txbuf.buf && par->txbuf.len >= 1024) sprintf(text1, ", %zu KiB buffer memory", par->txbuf.len >> 10); if (spi) @@ -826,7 +824,6 @@ int fbtft_unregister_framebuffer(struct fb_info *fb_info) if (par->fbtftops.unregister_backlight) par->fbtftops.unregister_backlight(par); - fbtft_sysfs_exit(par); unregister_framebuffer(fb_info); return 0; diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index d05599d80011..92d9e237123a 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -107,9 +107,18 @@ sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf) return len; } -static ssize_t store_gamma_curve(struct device *device, - struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t gamma_show(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct fb_info *fb_info = dev_get_drvdata(device); + struct fbtft_par *par = fb_info->par; + + return sprintf_gamma(par, par->gamma.curves, buf); +} + +static ssize_t gamma_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t count) { struct fb_info *fb_info = dev_get_drvdata(device); struct fbtft_par *par = fb_info->par; @@ -133,18 +142,7 @@ static ssize_t store_gamma_curve(struct device *device, return count; } -static ssize_t show_gamma_curve(struct device *device, - struct device_attribute *attr, char *buf) -{ - struct fb_info *fb_info = dev_get_drvdata(device); - struct fbtft_par *par = fb_info->par; - - return sprintf_gamma(par, par->gamma.curves, buf); -} - -static struct device_attribute gamma_device_attrs[] = { - __ATTR(gamma, 0660, show_gamma_curve, store_gamma_curve), -}; +static DEVICE_ATTR_RW(gamma); void fbtft_expand_debug_value(unsigned long *debug) { @@ -173,7 +171,16 @@ void fbtft_expand_debug_value(unsigned long *debug) } } -static ssize_t store_debug(struct device *device, +static ssize_t debug_show(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct fb_info *fb_info = dev_get_drvdata(device); + struct fbtft_par *par = fb_info->par; + + return sysfs_emit(buf, "%lu\n", par->debug); +} + +static ssize_t debug_store(struct device *device, struct device_attribute *attr, const char *buf, size_t count) { @@ -189,40 +196,13 @@ static ssize_t store_debug(struct device *device, return count; } -static ssize_t show_debug(struct device *device, - struct device_attribute *attr, char *buf) -{ - struct fb_info *fb_info = dev_get_drvdata(device); - struct fbtft_par *par = fb_info->par; +static DEVICE_ATTR_RW(debug); - return sysfs_emit(buf, "%lu\n", par->debug); -} +static struct attribute *fbtft_attrs[] = { -static struct device_attribute debug_device_attr = - __ATTR(debug, 0660, show_debug, store_debug); - -void fbtft_sysfs_init(struct fbtft_par *par) -{ - struct device *dev; - - dev = dev_of_fbinfo(par->info); - if (!dev) - return; - - device_create_file(dev, &debug_device_attr); - if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(dev, &gamma_device_attrs[0]); -} - -void fbtft_sysfs_exit(struct fbtft_par *par) -{ - struct device *dev; - - dev = dev_of_fbinfo(par->info); - if (!dev) - return; + &dev_attr_debug.attr, + &dev_attr_gamma.attr, + NULL +}; - device_remove_file(dev, &debug_device_attr); - if (par->gamma.curves && par->fbtftops.set_gamma) - device_remove_file(dev, &gamma_device_attrs[0]); -} +ATTRIBUTE_GROUPS(fbtft); diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 317be17b95c1..ab71db017d05 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fbtft/fbtft.h @@ -299,6 +299,7 @@ static struct spi_driver fbtft_driver_spi_driver = { \ .driver = { \ .name = _name, \ .of_match_table = dt_ids, \ + .dev_groups = fbtft_groups, \ }, \ .id_table = _spi_ids, \ .probe = fbtft_driver_probe_spi, \ @@ -328,6 +329,7 @@ static struct platform_driver fbtft_driver_platform_driver = { \ .name = _name, \ .owner = THIS_MODULE, \ .of_match_table = dt_ids, \ + .dev_groups = fbtft_groups, \ }, \ .probe = fbtft_driver_probe_pdev, \ .remove = fbtft_driver_remove_pdev, \ diff --git a/drivers/staging/fbtft/internal.h b/drivers/staging/fbtft/internal.h index ae2ff4a4a472..7869cf8dbf2a 100644 --- a/drivers/staging/fbtft/internal.h +++ b/drivers/staging/fbtft/internal.h @@ -4,8 +4,6 @@ #ifndef __LINUX_FBTFT_INTERNAL_H #define __LINUX_FBTFT_INTERNAL_H -void fbtft_sysfs_init(struct fbtft_par *par); -void fbtft_sysfs_exit(struct fbtft_par *par); void fbtft_expand_debug_value(unsigned long *debug); int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *curves, const char *str, int size); -- 2.53.0