From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3863A5E80 for ; Tue, 12 May 2026 20:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778616076; cv=none; b=e58QDVYMWur5qiFhOXO63ImDKI6xc2owtwJiwjLmQvFShLQ4xJ3EP/V7JQuQxGqrTZRtHfslpo5hHdSJ4P8FU1d6TBfySgXIZ3s3dwV+Udyj44P53z78rLi+TnHqiHJBWKgkbMDkcHzlx9X5i4HCb7S2CFCyhKT8fqZuZ3Wpjnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778616076; c=relaxed/simple; bh=MKDpSJRPEOkKOwK5I5btBRFs2g54luTXp+aSanxNapk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jfRUuP/SvyUO3gotrD3yXqh22nlmKI4FG9o/GBS/KAPdsFepnc40V0Gy86f7Yis1lELqDAPX8ocpUsvmbGpXCv5U203+x5h0wnnUejAqmzg0nITQ1bLDFy3/ZQ46xZeFSDHlz/IGD4QBKOCTAbdcEl995zRiXa6PNi+VsHXInnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a2+SA2d9; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a2+SA2d9" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ba6485d219so39041925ad.3 for ; Tue, 12 May 2026 13:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778616074; x=1779220874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=78YRgXF4hW4GjfUu2dLBslOjL8I6aeWdAJYB94/EVoA=; b=a2+SA2d9k/DLFLqA+LdMpoiVHq04stK82xL2SOa5NrXPYDXjjvzL+qCfYaUhgols+K smIsm4l2MgbYUjG8ISOl6QsV1OrLQrtrV+TxeiyYi+PlgM7z+PEX1o37OCY6n7DFoURP kCbYEr5qqTxtDwmMHmwLke77qjESjlJAKs4vrcu3DiTyQUu0hR2hXTIcVNiOk3eeZLbN MX1VpBoQhYexQjGV3XspFU39ClPQFXH14WMSbZ+VrJAjq86IsuRDBVmOyIYzNcC4FUuO pVU2w74U9QbSsVKMMr9VlfWjMCEQEHAz8M5Vvm08s/lldugJ3g2YdqMXTPO9EkFdC7o7 Q0Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778616074; x=1779220874; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=78YRgXF4hW4GjfUu2dLBslOjL8I6aeWdAJYB94/EVoA=; b=jNmd+LGkmNULWzZ/0nl+kFptzTw1zWjahsBY99S1vPsvU2av0I86ZX7/YpmmASBg4a gyw9xMIt4+Jn6pU1UNY/nAWvAPOqsJ1Ym2qjwoeC+JaQ34ZUsREc9KupVuDLYA3smez2 K7KEC6Mvz5y6VajKN8jq4Q/JmhmFqCrBPRvXfnv7fn8IyR8oisn/kLqUNySbb8A+5tWN NqIQ3NBcLpurJ2aM/mc1hbX/1bn0NGCYBlAofVPRsuoECfv6xQj3JyOyzaUrjF3cskfP OwfP65pdWfcS2HYjxs9FKdA4yXcp1cdSek3XOjrht1z+nhAOPRd4zoACybJ8pjSIWH1F 1aAw== X-Forwarded-Encrypted: i=1; AFNElJ8827ZL62yI/mRAZiAjmc1mPv/4oAwfT0t1+sNNVTMQIQd0Jg0+VQfSZBfHm0Lst5a8+UqeLiufJPO6xkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxgZxqKoo9doFcwXRDrt9du/H/du9YQvLkPxuTC31e45LYKXxOV rfvZ6xNi2E+xZdFFYN6Ql2AfNKqL4waSrEdiaHfoLtCrVppq+bmX4ysZ X-Gm-Gg: Acq92OEHFoZpkzxtrZ5w52GVAsucljQnYPHfSItY73ibgW1waGAopAx9V4sAAb/ZEIZ L0ziwqqm7aIeORCYAMOFZ4AEdjEJSBbZ2CMIWdixXcyy2gdeWsEyfH3T8CheZyRk+zZ0+T0nI7D PKOCx2Bavun4KFM4Ff3HNytNo+iya8Ce6ZCb/4YS7KBODVaKa8Cy8zKhc2ch9nf1bz4qxglAgoQ nOYWc65+snihJuJ29tY5nGGbeE1N025OOPmy27AaVKw2izrXbSMiUAdI43yxRzwevwnc5VtsEP6 4sd1Lud83T+8momc9GXXvKuRBW+YgQzUlVunLuGBYSod3c/SWZrT8R5/q+mk7tRny+ZlAaW3nEN tHO2QHQEgC4xxWTGrQ3SVDU797VrKKQK+UUbwBUDrxhgE02oO74GwnlzaT9CCXl+gSlxBN9kYi4 Ohv+YQWoDigDVjGPOM/xNmaFINOcBRFPHWMJZFKvPg X-Received: by 2002:a17:902:7042:b0:2bc:d1ec:9f09 with SMTP id d9443c01a7336-2bd274ac286mr3390575ad.40.1778616074352; Tue, 12 May 2026 13:01:14 -0700 (PDT) Received: from MAHADEV.localdomain ([103.135.229.217]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d3ff52sm146933835ad.26.2026.05.12.13.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 13:01:13 -0700 (PDT) From: Harshit Shaw To: andriy.shevchenko@intel.com Cc: gregkh@linuxfoundation.org, error27@gmail.com, deller@gmx.de, chintanlike@gmail.com, tzimmermann@suse.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Harshit Shaw Subject: [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Date: Tue, 12 May 2026 20:01:04 +0000 Message-ID: <20260512200104.19002-1-shawharshit116@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace direct device_create_file() calls with the correct ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the driver structure so the driver core automatically adds and removes the sysfs attributes when a device is bound or unbound. Signed-off-by: Harshit Shaw --- v3: Remove stray blank line in fbtft_attrs[] array v2: - Use DEVICE_ATTR_RW() macro instead of DEVICE_ATTR() - Move DEVICE_ATTR_RW() definitions closer to their callbacks - Remove trailing comma after NULL in attribute array - Remove extern declaration from internal.h, not needed - Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver structure as suggested by Greg KH and Andy Shevchenko - Compile tested with: make M=drivers/staging/fbtft modules drivers/staging/fbtft/fbtft-core.c | 3 -- drivers/staging/fbtft/fbtft-sysfs.c | 81 +++++++++++------------------ drivers/staging/fbtft/fbtft.h | 2 + drivers/staging/fbtft/internal.h | 2 - 4 files changed, 32 insertions(+), 56 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 3da42c8ca6e3..e6d33127cecc 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -782,8 +782,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) if (ret < 0) goto reg_fail; - fbtft_sysfs_init(par); - if (par->txbuf.buf && par->txbuf.len >= 1024) sprintf(text1, ", %zu KiB buffer memory", par->txbuf.len >> 10); if (spi) @@ -826,7 +824,6 @@ int fbtft_unregister_framebuffer(struct fb_info *fb_info) if (par->fbtftops.unregister_backlight) par->fbtftops.unregister_backlight(par); - fbtft_sysfs_exit(par); unregister_framebuffer(fb_info); return 0; diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index d05599d80011..579ac9dcdd9f 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -107,9 +107,18 @@ sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf) return len; } -static ssize_t store_gamma_curve(struct device *device, - struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t gamma_show(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct fb_info *fb_info = dev_get_drvdata(device); + struct fbtft_par *par = fb_info->par; + + return sprintf_gamma(par, par->gamma.curves, buf); +} + +static ssize_t gamma_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t count) { struct fb_info *fb_info = dev_get_drvdata(device); struct fbtft_par *par = fb_info->par; @@ -133,18 +142,7 @@ static ssize_t store_gamma_curve(struct device *device, return count; } -static ssize_t show_gamma_curve(struct device *device, - struct device_attribute *attr, char *buf) -{ - struct fb_info *fb_info = dev_get_drvdata(device); - struct fbtft_par *par = fb_info->par; - - return sprintf_gamma(par, par->gamma.curves, buf); -} - -static struct device_attribute gamma_device_attrs[] = { - __ATTR(gamma, 0660, show_gamma_curve, store_gamma_curve), -}; +static DEVICE_ATTR_RW(gamma); void fbtft_expand_debug_value(unsigned long *debug) { @@ -173,7 +171,16 @@ void fbtft_expand_debug_value(unsigned long *debug) } } -static ssize_t store_debug(struct device *device, +static ssize_t debug_show(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct fb_info *fb_info = dev_get_drvdata(device); + struct fbtft_par *par = fb_info->par; + + return sysfs_emit(buf, "%lu\n", par->debug); +} + +static ssize_t debug_store(struct device *device, struct device_attribute *attr, const char *buf, size_t count) { @@ -189,40 +196,12 @@ static ssize_t store_debug(struct device *device, return count; } -static ssize_t show_debug(struct device *device, - struct device_attribute *attr, char *buf) -{ - struct fb_info *fb_info = dev_get_drvdata(device); - struct fbtft_par *par = fb_info->par; - - return sysfs_emit(buf, "%lu\n", par->debug); -} +static DEVICE_ATTR_RW(debug); -static struct device_attribute debug_device_attr = - __ATTR(debug, 0660, show_debug, store_debug); - -void fbtft_sysfs_init(struct fbtft_par *par) -{ - struct device *dev; - - dev = dev_of_fbinfo(par->info); - if (!dev) - return; - - device_create_file(dev, &debug_device_attr); - if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(dev, &gamma_device_attrs[0]); -} - -void fbtft_sysfs_exit(struct fbtft_par *par) -{ - struct device *dev; - - dev = dev_of_fbinfo(par->info); - if (!dev) - return; +static struct attribute *fbtft_attrs[] = { + &dev_attr_debug.attr, + &dev_attr_gamma.attr, + NULL +}; - device_remove_file(dev, &debug_device_attr); - if (par->gamma.curves && par->fbtftops.set_gamma) - device_remove_file(dev, &gamma_device_attrs[0]); -} +ATTRIBUTE_GROUPS(fbtft); diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 317be17b95c1..ab71db017d05 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fbtft/fbtft.h @@ -299,6 +299,7 @@ static struct spi_driver fbtft_driver_spi_driver = { \ .driver = { \ .name = _name, \ .of_match_table = dt_ids, \ + .dev_groups = fbtft_groups, \ }, \ .id_table = _spi_ids, \ .probe = fbtft_driver_probe_spi, \ @@ -328,6 +329,7 @@ static struct platform_driver fbtft_driver_platform_driver = { \ .name = _name, \ .owner = THIS_MODULE, \ .of_match_table = dt_ids, \ + .dev_groups = fbtft_groups, \ }, \ .probe = fbtft_driver_probe_pdev, \ .remove = fbtft_driver_remove_pdev, \ diff --git a/drivers/staging/fbtft/internal.h b/drivers/staging/fbtft/internal.h index ae2ff4a4a472..7869cf8dbf2a 100644 --- a/drivers/staging/fbtft/internal.h +++ b/drivers/staging/fbtft/internal.h @@ -4,8 +4,6 @@ #ifndef __LINUX_FBTFT_INTERNAL_H #define __LINUX_FBTFT_INTERNAL_H -void fbtft_sysfs_init(struct fbtft_par *par); -void fbtft_sysfs_exit(struct fbtft_par *par); void fbtft_expand_debug_value(unsigned long *debug); int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *curves, const char *str, int size); -- 2.53.0