From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF0B3672BB for ; Tue, 12 May 2026 22:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778624751; cv=none; b=SeUlX2TGkhcu+C96jqFZOG7JxCARbIy+xXw/fwli4RCEuYvNbQNpG9xmEsuM9NGb1AzVASdtR/KgSSH6XOM6xAQI/cYqO6UY/1kxYFRvkmZTUAMx7Qv+sJinlY08v/0y3Bm3xegpyjphHY7quX8mrHMAQfJHJss3C8FP9uq/sQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778624751; c=relaxed/simple; bh=Y4vMA2JNnv40MvcKeCvNyUWpztSVrcRb/TQy6UY4ySM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u9sXxYXohvJR44YrrlVsaa1uavnpX0NJLx7wmoUCdC5/yL7hjJiXhX9LiRHbadkYQCGbsUEJQYOBEvHkbU+wSYb/TWBuVq9JTAQuzJ5DtwFXGAjsJP/tGMzYpWG2oWnwhED4SdrqrIZKp6OywjDGBRhX8bWwbhLce1umtioaR5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Knmdzr7f; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Knmdzr7f" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-12c8d0945b3so14c88.0 for ; Tue, 12 May 2026 15:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778624749; x=1779229549; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xezjeDqPD8r5Y688yiRpTBbJ7F3pJULcyTn19qkHR5A=; b=Knmdzr7fjEEVpFckEJ5hkIW7D/Ul/rMLhiZMYovKf3u7YYuvXFzODoGtEIcHrIuu+a uPgkDPcdekSJR9rB0FidwBAbdNCVGaRpcdbe//Nph3LjBx4f1RfFe+K2heau1UXF0Tyj UQf4ioU/g8/CVLxmiL+IMCj0uLFBAeRGzam42rc7nXnUld0Nvi4qZjAtOoqT+KnItUpP BwnvuUpwf42zTsFYallB1aXbCTc2SiDS9zh7KmiwzZZk5qdacUj/WRQM98GJWUTjR3ua +OCg+YoOJXYxpdp8pY7wo3IcrinAuUK3V9MMVdYw4H6EFFao79ReNYIbPQYhBdoAITlF CwjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778624749; x=1779229549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xezjeDqPD8r5Y688yiRpTBbJ7F3pJULcyTn19qkHR5A=; b=KRac2liVtM2XRQc1tTQiC33aJkUlsxie5AO430QrNJazsTUZLXsrnZYDQmVqp38cc5 /Mwt0DPJ29quAKpyvSxqU04dff73M7Fk3MTwBoc1zX4ZLXrdyN8B7HkMBXgdUhd5xgHv lOBO984ovVgzvyUnCrFqXgcp6sLEo8lxz5y++r4mdHs6z2+JQ3lAaonm57gMogq9QFLE 3ViyMwOXvagNKo1iEngQvtfNqPD9UHpq9a5FnnpcErwmre7RkC/MUCPL20fWCiMYtQ3I uLgr4w/vb64zdKEUvfT2d9501hS7A6mTWDaEtMN4KvXXlBUGlxzR1dZIXICNnbmFy8ac NMyQ== X-Forwarded-Encrypted: i=1; AFNElJ+DwI599me9i3jlB8/DqEFw8T17P/FOm7gKbe0PphyIk3yF4XVcCaM7ieywhwtWR7fijWg6XHmmRYQg9fA=@vger.kernel.org X-Gm-Message-State: AOJu0YzgsZcLVASEDCQjedqC8obhTZ0sr+00/+sqFgF9/aylCcs8F3Ek qRcdFjrro6RrsashXXV2hEz3iuee5jSyjJ6jV9fJlUDKmRC/34pQcF8jNwtycBjOrA== X-Gm-Gg: Acq92OGsEePrmNZzFfx95thwO7WzJ7F52tpjpbHTJiRm/t7TH8mGcPk9aMJvyCTZCeW CgdU2+0pKAyfRJk7yyJZCyJT+fUKSE4X1WTsd5ZLrrvHF1ScqOT2nMDgI/LPHvrtlTjz0RSiyH3 5tDrkv50/jB94w1545nf3FEQRqk2c8hryof1gukL8Hl9i2hnHQ1rCETSYWNNUW1lOmgO+XFrjc8 nY1XnsMEPIkT9rhnCLuixcoiclGegJkAkLRGcK8709pYBEVhzmqlJt6MYKEh0G0or+wKq2Kk3bd bN4Z9J15HkBHx0rcjLZ337hQrObj4OuhOlGDHnFATbapiX7OhuXhvnPdecscW11DuGiITWGFuMC YVMA7sRFRCgsvg8xR2acvs7of3d1TsrcZMohscwco3jNS5mNnUHuCmx+iDEzdGGnUAoV5ydjmX2 sHjfnzF8LPtNpYs1FMBfZ9fX1ukjCDDGgY9uOJh8oU0xgZqsQvric542G3lD/yV033jpmYvcxWJ 1usyaBG X-Received: by 2002:a05:7022:699a:b0:132:1e01:2d6d with SMTP id a92af1059eb24-13401ba684emr121609c88.2.1778624748249; Tue, 12 May 2026 15:25:48 -0700 (PDT) Received: from google.com (60.89.247.35.bc.googleusercontent.com. [35.247.89.60]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8860c7accsm19638280eec.8.2026.05.12.15.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 15:25:47 -0700 (PDT) Date: Tue, 12 May 2026 15:25:44 -0700 From: Vipin Sharma To: Raghavendra Rao Ananta Cc: David Matlack , Alex Williamson , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 1/8] vfio: selftests: Add -Wall and -Werror to the Makefile Message-ID: <20260512221637.GA3046123.vipinsh@google.com> References: <20260505212838.1698034-1-rananta@google.com> <20260505212838.1698034-2-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505212838.1698034-2-rananta@google.com> On Tue, May 05, 2026 at 09:28:31PM +0000, Raghavendra Rao Ananta wrote: > Add the compiler flags, -Wall and -Werror, to catch all the build > warnings and flag them as a build error, respectively. This is to > ensure that no obvious programmer errors are introduced. We can > add -Wno-* flags in the future to ignore specific warnings as necesasry. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: David Matlack > --- > tools/testing/selftests/vfio/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile > index 0684932d91bfc..e26917ee169c5 100644 > --- a/tools/testing/selftests/vfio/Makefile > +++ b/tools/testing/selftests/vfio/Makefile > @@ -23,6 +23,7 @@ include lib/libvfio.mk > > CFLAGS += -I$(top_srcdir)/tools/include > CFLAGS += -MD > +CFLAGS += -Wall -Werror > CFLAGS += $(EXTRA_CFLAGS) > > LDFLAGS += -pthread > -- > 2.54.0.545.g6539524ca2-goog > Reviewed-by: Vipin Sharma