Re: [PATCH v2 1/6] riscv: dts: spacemit: k1-musepi-pro: add PMIC and power infrastructure

[Yixun Lan <dlan@kernel.org>]

Hi Andre,

On 14:20 Tue 12 May     , Andre Heider wrote:
> On 12.05.26 1:39 PM, Yixun Lan wrote:
> > Hi Andre,
> > 
> > On 13:11 Mon 11 May     , Andre Heider wrote:
> >> Enable i2c8 and add the connected SpacemiT P1 PMIC with its related regulators
> >> for the board's power infrastructure and voltage regulation support.
> >>
> >> Signed-off-by: Andre Heider <a.heider@gmail.com>
> >> ---
> >>   .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 144 ++++++++++++++++++
> >>   1 file changed, 144 insertions(+)
> >>
> >> diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> index 29e333b670cf0..88c35ad1ef2ae 100644
> >> --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> @@ -17,6 +17,7 @@ / {
> >>   	aliases {
> >>   		ethernet0 = &eth0;
> >>   		serial0 = &uart0;
> >> +		i2c8 = &i2c8;
> >>   	};
> >>   
> >>   	chosen {
> >> @@ -33,6 +34,25 @@ led1 {
> >>   			default-state = "on";
> >>   		};
> >>   	};
> >> +
> > ..
> >> +	reg_usb_vbus: regulator-usb-vbus {
> >> +		compatible = "regulator-fixed";
> >> +		regulator-name = "USBVBUS";
> >> +		regulator-min-microvolt = <12000000>;
> >> +		regulator-max-microvolt = <12000000>;
> >> +		regulator-boot-on;
> >> +		regulator-always-on;
> >> +	};
> > I think you can further drop above regulator, which merely serve as vin-supply
> > and not used by devices, plus it's a non-controllable fixed regulator
> 
> It is, but as mentioned on the cover letter I left this one as it's consistent with the other k1 boards.
> I don't care either way, so I'll just drop it.
> 
Please drop

It's a historical reason that we instroduced the unnecessary regulator
before Krzysztof's comment, in other words, we should also fix that too..

-- 
Yixun Lan (dlan)