From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFBB0376469 for ; Wed, 13 May 2026 01:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778635628; cv=none; b=oTWj6a3QhngmKtSXmZpk7WZ1kIVP9abvDdS12POHcNPZN3s72Lye/Twl5WgLZEj1IiZmOVqmNKuABmNb71AO2yqPOsRRfQWnpg+jMXhIJAYpiOwmiEJyRIp3wv7tA0lYhz0/B7RRhvwQnVJTay0LapjDsChQqPAeeu6kHvW6ATo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778635628; c=relaxed/simple; bh=TnPUINJyn6PSHuLu1gstbRWe/QwCMgAzrJLX58enzVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bZHMGjZ821aMk53JUzGsWVd20j4fJ4pU6UQZ6TashpP7BKp9HtKOjKIKXzjIteAl+BisFyVnV3rhMQGjS7b5b1exKdnru/+VS1miv57i3FXItrBwSpjGwQ3GR0LG8KV7b6ZB/Db85G73rNaMsJT1lXsoVbDnYvQ1+WzL2dzOYvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gcnNJzu2; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gcnNJzu2" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778635616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXDkhGNFKR9D13wH3Aimd/W/T350h2uBDl+jL3kz9Z4=; b=gcnNJzu2SukDxzPLcIgvZbWCubuSJpeLvLsieiA8LnGNVPcHsLvK2tCxpQr/TaeDmMvzs5 JK46q5FcAPMlUwQkKZ1VKo7VXFTPqtgX/yxmJ5C4AL/ccv3V/vnP41oXYL3FAluLLmvI6p q8Ma3TlT32hZAKjTpBO//KvGYTmQXY4= From: Qingfang Deng To: Pablo Neira Ayuso Cc: Paolo Abeni , Qingfang Deng , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , David Ahern , Ido Schimmel , Kees Cook , Guillaume Nault , Eric Woudstra , Felix Fietkau , Willem de Bruijn , Kuniyuki Iwashima , Richard Gobert , Jiayuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org, Alexander Lobakin Subject: Re: [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support Date: Wed, 13 May 2026 09:26:39 +0800 Message-ID: <20260513012641.5325-1-qingfang.deng@linux.dev> In-Reply-To: References: <20260509030507.387050-1-qingfang.deng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On Tue, 12 May 2026 at 19:32:45 +0200, Pablo Neira Ayuso wrote: > diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c > index 9c05a50d6013..270c3d0233ad 100644 > --- a/net/netfilter/nf_flow_table_ip.c > +++ b/net/netfilter/nf_flow_table_ip.c > @@ -577,6 +577,10 @@ static int nf_flow_pppoe_push(struct sk_buff *skb, u16 id, > return -1; > } > > + skb_set_inner_transport_header(skb, skb_transport_offset(skb)); > + skb_set_inner_protocol(skb, skb->protocol); > + skb->encapsulation = 1; > + Is this change needed? The PPPoE driver does not touch these fields. > __skb_push(skb, PPPOE_SES_HLEN); > skb_reset_network_header(skb); > Thanks for your tests. Regards, Qingfang