From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BDE388E57 for ; Wed, 13 May 2026 02:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778638903; cv=none; b=VOBjyieT6yG6+YdsZeTTT2F937aaXbq3DooJdPfhCawLQg2OcNlaCtzS7nweeKsp90p1A1V5k22Fcsd3gCZYgnQN7hvZuGdP/peTr0HeJUH3+dVCqIBN8jh0AOt/Yamol7x4UVVhPvP92rs/YvBF9656EFgSpUrbjrCSOS2oKU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778638903; c=relaxed/simple; bh=niYxAAiBDKtE94U5FtFb/76qYTq1nzkx4WUck+QAVpA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YXu34WktRGEvXR6JB3DAAGpIRoAXr/4wEdOqlAKNT8cRE4eJIWe9UHOp9qHx+v0QoMiA0rsqc/Zjemor2NhmMjkM3+X9aC33LmXt7aje5Le6w2MT9bW8xeFxph8WNpoNNNCqULGKztoBM30hi4dHvrBsg/VHbNRbhiXyd78nReI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JHV+mvu6; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JHV+mvu6" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778638898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I7u83GKnKUGOnUrGXw0W+nrtZL5sO6z6MsOIoWVl5DY=; b=JHV+mvu6k0ZemGgYGRlIeWt0HO7fO21M3/FcMLEItPRrbJR2tLKpeMG2BEMPd9vQtzrxA2 FvN0QI2kQhU7o8Gjcg4DmMNjQJy04jYwthQM7qwTzpiT7f3k6UQfQ7GIvnWhPZWR2/r3M1 AnNLjeTlpqYgk71h6jhX2DaHgLOvVDk= From: Ye Liu To: Andrew Morton Cc: Ye Liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] tools/mm/page-types: Fix ternary operator precedence in sigbus handler Date: Wed, 13 May 2026 10:21:17 +0800 Message-ID: <20260513022120.58033-3-ye.liu@linux.dev> In-Reply-To: <20260513022120.58033-1-ye.liu@linux.dev> References: <20260513022120.58033-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Ye Liu The ternary operator (?:) has lower precedence than addition (+), so the expression `off + sigbus_addr ? sigbus_addr - ptr : 0` was parsed as `(off + sigbus_addr) ? (sigbus_addr - ptr) : 0` rather than the intended `off + (sigbus_addr ? sigbus_addr - ptr : 0)`. Add explicit parentheses to ensure the correct evaluation order. Signed-off-by: Ye Liu --- tools/mm/page-types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c index 6594245217a8..66f429f2b698 100644 --- a/tools/mm/page-types.c +++ b/tools/mm/page-types.c @@ -1000,7 +1000,7 @@ static void walk_file_range(const char *name, int fd, fatal("madvise failed: %s", name); if (sigsetjmp(sigbus_jmp, 1)) { - end = off + sigbus_addr ? sigbus_addr - ptr : 0; + end = off + (sigbus_addr ? sigbus_addr - ptr : 0); fprintf(stderr, "got sigbus at offset %lld: %s\n", (long long)end, name); goto got_sigbus; -- 2.43.0