From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29D23A6EF6 for ; Wed, 13 May 2026 05:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778650974; cv=none; b=cd8rh14eZG+kpv6tO+NgD6X8O8PZ6HQ63t7JC2UmE1n2cT9kdY2biP51lYj6UO9T3QKZqM+4CSA/zZpt0JiMLnBupWcHHIKv2qHeMf2ciTlZUKfTC+wAD6qtnCllfNhnePA2pfXbRT4Cyc7sYzxcpAA6XwLzuOCv+3TwbBVJUg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778650974; c=relaxed/simple; bh=AUFheTiaIdq9G2k4NVJD81/GQk2hPB7b+FIJOQIso9w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=me/LgLWQEdYpJsMYLCUjtC/jJ1ATP/D67feDxrEIiQop2h94WlvXIgFuDfvQF5XHl2LS3h/GyZdJG/ShMsNPtABwi5uzX/Ckwi+uplA003bNLan1Udhp2rk30I9vVOdPPhrKoh99UtHp/B40ZtAzPlFBw8J0HGQGUnLP7gVfsrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i9ZSlOdZ; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i9ZSlOdZ" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488af9fdaa7so35876145e9.1 for ; Tue, 12 May 2026 22:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778650970; x=1779255770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yYBEv39uEgMy3N++VlBuBjtbHkIyYso+pXEc18UPlvk=; b=i9ZSlOdZg4mmOpjerXieSv0dag7k37jcmPIvfypYeERjNpfVzKPcsE1HgHxo0OuFiX rlYOAVxpLmalWozT+7vL0yBF5S5GFPlY1KqXgSsMHR8igRadrX2gUa17w4jEjjYQImyz GUMN9cKMKJZ1p/iudPC6WP5MewRM5ddKXgQ186o7DBOjpxCEOOSVkstNDmnfUMU54/2H v7xXFmKA49viGnQ0B8FMwYGRErVDX6NAAlsbBX0FPfuBlgUIJqzRtpd30wyESG4bIopc fn/I9+utPJFb2z3MdQgIH9piM0tOGvky/Nx1ROzsYm5vWy5wdVfqNTAYUoBdohFVtVxC W9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778650970; x=1779255770; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yYBEv39uEgMy3N++VlBuBjtbHkIyYso+pXEc18UPlvk=; b=C4lEcJ8zvnlx1QP43jT/mOKKkniDpQStDZgEIY22jXDnL46rRQkqTXvxNm/Ic9eq3X X7heEeNLYCQ/4e+Ra/htmqipmVuwt4fl3NOKmnrn3I1yxthmoPwM7uJ31KdkMtb01iGn 3rLtaiqjaxbtTTXCH861TqiiCDNGmYAnouvrFkS5G6CklZKXNRb7Sy0YFWlHEYLuFw8c wyquxk6p2mtR9hQ3XfAEhI4hNl5cZ1cWgkPzXBEQ6nWVO6Dx6vkh2IZ0w3JF0OiwsGnK 5LLvNnCCkzmLhZoyXZQECS0VKmN+BntgTjIUcnOiohXhUL0IZ0T5xtUMaClQ6AZ4mzpq vXTQ== X-Forwarded-Encrypted: i=1; AFNElJ8qygcPeCzXbF80udq87Jf/qpMPPrd9HcgDcUVJ0Wjz+DdEy1X0X94CnlipUeQx7pQ/hVYLXoB/ucon0xw=@vger.kernel.org X-Gm-Message-State: AOJu0YxYva1eNeWU7zOy9KK8wjOsqPSMCyWU0kQMLKNmpLEcKQ83boO/ 7HgaDrua6RcL7nBykn+LpOhCaFzE0Pw+AhONBlGgVIFG6ug2o5BpyB6y X-Gm-Gg: Acq92OEVNaVVd7Z8AD0NgRp5mo2B7dYAjF7IfXBAvuKjvRmPdzRQsqVoH5ORCmUMNji L/XHmUI+V71nh8CbHunqDd4hpp3SXakI2s7arMw6dS9tW+jFOaq4cI4ENudxarVPp9cE3fpBODc yjCDOWpW9wxR1NPKJ2DoFLDxHiDkyCqCYLXiYrpnI/FpedynyglmOLWSCKhsZIRkRmcGv+xHoWa Ce5nsNQYdA4m9fqVci4HNxCdXS8lcspncHfeL/x4IRmCEf/69D+GZfduK0nVpRlDhiAJwyAcK9M DhIzsgqMWoys2iag+NGigI/FjopgeUIMf3PRWjzBaIbtXX6Zk4bohwLZa+MLYlxY9nYv/gYeWwP vArZZIUWPzmhw8KLlJvR42agq8rA9wh0LLkei6rxF+7vkGHVtxvWEf9MIGlgtYFsy5I+YaNJ6Xr qg7ucN7KnkXbQ6sqn+wJsQZlJZAXtNanaz4dbZUw1wXXedonoV8G9iK6p7 X-Received: by 2002:a05:600c:3f0c:b0:48a:55d8:7882 with SMTP id 5b1f17b1804b1-48fc9a0ead2mr20611005e9.9.1778650969796; Tue, 12 May 2026 22:42:49 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([31.7.57.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fce37b182sm38558085e9.9.2026.05.12.22.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:42:49 -0700 (PDT) From: Valery Borovsky To: hverkuil@kernel.org, mchehab@kernel.org, hansg@kernel.org, linux-media@vger.kernel.org Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Valery Borovsky Subject: [PATCH] media: pwc: Drain fill_buf on start_streaming() failure Date: Wed, 13 May 2026 08:42:44 +0300 Message-ID: <20260513054244.143866-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pwc_isoc_init() submits its isochronous URBs with usb_submit_urb(.., GFP_KERNEL) in a loop. After the first URB is submitted, its completion handler pwc_isoc_handler() can run on another CPU before the loop finishes: start_streaming() pwc_isoc_init() usb_submit_urb(urbs[0], GFP_KERNEL) pwc_isoc_handler(urbs[0]) pdev->fill_buf = pwc_get_next_fill_buf(pdev) usb_submit_urb(urbs[i>0], ..) -> fails pwc_isoc_cleanup(pdev) /* kills URBs */ return ret; pwc_cleanup_queued_bufs(pdev, VB2_BUF_STATE_QUEUED) pwc_get_next_fill_buf() detaches a buffer from pdev->queued_bufs and stores it in pdev->fill_buf. The error path in start_streaming() only drains pdev->queued_bufs, so the buffer parked in pdev->fill_buf is leaked. vb2_start_streaming() then triggers WARN_ON(owned_by_drv_count). stop_streaming() already handles this since commit 80b0963e1698 ("[media] pwc: fix WARN_ON"), which added the fill_buf drain in the teardown path but not in the start_streaming() error path. Mirror that handling on failure so start_streaming() returns with no buffer owned by the driver. Issue identified by automated review of the INV-003 series at https://sashiko.dev/ Fixes: 885fe18f5542 ("[media] pwc: Replace private buffer management code with videobuf2") Cc: stable@vger.kernel.org Signed-off-by: Valery Borovsky --- drivers/media/usb/pwc/pwc-if.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c index c416e2fc5754..26ce7106ae30 100644 --- a/drivers/media/usb/pwc/pwc-if.c +++ b/drivers/media/usb/pwc/pwc-if.c @@ -726,6 +726,11 @@ static int start_streaming(struct vb2_queue *vq, unsigned int count) pwc_camera_power(pdev, 0); /* And cleanup any queued bufs!! */ pwc_cleanup_queued_bufs(pdev, VB2_BUF_STATE_QUEUED); + if (pdev->fill_buf) { + vb2_buffer_done(&pdev->fill_buf->vb.vb2_buf, + VB2_BUF_STATE_QUEUED); + pdev->fill_buf = NULL; + } } mutex_unlock(&pdev->v4l2_lock); -- 2.51.0