From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 014073B38B0 for ; Wed, 13 May 2026 05:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651813; cv=none; b=JtRpUycZcjgmgpV5INGEI1GiW3wgIDPxFiYhPDBhmjjwJh2DvDwKQHXo69bklPeMgjsOKBBEXKF+V6o0bSggRBmMNKVaawF/0nIpcrC+qTE+nlWLleau33CEFNa8MyN4cHHbVdzV/0M06HRncQ9PWPOU9kQ23nbyPx1C66w0d2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651813; c=relaxed/simple; bh=iwshQxBJRKng2AeZeJRg2jhjyadmBg+GsEws2R7KPQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F0kZZPw8VVMcGUHKYlFaY0UyxMsSl2LGjACdfGYXYb7xul+WVwaw1L9LWyM6ynBUk7DOEWURPBkLucWX0swgtqzbr72Yii6oAb46s2Rwt1k85G/S2P/OK7EIU8tCIfJ7ia0O9q9AXfmbLRPiAgKcPLToOLKyNu6yOfBSr42WSLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EV6Urh1A; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EV6Urh1A" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3660daea6a5so3445854a91.1 for ; Tue, 12 May 2026 22:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651808; x=1779256608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/LoS/AHTeCtpWKc6PkMtF6EkZQfXCl5pc+5m7F4o70U=; b=EV6Urh1Av4mx+pUBLNBkWjvqaY+1QN3SUzlODlGacThToGGsuyo8fFCWUL6TM3Z//Y iJTbq4Q2gApo2YLt91itnfy+2/kDwXed9WYG3LqIRBoo9XU1QgN3p2Bbz5OEfmo+Fk6A umc3Lh4mt7uQul4TfKmf4nJbgtM7wZcpsEk+G6+yCL6xfObWWxF/Jjey01B9zsenqSt4 OZjoPGP8ZR8zYYlbYWL8BZrKiCbrtI1uWq9FNYhBzk4GEtj4BlrBXcPeue7xJ5FbiZx+ ThVue8TlkRXDsLIUDJDBkgGBYVi6tjYOzV81oOlUbxiBL1S2GIIyYgiUgxOgfGiJSGxo y2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651808; x=1779256608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/LoS/AHTeCtpWKc6PkMtF6EkZQfXCl5pc+5m7F4o70U=; b=EnELiIo8lrXLwWsKmkZwk12K3/swMUjmHclABSckQYEEkW+vaM6TkiGuFbQZstWXXY YGMViGF08ZHJp5C+bRDSIkHe3Jast0KCs85urxEv7K8Ugrl7EAcM5VRjArEYs/yOI+eu bGB7tn+BV0x3jkmgeoY8A4p5nM9jmcegF22uQB+9szhvHjtQSsCHKcR93Rz0ZegjAs5W kfePzwURwWabNLLKP+vWpejsO8c3xQ07mAeMtKCl7p8wyC5MvnEa9D1cJIyndkEwyPc6 UujfgQJ8pqO8+A1ARJk/NnyYWF0esxU68N+yDUGEaQQ73cqOO2k3iNb+TKb7VBG4pvuG KYSw== X-Forwarded-Encrypted: i=1; AFNElJ8vlt/NailFXKR0cePUBmf0lL4MUEdMkElfmqrUgWv4sGHj8dSAhGOT0vgQIyhBm8GbqslnZ+pokS599rs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx70MShWAa3uf2BS+7/1fWXTjVVTYxePQynaDFb6z3g9PQwTk0D QnqLoFSITjv12ksHtSSzSYY5GFSq9zluLbfmYLk2bzHitsb1q+FOwmE/ X-Gm-Gg: Acq92OFgfgd+wKaEWGP5WuH0NmQCOs+OXf00oqe0WYoZQ3BPf43an0EfCcby77wOZRa 0qkL/u0IaYcqBy1wpoo3rNakV10yUx4K3pP9VHtyqT143Fjj8ryRhDOCmTD+6bk8FfL6YAWegF4 J4h9NUc/so4+kxmO+fFPAT6fnUYu42JQOtCAmnJJUsKg9loQ7y2i4HIGX+391qaf5NUdohKw0rU +3fbxdG62/VETRRbdqo5GEHip780vZO1Q2tJpcxcz2TG9CK4pCxHoSRJsjHcM5q+ew4ttNG/jag mJPpnhmA07X2SrJMVWOvLU1IYEUnd5YNsgn6YNoB/SvDjbpOuRv8FZIhGcJQRI0S3/WRYrM7DVt NgZDs94lJxihzZvxQ0Ih4ag+dlmJjb9k+R5FEJnCgTicoABKFoTZwHn4w6m0QoZIRBYOUj4sStJ iO+lY8Ie/+uCgjU11G8GxdSu9eBV6SXagnqZ8juv3659GPT0+Z8g16JII/sZKmPXqzyO2cB1ltC kTOqPLQxO1OI/4UmcIr+sA= X-Received: by 2002:a17:90b:5688:b0:356:22ef:57ba with SMTP id 98e67ed59e1d1-368f781c7b9mr1480053a91.7.1778651808190; Tue, 12 May 2026 22:56:48 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368ee32822asm1785492a91.12.2026.05.12.22.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:56:47 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v2 2/3] clk: nuvoton: ma35d1: fix PLL_CTL1_FRAC bit field width and fractional calc Date: Wed, 13 May 2026 13:56:25 +0800 Message-ID: <20260513055626.1070533-3-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260513055626.1070533-1-a0987203069@gmail.com> References: <20260513055626.1070533-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PLL_CTL1_FRAC was defined as GENMASK(31, 24), covering only 8 bits. The hardware fractional field occupies bits [31:8] (24 bits), so the mask must be GENMASK(31, 8). The previous fractional-mode calculation used FIELD_MAX(PLL_CTL1_FRAC) as the denominator to obtain 2 decimal places. With the corrected 24-bit mask the old divisor is wrong; replace the arithmetic with a proper 24-bit fixed-point rounding to 3 decimal places: n_frac = n * 1000 + (x * 1000 + 500) >> 24 The +500 term provides round-to-nearest before the right shift. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller") Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk-ma35d1-pll.c index bfedd45bd04b..7e6b30d20c01 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -48,7 +48,7 @@ #define PLL_CTL1_PD BIT(0) #define PLL_CTL1_BP BIT(1) #define PLL_CTL1_OUTDIV GENMASK(6, 4) -#define PLL_CTL1_FRAC GENMASK(31, 24) +#define PLL_CTL1_FRAC GENMASK(31, 8) #define PLL_CTL2_SLOPE GENMASK(23, 0) #define INDIV_MIN 1 @@ -113,9 +113,9 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 *reg_ctl, unsigned long p pll_freq = div_u64(pll_freq, m * p); } else { x = FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); - /* 2 decimal places floating to integer (ex. 1.23 to 123) */ - n = n * 100 + ((x * 100) / FIELD_MAX(PLL_CTL1_FRAC)); - pll_freq = div_u64(parent_rate * n, 100 * m * p); + /* x is 24-bit fractional part, convert to 3 decimal digits */ + n = n * 1000 + (u32)(((u64)x * 1000 + 500) >> 24); + pll_freq = div_u64((u64)parent_rate * n, 1000 * m * p); } return pll_freq; } -- 2.43.0