From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979C73B8409 for ; Wed, 13 May 2026 05:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651864; cv=none; b=VYc7Uu02dD6LALdPmDZmdznyJmxCHPZ1xU5FnVPR8X4XLb+2OVbnc4px/tjHLvxArMtOi7chl2sLbOLrPkO5ffN87gGWve3WCUZ1QvxEd562mnsEKTCGtysjipHY5r0TKxv6OXaJL1VOrei51YuShkBVJOzynOJ36b53puQfg8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651864; c=relaxed/simple; bh=s6BfnkAql2MTDlPesu3S+RGrhsYSXwRQZEBa/vKhnW0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f6gwAECms+Y2mFAilTyB8P4E3M0V/zhzlerZY7Wg+lz34jqEvaIRLnA8EjrxUCVKBe+qdLcm4BhvC3fbB47d/ICbywGk0tD4S1vejYhAUWryZkXzUBSCdE4W+I8/u0w8wDgOCQU/mR3deh6u0lrBCyJUNvB906PX+2LuTyAvHZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YOOCPeRI; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YOOCPeRI" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso43034245e9.0 for ; Tue, 12 May 2026 22:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651858; x=1779256658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MUFuofREYZSwb8K19QV9xCXORpxZYXHR7ZkCUNHTKDk=; b=YOOCPeRIlPCyljhgquYup6R2864qZ4Z4CKhL6i/DIZspLXlGE/Eaww7bHzsb31Kb9k ECV4DQPn2HZqtSuJEaof2FA2Fjafg6xgPgEb2iNyQqwKG0DnxWn2CcZ5IdPL8HiriYir EQPf2LQCPp3kHi9AiTNUTdX4n1AXOVCXepTZs92xHCR0ruS5X1Z0wXYADR9o/ax2PNNl xBA+Ilx6eQWLroi1PN2yJPVoOVd8QC9x+4b2ZGeoTplfrVnPDm3aT+Zrgvz/j3Mc9M6X C9omFhc5DpUWFLAEFFSzQZhNDuEayYlz3XMcXsCIZ6QTbAvaqZpwaT5DfS3NYy/OazS/ 4otA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651858; x=1779256658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MUFuofREYZSwb8K19QV9xCXORpxZYXHR7ZkCUNHTKDk=; b=hyC3StLzIVwLHBcFEOxRh4bBJVuZ+vJkgvDMOLjvpFZDuAZzXmggc+6Fe5DPoX38z+ ct/RIyzsp75Un4VJEf2Gr+N2ojFRJs/4uzkF3BD5UhC0/k28/IEZfHAEYZnL+6Y4eKdb TsiMP+QprJB6I8KxTnwgRDneP+6yTYacK0Y/hOHirnmxgS85o0OseZJQY0YXu+gzBkNL 43mG+G8GqwNMbM2yZl6e9UyP9n1TBkschcVdYzoYSaJBW1Y5zfYIC9AIE3N+Q7fdMfQA ZlyucMEm/TlWg/cRhj1HhzUgmuYPd/WfLyCeIcm8CcYlm64+YJr7p+0Wy57OsZZ40p8p UbyQ== X-Forwarded-Encrypted: i=1; AFNElJ8rWN7YEri0BnbpkCBdijBAdYOT1+Yc3HNdfC/XJMhrjEDtinsC3jcw/2+hxiBeNegb+Dcudfmp8qvv8dM=@vger.kernel.org X-Gm-Message-State: AOJu0YxLO5U2oDiBuxn66oZQIiaJkCiinmDh7qh1YwY4If1+rykfQn/V tN5xQSNXMw9bgzu3PNJaiK6sZ45g7L4j//K154PGmPwCllXmRj7toQBl X-Gm-Gg: Acq92OEhBd2tdT6Z3TWWRcFOWP6Z4fnYpi79QP7X4ZjEOw0WBh2vnreyvFV5AP/a1E2 7ADNX+cHz3yjWF6KbS5BXTeUF5JIBfzWqWJ8E+SV98EgNmzZ2rCaRi3DQmFFu0gPvuDbUtbQ1pu X2vAl2+hAgsoiMkkHxsAv85WyxKXQoyq0+kDpjLwl5PazPgom92RbNBJL1js+YxELZBkrIvzgQX 5UJkaaBokK9/hSX1oo6kbmIzIIxb1dHJvnrDbZnjuqq8i0t8JetkOfCp4o1Ang0vddoTPjNvDQ2 SUnLpRN18DECRUDO+WqZXeTp6EadG/s1I+NeeGjKz7ta+hDSjV9L5Qfcz+b0CQP4RouyWtBBu8g r2HXAU7JvM7ApCEznrAgf4QGJg9ncImdK6SS0p3Zaonbr3kknRBkj81iey9JxfmKXq5ASAPcjiP GzEjLSnK5xYfixJPer6u0D5zKJJFS/mbZhb17/l9VOavOb2bocSJMLwNiLQacmADk7JRU= X-Received: by 2002:a05:600c:6096:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48fc9a30d10mr22234605e9.14.1778651858485; Tue, 12 May 2026 22:57:38 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([31.7.57.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4549120f1f9sm38447271f8f.24.2026.05.12.22.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:57:38 -0700 (PDT) From: Valery Borovsky To: mchehab@kernel.org, crope@iki.fi, linux-media@vger.kernel.org Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Valery Borovsky Subject: [PATCH] media: rtl2832_sdr: release URBs and stream buffers on start_streaming() failure Date: Wed, 13 May 2026 08:57:33 +0300 Message-ID: <20260513055733.146905-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtl2832_sdr_start_streaming() calls rtl2832_sdr_alloc_stream_bufs(), rtl2832_sdr_alloc_urbs() and rtl2832_sdr_submit_urbs() in sequence and shares a single err: label that only unlocks the mutex and returns. When alloc_urbs() succeeds but submit_urbs() fails, or when alloc_urbs() itself returns -ENOMEM after alloc_stream_bufs() has already succeeded, the URBs and/or the coherent DMA stream buffers stay allocated while streaming reports failure to vb2. Two latent defects follow on the next VIDIOC_STREAMON: 1) rtl2832_sdr_alloc_stream_bufs() unconditionally resets dev->buf_num to 0 and overwrites dev->buf_list[]/dev->dma_addr[], permanently leaking the coherent DMA memory allocated by the previous attempt. 2) rtl2832_sdr_alloc_urbs() never resets dev->urbs_initialized and only increments it. After a second successful pass urbs_initialized can exceed MAX_BULK_BUFS, so the subsequent rtl2832_sdr_free_urbs() walks from urbs_initialized - 1 down to 0 and reads past the end of dev->urb_list[], passing garbage pointers to usb_free_urb(). Mirror the teardown that stop_streaming() already performs: on the error path call rtl2832_sdr_free_urbs() and rtl2832_sdr_free_stream_bufs() before unlocking. Both helpers are idempotent (free_urbs kills and zeros urbs_initialized; free_stream_bufs is gated on URB_BUF and clears the buf_num counter), so partial-failure paths and the no-allocation paths remain safe. Issue identified by automated review of the INV-003 series at https://sashiko.dev/ Fixes: 771138920eaf ("[media] rtl2832_sdr: Realtek RTL2832 SDR driver module") Cc: stable@vger.kernel.org Signed-off-by: Valery Borovsky --- drivers/media/dvb-frontends/rtl2832_sdr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c index 422d1a7b5456..efcef1317cf9 100644 --- a/drivers/media/dvb-frontends/rtl2832_sdr.c +++ b/drivers/media/dvb-frontends/rtl2832_sdr.c @@ -900,7 +900,13 @@ static int rtl2832_sdr_start_streaming(struct vb2_queue *vq, unsigned int count) if (ret) goto err; + mutex_unlock(&dev->v4l2_lock); + + return 0; + err: + rtl2832_sdr_free_urbs(dev); + rtl2832_sdr_free_stream_bufs(dev); mutex_unlock(&dev->v4l2_lock); return ret; -- 2.51.0